|
Picture this. VB.NET code written by a newb that needs to be updated with some support for a new file format.
I'm looking at a single method that's 17 pages(!) long and doesn't return anything.
It contains NINETY EIGHT If statements. Some are chained together with ElseIf, some are nested down to five levels deep.
There is lots of this:
If condition-expression Then
ElseIf condition-expression Then
If condition-expression Then
Else
EndIf
ElseIf condition-expression Then
ElseIf condition-expression Then
Else
End If
Shoot me. Please. I beg of you.
|
|
|
|
|
So do you guys really have no process for vetting noobcode?
|
|
|
|
|
This isn't a production app. It's a tool that's used by a couple of teams, and no, there was no cuh thing a vetting.
|
|
|
|
|
Wait!
I think I know that guy who wrote that method.
I mean, there couldn't be two people in the world that would do that could there? 
I thought he was drummed out of development years ago though.
EDIT
Oh, wait, our guy didn't use methods.
He wrote all of his code copy/past style and it was something like 20 pages long too.
It was the same for loop copy pasted over and over.
And, it was in prod and it finally failed in the for loop.
So Instead of fixing it in one place... 
Yes, I'm serious.
EDIT 2
And I should mention -- and I'm not kidding -- he was a MCSD. Fantastic test taker, I'm sure. 
|
|
|
|
|
Quote: he was a MCSD. Fantastic test taker, I'm sure.
I is all book smarts and stuff now. 
|
|
|
|
|
I've been a professional programmer for over 30 years, and can assure you that there are many, many folk who produce that kind of cruft.
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
You owe it to yourself and those that follow to refactor that thing. Otherwise, the next If Then you add might cause the compiler to wave the white flag with a "Nesting too deep" error.
Seen it, done it. At least the doesn't have goto's does it? Mine had that too.
|
|
|
|
|
MarkTJohnson wrote: goto
You mean something like:
If condition-expression Then
ElseIf condition-expression Then
If condition-expression Then
Else
...
Goto Step123
EndIf
ElseIf condition-expression Then
...
:Step123
...
Goto Step234
ElseIf condition-expression Then
Else
End If
...
:Step234
...
Goto Step123Oh yeah, that's much more interesting!
Oh sanctissimi Wilhelmus, Theodorus, et Fredericus!
|
|
|
|
|
I know the feeling.
And in SQL too.
|
|
|
|
|
I could swap your VB with some MATLAB I've got hanging around here.
veni bibi saltavi
|
|
|
|
|
I'm having the same issue here, just the code is in JS.
Beauty cannot be defined by abscissas and ordinates; neither are circles and ellipses created by their geometrical formulas.
Carl von Clausewitz
Source
|
|
|
|
|
Paid by the line?
"If you don't fail at least 90 percent of the time, you're not aiming high enough."
Alan Kay.
|
|
|
|
|
What verb describes the act of using the phonetic alphabet? (ie: Alpha, Romeo, Foxtrot etc)
Thanks
[EDIT: Ooops seems like I misposted, should've been the Lounge  ]
... such stuff as dreams are made on
modified 12-Oct-17 9:47am.
|
|
|
|
|
Idioting?
* CALL APOGEE, SAY AARDWOLF
* GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
* Never pay more than 20 bucks for a computer game.
* I'm a puny punmaker.
|
|
|
|
|
Idioting is when you deliberately misunderstand a question.
... such stuff as dreams are made on
|
|
|
|
|
I thought that willfully misunderstaning was ElizabethBenneting...
(I forgot the joke question. And yes, I am skilled in idioting... a Master Idiot, I think).
* CALL APOGEE, SAY AARDWOLF
* GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X
* Never pay more than 20 bucks for a computer game.
* I'm a puny punmaker.
|
|
|
|
|
Funny answer ... don't be too demanding for yourself
|
|
|
|
|
The verb depends on what you're using it for (spelling, reciting, memorising etc.) You could then combine said verb with an adverb such as phonetically or acrophonically (e.g. "He spelled out the word acrophonically") but that wouldn't necessarily point to the NATO alphabet without further qualification.
98.4% of statistics are made up on the spot.
|
|
|
|
|
I mean the verb for speaking audibly over a crappy phone or radio connection.
"Sorry I cannot hear if you are saying "F" or "S" would you please ----?"
... such stuff as dreams are made on
|
|
|
|
|
spell?
If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson
|
|
|
|
|
I doubt that. I am pretty sure "spell it out" could be speaking like: "S", "S", "L".
... such stuff as dreams are made on
|
|
|
|
|
I think I'd just ask them to spell it phonetically or just prompt them with "Is that F for foxtrot, S for sierra?"
If there is a specific word for it - and I doubt that there is - it would be so obscure that they wouldn't recognise it over a crackly 'phone line.
98.4% of statistics are made up on the spot.
|
|
|
|
|
|
icaoing?
If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson
|
|
|
|
|
If there were, very few people would know what you mean when you say it. 
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
