C / C++ / MFC

11-Nov-11 7:05

I'm building a WCHAR Array, of server names to write to a REG_MULTISIZE Registry Key, But I'm unsure if I did the right thing.

The rule was a ServerName\0ServerName\00, but I get

"﷽﷽ꮫꮫꮫꮫﻮﻮﻮﻮﻮﻮDELLC521-01\SQLEXPRESSDELLC521-01\SQLEXPRESSWSA1\SQLEXPRESSDELL760\SQLEXPRESS2"

I'm not sure if my \0 went in, and I need to fix the prefix

// Write the SQL Servers to the Registry
        WCHAR *pzServerNames = new WCHAR[0];
        for ( int i = 0; i < sqlCount; ++i ) {
            pzServerName = sqlSrvCollection[i];
            wcsncat(pzServerNames, pzServerName, wcslen(pzServerName) );
            wcsncat(pzServerNames, L"\0", wcslen(L"\0") );
        }
        _wcsncat_l(pzServerNames, L"\0\0", wcslen(L"\0\0"), NULL);

Mark Salsbery11-Nov-11 7:51

Mark Salsbery

11-Nov-11 7:51

I guess first of all you're lucky it didn't crash since you allocated an array of 0 length.

Mark Salsbery
Java | [Coffee]

jkirkerx11-Nov-11 8:12

11-Nov-11 8:12

I guess that wasn't a good idea. I think I'm going to abandon that idea, and change the registry program to add 1 server name at a time. Read the key, and if the name is not there, then add the name and write the key back.

Richard MacCutchan11-Nov-11 22:48

11-Nov-11 22:48

Try this:

C++

// first go through the names calculating how much space we need
int length = 0;
for ( int i = 0; i < sqlCount; ++i )
{
    length += wcslen(sqlSrvCollection[i]);
    length += 1;    // don't forget to add one for the trailing null
}
// allocate a buffer big enough to hold the strings
WCHAR* pzServerNames = new WCHAR[length + 1];    // plus the very final extra null
PWSTR pNext = pzServerNames;    // a temporary pointer
// now go through copying each string to the array buffer
for ( int i = 0; i < sqlCount; ++i )
{
    wcscpy_s(pNext, length, sqlSrvCollection[i]);    // copy the next name into the array
    int nlen = wcslen(sqlSrvCollection[i]);          // get its length
    pNext += nlen;                                   // move the pointer forward
    *pNext++ = L'\0';                                // add the null (incrementing the pointer)
    length -= nlen + 1;                              // reduce amount of space left
}
*pNext = L'\0';    // add the final trailing null

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

jkirkerx12-Nov-11 7:01

12-Nov-11 7:01

Yeah, I thought I was going to have to do a per-calculation. I changed the format of the program, and opted for adding the server name 1 at a time. So when I add the name to the collection, I add the name to the registry key, which is multi-size. Sort of like the MimeMap Program, in which I read the key, look for a duplicate, if no duplicate, add the name, write the key back.

I will take your wisdom, and mix the 2 together. I wrote this yesterday, which is better than the the one I had in question. I know it has issues, in which I will straighten out today, on this rainy day.

I'm going to dump the wcsncmp for a straight value = value.

TCHAR   szAddServerName[120];
    WCHAR   *pzServerNames = NULL;

    // Format ServerName Value
    int idx = wcslen(pzServerName);
    for (int i = 0; i < idx; i++) {
        szAddServerName[i] = pzServerName[i];
    }
    szAddServerName[idx] = L';';
    szAddServerName[idx+1] = L'\0';

    // Get existing ServerNames
    pzServerNames = CA_Registry::_get_Enumerated_SQLServers();

    // Extract the ServerNames
    int iCompare;
    wchar_t *token1, *nextToken;
    wchar_t seps[] = L";";
    token1 = wcstok_s(pzServerNames, seps, &nextToken);
    do {
        iCompare = wcsncmp(szAddServerName, token1, wcslen(szAddServerName)-1 );
        if (iCompare != 0)  {
            wcsncat(pzServerNames, L";", wcslen(L";") );
            wcsncat(pzServerNames, szAddServerName, wcslen(szAddServerName)+1 );
        }
        token1 = wcstok_s(NULL, seps, &nextToken);
        if (token1 == NULL)
            break;
    } while (TRUE);

    int iLength = wcslen(pzServerNames)+1;
    pzServerNames[iLength+1] = L'\0';

    WCHAR *szServerNames = new WCHAR[iLength+1];
    wcsncpy_s(szServerNames,  pzServerNames, wcslen(szServerNames) );
    szServerNames[iLength] = L'\0\0';

jkirkerx12-Nov-11 9:17

12-Nov-11 9:17

I give your suggestion a spin, I don't understand this line. I know the pNext++ is a method to add a wchar to a const, but it goes backwards.

pNext += nlen; // The pNext goes Null
*pNext++ = L';'; // I wanted to add a ; to tokenize
*pNext++ = L'\0'; // takes a wchar off the front

int sql_Count = sqlSrvCollection.Count();
    int length = 0;
    for ( int i = 0; i < sql_Count; ++i )
    {
        length += wcslen(sqlSrvCollection[i]);
        length += 2;    // don't forget to add one for ; and the trailing null
    }

    // allocate a buffer big enough to hold the strings
    WCHAR* pzServerNames = new WCHAR[length + 1];    // plus the very final extra null
    PWSTR pNext = pzServerNames;    // a temporary pointer

    // now go through copying each string to the array buffer
    for ( int i = 0; i < sql_Count; ++i )
    {
        wcscpy_s(pNext, length, sqlSrvCollection[i]);                       // copy the next name into the array
        int nlen = wcslen(sqlSrvCollection[i]);                             // get its length
        pNext += nlen;                                                      // move the pointer forward
        *pNext++ = L';';                                                    // add the ; to tokenize
        *pNext++ = L'\0';                                                   // add the null (incrementing the pointer)
        length -= nlen + 1;                                                 // reduce amount of space left
    }
    *pNext = L'\0';    // add the final trailing null

Richard MacCutchan12-Nov-11 21:36

12-Nov-11 21:36

Incrementing the pNext pointer, merely moves it along the array, by a number of characters (pNext += nlen) or a single character (pNext++). After incrementing it will appear to point to either an empty cell or some garbage. This is fine as long as the next statement fills that cell, by adding a new string or termination character. In my sample I was adding a NULL (L'\0') character after each string to create a REG_MULTISZ array. What you have done above is to add a semi-colon before each NULL which is superfluous. If you want a string that is tokenisable then put the semi-colon instead of the NULL, but make sure you still put the NULL at the very end.

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

VC 6.0 MFC MDI new frame / view without caption erases Windows → New titles

David Crow14-Nov-11 2:39

David Crow

14-Nov-11 2:39

jkirkerx wrote:
...But I'm unsure if I did the right thing.

Anytime you are needing to deal with the '\0' character, functions like strcpy(), strcat(), strlen() and the like are off limits.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Vaclav_11-Nov-11 3:09

Vaclav_

11-Nov-11 3:09

This code removes the caption from the frame, however, it also removes all the title data from the Window – New view, only the number of the new window is there, but the document string (title) does not change.

strTitle = pDocument->GetTitle();
DWORD style = pFrame->GetStyle();
pFrame->ModifyStyle(style,WS_CHILD | WS_THICKFRAME ); // remove all , and no caption
strTitle = pDocument->GetTitle();

How do I access the standard Windows menu to put the title back in ?

As always, your help is appreciated.

Thanks Vaclav

I have modified
pFrame->ModifyStyle(WS_CAPTION,NULL);
It keeps the menu document title, but Window tiling does not work wihtout the caption. No surprise here.
I do not need tiling anyway.

I am still looking for ways to replace the New view "serial number " with
title preferably from menu.

-- modified 13-Nov-11 7:35am.

Re: VC 6.0 MFC MDI new frame / view without caption erases Windows → New titles

Richard MacCutchan11-Nov-11 5:27

Re: VC 6.0 MFC MDI new frame / view without caption erases Windows → New titles

11-Nov-11 5:27

I do not think that removing all styles from your frame window and replacing by WS_CHILD | WS_THICKFRAME is what you want to do here.

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Vaclav_11-Nov-11 6:09

Vaclav_

11-Nov-11 6:09

Yes I do want to do that, but it may be the wrong place to do this.
I need to have a multiview of a single document and do not want to have title bar in these secondary views.
I may use it only to initialy let the user reposition these views, than I do not need / want the title bar to clutter the destop.
I think the answer must be somewhere in CDocument "title" string.
But I have not found how to change the string at run time.
As far as clearing all the styles - it would be nice to find out what exactly are the default / framework generated styles.

Re: VC 6.0 MFC MDI new frame / view without caption erases Windows → New titles

Richard MacCutchan11-Nov-11 6:38