C / C++ / MFC

// first go through the names calculating how much space we need
int length = 0;
for ( int i = 0; i < sqlCount; ++i )
{
    length += wcslen(sqlSrvCollection[i]);
    length += 1;    // don't forget to add one for the trailing null
}
// allocate a buffer big enough to hold the strings
WCHAR* pzServerNames = new WCHAR[length + 1];    // plus the very final extra null
PWSTR pNext = pzServerNames;    // a temporary pointer
// now go through copying each string to the array buffer
for ( int i = 0; i < sqlCount; ++i )
{
    wcscpy_s(pNext, length, sqlSrvCollection[i]);    // copy the next name into the array
    int nlen = wcslen(sqlSrvCollection[i]);          // get its length
    pNext += nlen;                                   // move the pointer forward
    *pNext++ = L'\0';                                // add the null (incrementing the pointer)
    length -= nlen + 1;                              // reduce amount of space left
}
*pNext = L'\0';    // add the final trailing null

TCHAR   szAddServerName[120];
    WCHAR   *pzServerNames = NULL;

    // Format ServerName Value
    int idx = wcslen(pzServerName);
    for (int i = 0; i < idx; i++) {
        szAddServerName[i] = pzServerName[i];
    }
    szAddServerName[idx] = L';';
    szAddServerName[idx+1] = L'\0';

    // Get existing ServerNames
    pzServerNames = CA_Registry::_get_Enumerated_SQLServers();

    // Extract the ServerNames
    int iCompare;
    wchar_t *token1, *nextToken;
    wchar_t seps[] = L";";
    token1 = wcstok_s(pzServerNames, seps, &nextToken);
    do {
        iCompare = wcsncmp(szAddServerName, token1, wcslen(szAddServerName)-1 );
        if (iCompare != 0)  {
            wcsncat(pzServerNames, L";", wcslen(L";") );
            wcsncat(pzServerNames, szAddServerName, wcslen(szAddServerName)+1 );
        }
        token1 = wcstok_s(NULL, seps, &nextToken);
        if (token1 == NULL)
            break;
    } while (TRUE);

    int iLength = wcslen(pzServerNames)+1;
    pzServerNames[iLength+1] = L'\0';

    WCHAR *szServerNames = new WCHAR[iLength+1];
    wcsncpy_s(szServerNames,  pzServerNames, wcslen(szServerNames) );
    szServerNames[iLength] = L'\0\0';

int sql_Count = sqlSrvCollection.Count();
    int length = 0;
    for ( int i = 0; i < sql_Count; ++i )
    {
        length += wcslen(sqlSrvCollection[i]);
        length += 2;    // don't forget to add one for ; and the trailing null
    }

    // allocate a buffer big enough to hold the strings
    WCHAR* pzServerNames = new WCHAR[length + 1];    // plus the very final extra null
    PWSTR pNext = pzServerNames;    // a temporary pointer

    // now go through copying each string to the array buffer
    for ( int i = 0; i < sql_Count; ++i )
    {
        wcscpy_s(pNext, length, sqlSrvCollection[i]);                       // copy the next name into the array
        int nlen = wcslen(sqlSrvCollection[i]);                             // get its length
        pNext += nlen;                                                      // move the pointer forward
        *pNext++ = L';';                                                    // add the ; to tokenize
        *pNext++ = L'\0';                                                   // add the null (incrementing the pointer)
        length -= nlen + 1;                                                 // reduce amount of space left
    }
    *pNext = L'\0';    // add the final trailing null

jkirkerx wrote:

...But I'm unsure if I did the right thing.

Quote:

CComBoBox

CString CXbeefixedDlg::getCurStrInCombobox(const CComBoBox &a)

char Singature[16] = { 0 };

sdancer75 wrote:

The CString its a dynamic structure and dont need to make reservations in size before.