C / C++ / MFC

6-Oct-09 10:57

Hi,

I am developing a desktop application composed by the main exe and several modules (dll / plug-ins) .
The main modules has a dialog where a CMFCPropertyGridCtrl is used to edit a collection of name/values pair.
Also another dll has a wizard that make use of a property sheet where a CMFCPropertygridCtrl edits another collection of name/values pair.
The application works as expected if only one of these dialog is executed.
No matter what is the sequence, the second time the dialog is opened, the program asserts.
I can open the same dialog more times, and it do not asserts, it asserts only when the second kind of dialog is opened.
The dialog (both) asserts when the mouse pointer is passed over the CMFCPropertyGridCtrl Control, the stack traces from the TrackToolTip function inside the class.
I have tracked the problem to the creation of the tooltip window:

in CMFCPropertyGridCtrl::Init() the call to m_IPToolTip.Create(this) fails:

BOOL CMFCPropertyGridToolTipCtrl::Create(CWnd* pWndParent)
{
ASSERT_VALID(pWndParent);
m_pWndParent = pWndParent;

if (m_strClassName.IsEmpty())
{
m_strClassName = ::AfxRegisterWndClass(CS_SAVEBITS, ::LoadCursor(NULL, IDC_ARROW), (HBRUSH)(COLOR_BTNFACE + 1));
}

return CreateEx(0, m_strClassName, _T(""), WS_POPUP, 0, 0, 0, 0, pWndParent->GetSafeHwnd(), (HMENU) NULL);
}

The first time this function executes, the CreateEx return TRUE and all works as expected.
The second time, only if from a different module (DLL or EXE), m_strClassName is not empty and CreateEx fails with error code 0x00057f e.g. "Warning: Window creation failed: GetLastError returns 0x0000057F" that is ERROR_CANNOT_FIND_WND_CLASS.
I do not use any tooltip, so I could also disable the tooltip feature.

(stack trace of the assertion, when the mouse passes over the grid (WM_MOVE) )

mfc90ud.dll!CWnd::GetWindowRect(tagRECT * lpRect=0x0012f06c) Riga 116 + 0x2a byte C++
mfc90ud.dll!CMFCPropertyGridCtrl::TrackToolTip(CPoint point={...}) Riga 3321 C++
mfc90ud.dll!CMFCPropertyGridCtrl::PreTranslateMessage(tagMSG * pMsg=0x00154e10) Riga 3937 C++
> mfc90ud.dll!CWnd::WalkPreTranslateTree(HWND__ * hWndStop=0x003e0662, tagMSG * pMsg=0x00154e10) Riga 2946 + 0x14 byte C++
mfc90ud.dll!AfxInternalPreTranslateMessage(tagMSG * pMsg=0x00154e10) Riga 233 + 0x12 byte C++

did someone experienced something similar? Am I missing something?
Thank you in advance.

Regards

ing. Federico Fuga

«_Superman_»6-Oct-09 12:14

6-Oct-09 12:14

You do not need to perform the check -

if (m_strClassName.IsEmpty())

AfxRegisterWndClass[^] will only register similar classes once.
Read the remarks section of the documentation.

Here is an excerpt from the documentation -
If you call AfxRegisterWndClass multiple times with identical parameters, it only registers a class on the first call. Subsequent calls to AfxRegisterWndClass with identical parameters simply return the already-registered classname.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

f.fuga6-Oct-09 20:23

6-Oct-09 20:23

«_Superman_» wrote:
You do not need to perform the check -
if (m_strClassName.IsEmpty())

Hi _Superman_, thank you for your response.
Yes, I know that check is useless, but it's not my code: as you can see, it's the source code of the CMFCPropertyGridCtrl class, in the Visual Studio 2008 MFC Feature Pack.
I should try to remove that check -- m_strClassName is a static member, so it's shared between DLL and EXE; maybe the registration of the control depends on the hInstance of the module calling the Create() function, so it's failing on the second call because it has been registered from another instance.
But this requires to recompile all the MFC / feature pack...?
Note that calling Create() from a third DLL do not solve the issue.

Thank you again

«_Superman_»7-Oct-09 7:07

7-Oct-09 7:07

No No No....
Please do not compile the MFC code.
I didn't realize it was in the MFC code base.

MFC code is properly tested.
The problem could be else where.

Are you able to debug and reach the problem?

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

f.fuga7-Oct-09 9:46

7-Oct-09 9:46

No problem, I wasn't thinking that recompiling the MFC would solve the issue Smile | :)

The good news is that I have built a setup package using inno setup, and when installing on a plain Windows XP HE box the latest x86redist package downloaded from microsoft, the application works correctly.
The bad news is that I do not know why. The "working" mfc package has version number 9.0.30729.1, the package installed on my development box (and crashing) has the 9.0.30729.4148. This one seems to be an updated version, dated july 2009 (the working one is dated 2008).

I frankly expected that the older one was on my development box...
So the question is: the most updated library do not work because something has been broken in the library itself, or did I made some mistake on my application?

Any comment?

Thank you again

Federico

«_Superman_»7-Oct-09 10:43

7-Oct-09 10:43

f.fuga wrote:
So the question is: the most updated library do not work because something has been broken in the library itself, or did I made some mistake on my application?

It is highly unlikely that the library is broken.
It should be some problem with your application.
You should try and debug it.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

f.fuga7-Oct-09 23:41

7-Oct-09 23:41

«_Superman_» wrote:
It is highly unlikely that the library is broken.
It should be some problem with your application.
You should try and debug it.

I agree with you.
I have checked the libraries version, both release and debug are ok.
I think that Release version of my program works as expected because, of course, ASSERT() has only means when compiling in debug mode.
From a practical approach, I should ignore the problem - the Release works. But I suspect that I will find again this problem in the future.
So I will keep search for a solution.
Do you know any issue when using some MFC classes from DLL and EXE ? I know the "AFX_MANAGE_STATE(AfxGetStaticModuleState());" call needed when accessing resources, I suspect a similar problem...

Thank you

Federico

CStdioFile::ReadString() Method.

Oza Priyanka4-Apr-18 6:35

Oza Priyanka

4-Apr-18 6:35

Hey,
I encountered the exactly same problem while working with CMFCPropertyGridCtrl in my DLL project.
After many trial, i found a way to use CMFCPropertyGridCtrl in DLL without this error.
All you have to do is Create a derived class of CMFCPropertyGridToolTipCtrl(),Make its protected static variable "m_strClassName" NULL in Constructor.
for example;
//////////////////////////////////////////////////////////////////////////////////
Class CMyToolTipCtrl::CMFCPropertyGridToolTipCtrl();

CMyToolTipCtrl::CMyToolTipCtrl()
{
m_strClassName = "";
}
///////////////////////////////////////////////////////////////////////////////////
Now create ToolTipctrl from your CMFCPropertyGridToolTipCtrl() derived class on Init of the CMFCPropertyGridCtrl derived Class.
for example,
///////////////////////////////////////////////////////////////////////////////////
Class MyPropertyGridCtrl::CMFCPropertyGridCtrl();

void MyPropertyGridCtrl::Init()
{
CMyToolTipCtrl p_tooltip;
p_tooltip.Create(this);
}
//////////////////////////////////////////////////////////////////////////////////////

There is always a way.
Priyanka Oza.

Chris Meech6-Oct-09 9:43

Chris Meech

6-Oct-09 9:43

I have some code that has just recently started to 'fail'. I suspect that as long the method StdioFile::ReadString(CString&) would remove both a carriage return and linefeed pair, the code would work fine. I've been through the documentation on MSDN and through the MFC code and it seems that even though the method will 'break' on a carriage return linefeed pair, it will only remove the linefeed character from the string before it is returned. Does anyone know if this is a change that's documented somewhere. Thanks.

Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]

Re: CStdioFile::ReadString() Method.

PJ Arends6-Oct-09 10:36

Re: CStdioFile::ReadString() Method.

6-Oct-09 10:36

I know that in UNICODE builds, this is a problem when reading UTF16 files. A fix is to open the file in binary mode, and strip the carriage return off the incoming string. I do not know where the docs say so though, but a quick search of "CStdioFile ReadString Unicode" will return lots of discussions on the issue.

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good - Use it!

Chris Meech7-Oct-09 2:09

Chris Meech

7-Oct-09 2:09

Thanks for the help, PJ. This is one of those problems that comes along at the end of the day when the brain's function at a little lower level than normal. This morning, I did some more research and found that the cr/lf pair translation only occurs if the file is opened in text mode. It turns out that a change in our class library, ironically to assist with handling UTF16 type files, changed the default opening mode from type text to type binary and that's causing the issue.

Appreciate the response. Smile | :)

Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]

CreateCompatibleBitmap() retuns 0 , and GetLastError returns 8 , what does error code 8 means?

rambojanggoon6-Oct-09 8:58

rambojanggoon

6-Oct-09 8:58

Hello.

CDC *pDC = GetDC();
CDC tmpDC;

BOOL bRet=tmpDC.CreateCompatibleDC( pDC ); //bRet is 1 => it means succes.

CBitmap m_bmp;
bRet= m_bmp.CreateCompatibleBitmap( pDC, rect.Width(), rect.Height() );
//bRet is 0 ==>it is an error.
DWORD err=GetLastError(); //err is 8. --> it is an error.

error code 8 means : "Not enough storage is available to process this command. "

here, my hdd is 50M remains, and I have enough space fo runing some program...
Why, CreateCompatibleDC() return error code 8?

my System is abnormal?

Thanks.

Re: CreateCompatibleBitmap() retuns 0 , and GetLastError returns 8 , what does error code 8 means?

CPallini6-Oct-09 9:49

CPallini

6-Oct-09 9:49

rambojanggoon wrote:
my System is abnormal?

Your CRect rect is possibly 'abnormal'. Check its dimensions. Smile | :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Re: CreateCompatibleBitmap() retuns 0 , and GetLastError returns 8 , what does error code 8 means?

«_Superman_»6-Oct-09 12:21

to change cricheditctrl's window border

6-Oct-09 12:21

"Not enough storage" here means memory.
rect not initialized?
I also think rect is the problem.

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

prithaa6-Oct-09 8:34

prithaa

6-Oct-09 8:34

Hello,

I have created a CRichEditCtrl without borders . After i create it i want to change its borders . How do i change its borders with WS_BORDER window style ?

Pritha

Re: to change cricheditctrl's window border

«_Superman_»6-Oct-09 10:53

Re: to change cricheditctrl's window border

6-Oct-09 10:53

Are you saying that you want to add borders?
You can use the ModifyStyle[^] method.

richEdit.ModifyStyle(0, WS_BORDER);

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

PJ Arends6-Oct-09 11:58

Re: to change cricheditctrl's window border

6-Oct-09 11:58

And then call RedrawWindow() with the RDW_INVALIDATE, RDW_FRAME, and RDW_UPDATENOW flags.

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good - Use it!

prithaa7-Oct-09 0:25

prithaa

7-Oct-09 0:25

thanks

Property sheet-based app has icon problems

rfparker6-Oct-09 8:03

rfparker

6-Oct-09 8:03

I am developing a property sheet-based application on XP using VC++ 6. When it starts it talks briefly to an instrument over a serial port in app::InitInstance(), creates the property sheet, adds a few pages, and does an appSheet.DoModal() to make it appear. In order to get an icon to appear in the taskbar and Alt-Tab, I use this code in appSheet::OnInitDialog():

// Set the icons for the app
AfxGetMainWnd()->SetIcon(AfxGetApp()->LoadIcon(IDR_MAINFRAME), TRUE);
AfxGetMainWnd()->SetIcon(AfxGetApp()->LoadIcon(IDR_MAINFRAME), FALSE);

The app works just fine, and until I added a slight twist mentioned next the icons appeared as expected.

For the several seconds during which the app is initially talking to the instrument the user sees nothing happening. So at the beginning of app::InitInstance() I create a modeless dialog that asks the user to be patient while the app starts up, and then hide the dialog at the end of the startup property page's OnInitDialog(). This works fine and looks great. Except that now SetIcon(), above, returns 0 and I get the generic white window icon for Alt-Tab and nothing in the taskbar. The icon in the title bar is still correct.

If I use the following code in place of the previous code, I can get the icon to display when I do an Alt-Tab, but nothing shows up in the taskbar.

HICON hIcon=AfxGetApp()->LoadIcon(IDR_MAINFRAME);
CWnd* pFrame=AfxGetMainWnd();
::SetClassLong(pFrame->GetSafeHwnd(), GCL_HICON, (long)hIcon);

Interestingly, until I do this the generic MFC icon shows up in the taskbar.

Any ideas why this is happening and how to get my icon and app name to appear in the taskbar?
Thanks

PJ Arends6-Oct-09 10:42

6-Oct-09 10:42

What are the values returned by the SetIcon() method? It could be that your modeless dialog has the icons locked while it is displayed?

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good - Use it!

rfparker6-Oct-09 11:03

rfparker

6-Oct-09 11:03

SetIcon() returns 0 (zero) rather than a handle to an icon.

I'm not sure what you mean about the application's icons being locked by the modeless dialog; how would I investigate this possibility? And if this is the case, can I make the dialog unlock them? The dialog lives as long as the app and is hidden or displayed, with different messages, as I change modes while communicating with the instrument.

PJ Arends6-Oct-09 11:23

6-Oct-09 11:23

rfparker wrote:
SetIcon() returns 0 (zero) rather than a handle to an icon.

So SetIcon is failing.

I would suggest that you take the communication and startup dialog code out of your InitInstance() function and put them in a separate function so that your app can be properly initialized before you do anything else. One way is to post a custom message to your main window at the end of InitInstance() and do the communication from the message handler.

You may be right
I may be crazy
-- Billy Joel --

Within you lies the power for good - Use it!

rfparker7-Oct-09 11:11

rfparker

7-Oct-09 11:11

Yes, that might be a better way to do it (though AppWizard puts the call to DoModal() in a dialog-based app's InitInstance()) and I've made that change. It makes no difference to the functionality that I see.

Since I can get the correct title bar and Alt-Tab icons to appear by setting them in the property sheet's OnInitDialog(), the real issue is the button on the taskbar. I guess the modeless dialog is considered the main window for the task (it has to be created first), since when it is displayed the button appears and as soon as it is hidden (SW_HIDE) the button disappears. So I can't hide the modeless dialog without also disappearing the taskbar button. So for now I'm not hiding the modeless dialog, which is undesirable.

There is also the issue of the initial icon on the taskbar button. I've added SetWindowText() to the modeless dialog's OnInitDialog() to set the proper caption, since there's no title bar, and added WS_SYSMENU to the .rc to force the icon to appear, but, until the property sheet loads the icon I want, I see the MFC cube icon in the taskbar button. After the property sheet loads the icon, that one is always displayed on the taskbar, even when I've temporarily destroyed the property sheet and the modeless dialog has reappeared.

What I'd like is to be able to hide the modeless dialog when I display the property sheet and not have the taskbar button disappear, and to set the taskbar button's icon so the MFC cube doesn't appear.