|
Well, this those changes, it now comes out red and black instead of grey and black.
I'm Sure I'm doing it wrong too. 
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
If the colors are changing, then what you're doing wrong is your pixel lookup, the colors are bleeding between red, green and blue. Did you read my article which has a guassian blur filter in it ?
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
Yes, I did.
However, I don't see how my pixel lookup is wrong. :S
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Ok, for starters I believe you're scanning the input image correctly now, x and y cover the correct pixels. However, you want to grab 3 pixels from the previous row right above the target pixel, three from the current row including the two on either side of the target, and the from the next row. So xp and yp have to take the values, [-1, 0, 1]. You start with 0 and your test of xp < 4 actually makes xp go from 0, 1, 2, 3. So you're getting the wrong pixel correlated.
Also, after you call avg(), you should only be setting 1 pixel in the output image, the one at x, y. So the second set of for loops need to vanish.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Thanks for the advice  . But now, the output is just red and black lines 
Here's the updated code:
unsigned int yp=0, xp=0;
for(int y = 1; y < bmp.biHeight-1; y++){
for(int x = 1; x < bmp.biWidth-1; x++){
for(int i = 0; i < 9; i++){
{
get_pixel(x+xp,y+yp,blank[i],image);
if(xp<2)
xp++;
else{
xp = -1;
yp++;}
}
}
avg(blank, Merge, 9, Matrix);
set_pixel(x,y,Merge,image2);
clear_pixel(Merge);
yp=-1, xp=-1;
}}
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Well, this is sure messy.
Apart from anything else, all these function calls are going to slow your code down. avg works on a reference, it doesn't return a value ?
yp and xp are zero at the start of the first loop, every other time they start at -1. I'm sure that's not the only issue, but it's an indication of the sort of problems you probably have.
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
Christian is right about the initialization of xp and yp. And the xp<2 test is wrong. It's short, count it out in your fingers. 
He's right about it being very messy and inefficient. But right now it's more important for you to understand the algorithm.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Oh, one other question. You apparently assume that the pixels are RGB triples. You never check the bitmap info to make sure it matches. Were you told this is the structure of the image?
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Yeah, I spotted that, too. But, I assume it is, if it were 32 bit, he'd be complaining about pixels not processed, I reckon.
Christian Graus
Please read this if you don't understand the answer I've given you
"also I don't think "TranslateOneToTwoBillion OneHundredAndFortySevenMillion FourHundredAndEightyThreeThousand SixHundredAndFortySeven()" is a very good choice for a function name" - SpacixOne ( offering help to someone who really needed it ) ( spaces added for the benefit of people running at < 1280x1024 )
|
|
|
|
|
I spotted the initialisation of xp and yp straight after posting. But it had no effect. 
I wasn't aware you could check if it was an RGBTRIPLE. Ignorance, I guess. How would I go about this? However, the other program I am using to create the random noise input image seems to work fine with the same values in the header BITMAPINFOHEADER and BITMAPFILEHEADERs.
Oh, and, rather ironically, I used so many function calls to try and clean the for loops up. 
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Have you tried stepping through your code in the debugger to see if things actually work like you're expecting them to? I would have been doing that about 14 messages ago.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Hmm....
xp is set to 4294967295 and does not change with each loop... y, however, does as is wanted.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Okay, fixed that. Still get the same output, though.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Hmm.... I tried recreating the file using the other program(which uses the same values in bmp and bfh) using the CREATE_NEW definition in the CreateFile() function. When I do this, the resulting image cannot be drawn by windows picture and fax viewer. This may be the problem...
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
Sounds like a clue to me.  I'm not really up on that kind of file I/O. I rarely store things these days.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
You've gone quiet. Did you ever get it to work? Inquiring minds want to know.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
Unfortunately I haven't got it to work yet.
I shall keep at it, however.
"Sir, I protest. I am NOT a merry man!"
|
|
|
|
|
I am using Datagrid in my application. And at the same time i want to highlight particular row in datagrid.
Using graphics class i tried to draw a rectangle on the row but drawn rectangle is invisible.
In formload, datagrid is there. And in application depending upon the event rectangle should be drawn on the datagrid on particular row.
Please assist me in this.
|
|
|
|
|
Didn't you just ask this same question about 2 messages below using the name gayatrit, delete it, set up a new ID, and ask it again?
If you don't have the data, you're just another a**hole with an opinion.
modified on Saturday, June 7, 2008 3:10 AM
|
|
|
|
|
foreach (DataGridViewRow row in dataGridView.Rows)
{
row.DefaultCellStyle.BackColor = Color.Tomato;
}
You can add if statements within the foreach to change row colors according to conditions like so
foreach (DataGridViewRow row in dataGridView.Rows)
{
if (row.Cells[13].Value.ToString() == "someValue")
{
row.DefaultCellStyle.BackColor = Color.Tomato;
}
else if(row.Cells[13].Value.ToString() == "someOtherValue")
{
row.DefaultCellStyle.BackColor = Color.Blue;
}
}
hope it helps
Harvey Saayman - South Africa
Junior Developer
.Net, C#, SQL
you.suck = (you.passion != Programming)
|
|
|
|
|
Thank u Mr.Harvey
it worked 
|
|
|
|
|
glad to have helped
Harvey Saayman - South Africa
Junior Developer
.Net, C#, SQL
you.suck = (you.passion != Programming)
|
|
|
|
|
|
You're not giving us a lot to work with in how you're doing it but sounds like it might be an order of operations issue. You draw your rectangle first and then the datagrid draws over it. That's why when you set it to invisible, it doesn't tromp all over your rectangle.
If you don't have the data, you're just another a**hole with an opinion.
|
|
|
|
|
I want to impliment radial layout tree. is it fesible on C# form?
and how?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
