C / C++ / MFC

Maximilien wrote:

if you do not do that, you will have to copy the same "cleanup" code
all over the place.

    hr = SHGetMalloc(&pMalloc);
    if(SUCCEEDED(hr))
    {
        hr = SHGetDesktopFolder(&psfShell);
        if(SUCCEEDED(hr))
        {
            hr = SHGetFolderLocation(NULL, CSIDL_WINDOWS, NULL, NULL, &pidlWindowsFolder);
            if(SUCCEEDED(hr))
            {
                hr = psfShell->BindToObject(pidlWindowsFolder, NULL, IID_IShellFolder2, (VOID **)&psfWindowsFolder);
                if(SUCCEEDED(hr))
                {
                    hr = psfWindowsFolder->ParseDisplayName(NULL, NULL, _T("clock.avi"), NULL, &pidlFile, NULL);
                    if(SUCCEEDED(hr))
                    {
                        hr = psfWindowsFolder->GetDetailsOf(pidlFile, 2, &shDetails);
                        if(SUCCEEDED(hr))
                        {
                            hr = StrRetToBuf(&shDetails.str, pidlFile, szDisplayName, sizeof(szDisplayName));
                            if(SUCCEEDED(hr))
                                _tprintf(_T("Details at Column 2 : %s \n"), szDisplayName);
                        }
                    }
                    pMalloc->Free(pidlFile);
                }
                psfWindowsFolder->Release ();
            }
            pMalloc->Free(pidlWindowsFolder);
        }
        psfShell->Release ();
    }
    pMalloc->Release ();
}

Maximilien wrote:

It's ugly.

JudyL_FL wrote:

No you don't. Just nest the if's and cleanup as you unnest, like so:

Randor wrote:

do you actually use the goto statement that much in production code?

Rajkumar R wrote:

BTW, what's your opinion?

for(int x =0; x < iLimit;++x)
{
	for(int y =0; y < iAnotherLimit;++y)
	{
		for(int i =0;i< ilastlimit;++i))
		{
			if(FALSE == DoWork(SomeArray[x][y][i]))
			{
				goto critical_error;
			}
		}
	}
}
critical_error:
CleanUp();

Randor wrote:

My reasoning is quite simple in that the compiler cannot perform optimizations with all of those unconditional jumps all over the place.

lahom wrote:

//***************************************************************//
knowing that those functions are declared int header file like that:

// Registry API To Query A String Value.
int RegQueryValueExString /* RegQueryValueExA */ (HKEY hKey, CString lpValueName, int lpReserved, int& lpType, CString lpData, int& lpcbData); // "advapi32.dll"

lahom wrote:

but when runing 3errors

DavidCrow wrote:

What errors?

lahom wrote:

i have an error link saying that :

DavidCrow wrote:

You've shown linker errors, but what are these runtime errors you refer to?

lahom wrote:

when i compile ......0 errors
but when runing 3errors