C / C++ / MFC

Larry Mills Sr wrote:

I have to send "str" to the FileSave" function with the data already in it! I can't convert it like above (hard-coded) because I don't know what cchoices the User used to build the above string(str).

reteset wrote:

hi to all
i am a new bie

reteset wrote:

i am a new bie

#include <shlobj.h>
#include <shlwapi.h>
#include <stdio.h>
#include <tchar.h>

#pragma comment (lib, "shlwapi.lib")

#define SAFE_RELEASE(_x) if (_x){_x->Release(); _x = NULL;}

int main()
{
	LPMALLOC        pMalloc			= NULL;
	IShellFolder	*psfShell		= NULL;
	IShellFolder2	*psfWindowsFolder	= NULL;
	LPITEMIDLIST	pidlWindowsFolder	= NULL;
	LPITEMIDLIST	pidlFile		= NULL;
	TCHAR		szDisplayName[MAX_PATH];
	SHELLDETAILS	shDetails;

	HRESULT hr = E_FAIL;

	hr = SHGetMalloc(&pMalloc);
	if(FAILED(hr))
		goto END;

	hr = SHGetDesktopFolder(&psfShell);
	if(FAILED(hr))
		goto END;

	hr = SHGetFolderLocation(NULL, CSIDL_WINDOWS, NULL, NULL, 
		&pidlWindowsFolder);
	if(FAILED(hr))
		goto END;

	hr = psfShell->BindToObject(pidlWindowsFolder, NULL, 
		IID_IShellFolder2, (VOID **)&psfWindowsFolder);
	if(FAILED(hr))
		goto END;

	hr = psfWindowsFolder->ParseDisplayName(NULL,
		NULL,
		_T("clock.avi"),
		NULL,  // This can be NULL
		&pidlFile,
		NULL);
	if(FAILED(hr))
		goto END;

	hr = psfWindowsFolder->GetDetailsOf(pidlFile, 2, &shDetails);
	if(FAILED(hr))
		goto END;
	
	hr = StrRetToBuf(&shDetails.str, pidlFile, szDisplayName, sizeof(szDisplayName));
	if(FAILED(hr))
		goto END;

	_tprintf(_T("Details at Column 2 : %s \n"), szDisplayName);

END:
	
	if (pMalloc)
	{
		if (pidlFile) pMalloc->Free(pidlFile);
		if (pidlWindowsFolder) pMalloc->Free(pidlWindowsFolder);
	}
	SAFE_RELEASE(psfWindowsFolder);
	SAFE_RELEASE(psfShell);
	SAFE_RELEASE(pMalloc);

	return 0;
}

Maximilien wrote:

if you do not do that, you will have to copy the same "cleanup" code
all over the place.

    hr = SHGetMalloc(&pMalloc);
    if(SUCCEEDED(hr))
    {
        hr = SHGetDesktopFolder(&psfShell);
        if(SUCCEEDED(hr))
        {
            hr = SHGetFolderLocation(NULL, CSIDL_WINDOWS, NULL, NULL, &pidlWindowsFolder);
            if(SUCCEEDED(hr))
            {
                hr = psfShell->BindToObject(pidlWindowsFolder, NULL, IID_IShellFolder2, (VOID **)&psfWindowsFolder);
                if(SUCCEEDED(hr))
                {
                    hr = psfWindowsFolder->ParseDisplayName(NULL, NULL, _T("clock.avi"), NULL, &pidlFile, NULL);
                    if(SUCCEEDED(hr))
                    {
                        hr = psfWindowsFolder->GetDetailsOf(pidlFile, 2, &shDetails);
                        if(SUCCEEDED(hr))
                        {
                            hr = StrRetToBuf(&shDetails.str, pidlFile, szDisplayName, sizeof(szDisplayName));
                            if(SUCCEEDED(hr))
                                _tprintf(_T("Details at Column 2 : %s \n"), szDisplayName);
                        }
                    }
                    pMalloc->Free(pidlFile);
                }
                psfWindowsFolder->Release ();
            }
            pMalloc->Free(pidlWindowsFolder);
        }
        psfShell->Release ();
    }
    pMalloc->Release ();
}

Maximilien wrote:

It's ugly.

JudyL_FL wrote:

No you don't. Just nest the if's and cleanup as you unnest, like so:

Randor wrote:

do you actually use the goto statement that much in production code?

Rajkumar R wrote:

BTW, what's your opinion?

for(int x =0; x < iLimit;++x)
{
	for(int y =0; y < iAnotherLimit;++y)
	{
		for(int i =0;i< ilastlimit;++i))
		{
			if(FALSE == DoWork(SomeArray[x][y][i]))
			{
				goto critical_error;
			}
		}
	}
}
critical_error:
CleanUp();

Randor wrote:

My reasoning is quite simple in that the compiler cannot perform optimizations with all of those unconditional jumps all over the place.