Bugs and Suggestions

21-Jan-15 3:28

Hello CP

It would be great to be able to upload and link to SVG files for decent vector imaging. I recently tried adding some SVG UML diagrams to an article but had to drop back to making (highly unsatisfactory) JPEGs first.

TIA!

Jerry

P.S A slightly more general question was asked some time back but the SVG aspect remains unanswered ('09 actually).

Kornfeld Eliyahu Peter21-Jan-15 3:39

Kornfeld Eliyahu Peter

21-Jan-15 3:39

Did you tried to include your SVG inside the HTML of your article? It works perfectly as I can see...

Skipper: We'll fix it.
Alex: Fix it? How you gonna fix this?
Skipper: Grit, spit and a whole lotta duct tape.

Jerry Evans21-Jan-15 4:21

21-Jan-15 4:21

Hah! No I did not. Excellent suggestion, thanks.

Chris Maunder21-Jan-15 4:09

21-Jan-15 4:09

SVG is a leaky boat so unfortunately we can't allow SVG uploads. Take a look at this[^]

cheers
Chris Maunder

Jerry Evans21-Jan-15 4:25

21-Jan-15 4:25

Yes, it does have that potential. No chance of applying a sanitizer perhaps? https://github.com/alister-/SVG-Sanitizer for example?

Thanks for listening Smile | :)

Chris Maunder21-Jan-15 4:32

21-Jan-15 4:32

Spend the 30 mins converting that to C# for me and yep, I'll do it.

cheers
Chris Maunder

Jerry Evans21-Jan-15 4:39

21-Jan-15 4:39

It's a deal. I'll ping you here when it's ready Smile | :)

Forogar 21-Jan-15 5:56

Forogar

21-Jan-15 5:56

I'll help, if you need any. SVG is fun and now supported in all major browsers! Yeah!

- I would love to change the world, but they won’t give me the source code.

Jerry Evans21-Jan-15 5:56

21-Jan-15 5:56

Yo. Here it is.

/*

	A really simple SVG cleaner for the CodeProject
 
    This is a *big* thanks to Chris Maunder and the team for their great work 

        Based on an original PHP implementation here:

        https://github.com/alister-/SVG-Sanitizer

	Copyright (c) Jerry Evans, 2015
	All rights reserved.

	The MIT License (MIT)

	Copyright (c) 2015 Jerry Evans

	Permission is hereby granted, free of charge, to any person obtaining a copy
	of this software and associated documentation files (the "Software"), to deal
	in the Software without restriction, including without limitation the rights
	to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
	copies of the Software, and to permit persons to whom the Software is
	furnished to do so, subject to the following conditions:

	The above copyright notice and this permission notice shall be included in
	all copies or substantial portions of the Software.

	THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
	AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
	OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
	THE SOFTWARE.

*/

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Xml;

namespace svgcheck
{
    class SVGChecker
    {
        /// <summary>
        /// dictionary of string to hashset maps valid SVG tags to valid attributes. All else is discarded (!)
        /// </summary>
        static Dictionary<String, HashSet<String>> dict = new Dictionary<String, HashSet<String>>()
        {
       		{ "a", new HashSet<String>{"class", "clip-path", "clip-rule", "fill", "fill-opacity", "fill-rule", "filter", "id", "mask", "opacity", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform", "href", "xlink:href", "xlink:title"} },
		    { "circle", new HashSet<String>{"class", "clip-path", "clip-rule", "cx", "cy", "fill", "fill-opacity", "fill-rule", "filter", "id", "mask", "opacity", "r", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform"} },
		    { "clipPath", new HashSet<String>{"class", "clipPathUnits", "id"} },
		    { "defs", new HashSet<String>{} },
	        { "style" , new HashSet<String>{"type"} },
		    { "desc", new HashSet<String>{} },
		    { "ellipse", new HashSet<String>{"class", "clip-path", "clip-rule", "cx", "cy", "fill", "fill-opacity", "fill-rule", "filter", "id", "mask", "opacity", "requiredFeatures", "rx", "ry", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform"} },
		    { "feGaussianBlur", new HashSet<String>{"class", "color-interpolation-filters", "id", "requiredFeatures", "stdDeviation"} },
		    { "filter", new HashSet<String>{"class", "color-interpolation-filters", "filterRes", "filterUnits", "height", "id", "primitiveUnits", "requiredFeatures", "width", "x", "xlink:href", "y"} },
		    { "foreignObject", new HashSet<String>{"class", "font-size", "height", "id", "opacity", "requiredFeatures", "style", "transform", "width", "x", "y"} },
		    { "g", new HashSet<String>{"class", "clip-path", "clip-rule", "id", "display", "fill", "fill-opacity", "fill-rule", "filter", "mask", "opacity", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform", "font-family", "font-size", "font-style", "font-weight", "text-anchor"} },
		    { "image", new HashSet<String>{"class", "clip-path", "clip-rule", "filter", "height", "id", "mask", "opacity", "requiredFeatures", "style", "systemLanguage", "transform", "width", "x", "xlink:href", "xlink:title", "y"} },
		    { "line", new HashSet<String>{"class", "clip-path", "clip-rule", "fill", "fill-opacity", "fill-rule", "filter", "id", "marker-end", "marker-mid", "marker-start", "mask", "opacity", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform", "x1", "x2", "y1", "y2"} },
		    { "linearGradient", new HashSet<String>{"class", "id", "gradientTransform", "gradientUnits", "requiredFeatures", "spreadMethod", "systemLanguage", "x1", "x2", "xlink:href", "y1", "y2"} },
		    { "marker", new HashSet<String>{"id", "class", "markerHeight", "markerUnits", "markerWidth", "orient", "preserveAspectRatio", "refX", "refY", "systemLanguage", "viewBox"} },
		    { "mask", new HashSet<String>{"class", "height", "id", "maskContentUnits", "maskUnits", "width", "x", "y"} },
		    { "metadata", new HashSet<String>{"class", "id"} },
		    { "path", new HashSet<String>{"class", "clip-path", "clip-rule", "d", "fill", "fill-opacity", "fill-rule", "filter", "id", "marker-end", "marker-mid", "marker-start", "mask", "opacity", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform"} },
		    { "pattern", new HashSet<String>{"class", "height", "id", "patternContentUnits", "patternTransform", "patternUnits", "requiredFeatures", "style", "systemLanguage", "viewBox", "width", "x", "xlink:href", "y"} },
		    { "polygon", new HashSet<String>{"class", "clip-path", "clip-rule", "id", "fill", "fill-opacity", "fill-rule", "filter", "id", "class", "marker-end", "marker-mid", "marker-start", "mask", "opacity", "points", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform"} },
		    { "polyline", new HashSet<String>{"class", "clip-path", "clip-rule", "id", "fill", "fill-opacity", "fill-rule", "filter", "marker-end", "marker-mid", "marker-start", "mask", "opacity", "points", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform"} },
		    { "radialGradient", new HashSet<String>{"class", "cx", "cy", "fx", "fy", "gradientTransform", "gradientUnits", "id", "r", "requiredFeatures", "spreadMethod", "systemLanguage", "xlink:href"} },
		    { "rect", new HashSet<String>{"class", "clip-path", "clip-rule", "fill", "fill-opacity", "fill-rule", "filter", "height", "id", "mask", "opacity", "requiredFeatures", "rx", "ry", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform", "width", "x", "y"} },
		    { "stop", new HashSet<String>{"class", "id", "offset", "requiredFeatures", "stop-color", "stop-opacity", "style", "systemLanguage"} },
		    { "svg", new HashSet<String>{"class", "clip-path", "clip-rule", "filter", "id", "height", "mask", "preserveAspectRatio", "requiredFeatures", "style", "systemLanguage", "viewBox", "width", "x", "xmlns", "xmlns:se", "xmlns:xlink", "y"} },
		    { "switch", new HashSet<String>{"class", "id", "requiredFeatures", "systemLanguage"} },
		    { "symbol", new HashSet<String>{"class", "fill", "fill-opacity", "fill-rule", "filter", "font-family", "font-size", "font-style", "font-weight", "id", "opacity", "preserveAspectRatio", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "transform", "viewBox"} },
		    { "text", new HashSet<String>{"class", "clip-path", "clip-rule", "fill", "fill-opacity", "fill-rule", "filter", "font-family", "font-size", "font-style", "font-weight", "id", "mask", "opacity", "requiredFeatures", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "text-anchor", "transform", "x", "xml:space", "y"} },
		    { "textPath", new HashSet<String>{"class", "id", "method", "requiredFeatures", "spacing", "startOffset", "style", "systemLanguage", "transform", "xlink:href"} },
		    { "title", new HashSet<String>{} },
		    { "tspan", new HashSet<String>{"class", "clip-path", "clip-rule", "dx", "dy", "fill", "fill-opacity", "fill-rule", "filter", "font-family", "font-size", "font-style", "font-weight", "id", "mask", "opacity", "requiredFeatures", "rotate", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "systemLanguage", "text-anchor", "textLength", "transform", "x", "xml:space", "y"} },
		    { "use", new HashSet<String>{"class", "clip-path", "clip-rule", "fill", "fill-opacity", "fill-rule", "filter", "height", "id", "mask", "stroke", "stroke-dasharray", "stroke-dashoffset", "stroke-linecap", "stroke-linejoin", "stroke-miterlimit", "stroke-opacity", "stroke-width", "style", "transform", "width", "x", "xlink:href", "y"} },
        };
        
        /// fully qualified path to SVG file
        /// writes with a .cleaned.svg filetype
        public static bool Check(string url)
        {
            bool ret = false;
            try
            {
                XmlDocument doc = new XmlDocument();
                doc.Load(url);
                //
                Console.WriteLine(String.Format("Checking {0}", url));
                // get the node list
                XmlNodeList nodes = doc.GetElementsByTagName("*");
                // iterate backwards so we can pull anything suspect
                for (int node_index = nodes.Count - 1; node_index >= 0; node_index--)
                {
                    // get the node
                    XmlNode node = nodes[node_index];
                    // check tag is in our whitelist dictionary
                    String tag = node.Name;
                    // we'll want the hashed set of legitimate SVG attributes 
                    // for the next round ...
                    HashSet<String> hset = null;
                    // if found we are good else delete the node from the DOM
                    if (dict.TryGetValue(tag,out hset))
                    {
                        // order of iteration less important over attributes ...
                        for (int attrib_index = node.Attributes.Count -1; attrib_index >= 0; attrib_index--)
                        {
                            XmlAttribute attribute = node.Attributes[attrib_index];
                            if (hset.Contains(attribute.Name) == false)
                            {
                                node.Attributes.RemoveAt(attrib_index);
                                Console.WriteLine(String.Format("\tDeleting attribute {0}", attribute.Name));
                            }
                        }
                    }
                    else
                    {
                        nodes[node_index].ParentNode.RemoveChild(node);
                        Console.WriteLine(String.Format("Deleting node {0}", tag));
                    }
                }
                //. JME audit:improve
                String newurl = url.Replace(".svg", ".cleaned.svg");
                doc.Save(newurl);
                ret = true;
            }
            catch (System.Exception ex)
            {
                ///
                Console.WriteLine(ex.Message);
            }

            return ret;
        }
    }
}

Forogar 21-Jan-15 5:57

Forogar

21-Jan-15 5:57

Excellent work! Big Grin | :-D

- I would love to change the world, but they won’t give me the source code.

Chris Maunder21-Jan-15 10:23

21-Jan-15 10:23

SVG support has been added.

cheers
Chris Maunder

Pete O'Hanlon21-Jan-15 10:27

Pete O'Hanlon

21-Jan-15 10:27

Now that IS agile.

Please add bitcoin tipping

SoMad21-Jan-15 14:20

SoMad

21-Jan-15 14:20

That is awesome!

Since I know it is possible to do inline SVGs (at least in QA answers), you should probably make sure your new sanitizer handles that as well.

Last year I answered a question in QA where I fiddled with inline SVG. I got it to display the image, but once I tried modifying my answer, the HTML control would HTML encode the embedded image tag so it wouldn't display. I figured it was some sort of precautionary measure you guys had implemented.
Raster to Vector Image without autotrace - Solution 3[^]

Here is another answer where I added an inline SVG:
SVG 2 PDF conversion in python using the svglib package does not work on my svg file - Solution 1[^]

Soren Madsen

"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty

Tomice21-Jan-15 1:46

Tomice

21-Jan-15 1:46

Someone just answered my question and i would like to send him a tip.

Richard MacCutchan21-Jan-15 3:08

Richard MacCutchan

21-Jan-15 3:08

That is strictly not playing the game. The whole point of CodeProject is that everything is free. If you start introducing money into the mix then (unscrupulous) people will start demanding it.

Chris Maunder21-Jan-15 3:58

21-Jan-15 3:58

We all appreciate the thought, but I'm afraid we will not be implementing tipping.

cheers
Chris Maunder

Nish Nishant21-Jan-15 7:49

Nish Nishant

21-Jan-15 7:49

Chris Maunder wrote:
t I'm afraid we will not be implementing tipping.

You never tip on the tax, alcohol, or forum responses. Always been that way.

Regards,
Nish

Blog: voidnish.wordpress.com

OriginalGriff21-Jan-15 8:50

OriginalGriff

21-Jan-15 8:50

How about a facility to exchange rep points for the cash equivalent? Laugh | :laugh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

H.Brydon21-Jan-15 11:02

H.Brydon

21-Jan-15 11:02

Yeah but I think your rep points are worth more than mine. I'd go bankrupt pretty quickly - If you helped me with one more thing, I know I'd wake up the next morning and find myself a n00b.

I'm retired. There's a nap for that...
- Harvey

TheGreatAndPowerfulOz23-Jan-15 5:49

TheGreatAndPowerfulOz

23-Jan-15 5:49

How about cow tipping? Poke tongue | ;-P

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering.-Wernher von Braun
Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

Tom Deketelaere21-Jan-15 4:04

Tom Deketelaere

21-Jan-15 4:04

I doubt this will happen, nor is it needed.

There are 2 kind of people answering questions on CP:
- the kind that does if for the satisfaction of knowing they helped another programmer. (I like to believe that his is the largest category)
- the kind that does it for the reputation points

(there is a small percentage that falls in both categories but lets disregard them Smile | :)

)

If the person who answered your question falls in the first category then all you have to do is add a comment saying 'thank you, this solved my problem' (as added bonus you can accept his answer)
If the person who answered falls in the second category then all you have to do is accept his answer as the solution (as added bonus you can add a comment saying 'thank you, this solve my problem')

So in short all you have to do is: accept as solution and add a comment, and you'll be save. Smile | :)

Tom

Rage21-Jan-15 5:22

Rage

21-Jan-15 5:22

Hi Tomice,

I am the one responsible for handling all tipping issues and transactions.
Please PM me, state how much and whom should be tipped, and I will see to it that he gets the money.

What ? Wasn't it worth a try ??

~RaGE();

I think words like 'destiny' are a way of trying to find order where none exists. - Christian Graus
Entropy isn't what it used to.

Chris Maunder21-Jan-15 6:19