Why is my output showing multiple instances of the same filename with different icons

Question

1.00/5 (2 votes)

See more:

C#

string[] fileEntries = Directory.GetFiles(tbDirectory.Text);

                foreach (string filename in fileEntries)
                {
                    Icon ico = Icon.ExtractAssociatedIcon(filename.ToString());
                    smallImageList.Images.Add(ico);
                    //long fileSize = new System.IO.FileInfo(filename).Length;

                    for (int i = 0; i < fileEntries.Length; i++)
                    {
                        //lvi.SubItems.Add(GetSizeReadable(fileSize));
                        lvSums.Items.Add(filename.ToString().ToLower(), i);
                    }
                }
                foreach (ColumnHeader columns in lvSums.Columns)
                    columns.Width = -2;

I am trying to add to the listview the respected icon with its filename, no going as planned.

Posted 22-May-15 11:05am

Herboren

Add a Solution

Comments

Mathi Mani 22-May-15 17:38pm

Because you are having a FOR loop inside FOREACH.

Sergey Alexandrovich Kryukov 22-May-15 17:44pm

Right. Would you elaborate it a bit, and post a formal answer, just to get rid of this trash? :-)
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Herboren · Accepted Answer · 2015-05-22T11:50:00

I found it:
Took out the for loop and just added type int indexx and incremented for each file added. Works perfect.

C#

try
           {
               string[] fileEntries = Directory.GetFiles(tbDirectory.Text);

               foreach (string filename in fileEntries)
               {
                   Icon ico = Icon.ExtractAssociatedIcon(filename.ToString());
                   smallImageList.Images.Add(ico);
                   //long fileSize = new System.IO.FileInfo(filename).Length;

                   //for (int i = 0; i < fileEntries.Length; i++)
                   //{
                       //lvi.SubItems.Add(GetSizeReadable(fileSize));
                       lvSums.Items.Add(filename.ToString().ToLower(), index);
                       index++;
                   //}
               }
               foreach (ColumnHeader columns in lvSums.Columns)
                   columns.Width = -2;
           }
           catch { Exception ex;}