append byte array to an other array which contains '\0' ?

Question

1.00/5 (1 vote)

See more:

I have this function which append an array of byte to an other array of bytes
but the problem appears when the source contains '\0'
this what I have :

C#

private void Aes_Strcat(sbyte[] a_pchResult, sbyte[] pchResult, int m_iBlockSize)
        {
            int x = 0;
            while (a_pchResult[x] != 0)
            {
                x++;
            }

            Buffer.BlockCopy(pchResult, 0, a_pchResult, x, m_iBlockSize);
        }

here when the a_pchResult contains for example { -10, 15,3,45,17,25,0,56,41,12,0,0,0,0,0,0}
and I want to add pchResult to it at the end (it means after the '12' element)
but as you say it will add it after '25' because it find the '0' before the end.

any idea how know the last position to add the new array at the end of source array if it contains '\0' element.

Posted 28-Apr-15 6:11am

MrKBA

Updated 28-Apr-15 23:32pm

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-04-28T06:26:00

Byte data isn't normally terminated by a '\0' character - that's a perfectly normal, and acceptable binary value in the range 0 to 255 inclusive! '\0' is not used as a terminator in .NET data at all - it comes from the C and C++ world.
Normally, you would pass the "used" length of the output array - if you don't you will overwrite the wrong data.

Sascha Lefèvre · Accepted Answer · 2015-04-28T06:27:00

I'd suggest you make a class containing the array, an offset-counter and methods for merging it with another array or instance of the same class.

Please ask if something shouldn't be clear - I have the impression you would know what I mean, just hanging on to some C mindset still :)

edit: The result would then be something similar to MemoryStream[^]

Sergey Alexandrovich Kryukov · Accepted Answer · 2015-04-28T12:35:00

This would be nothing but abuse, big abuse. The "termination" approach on strings and arrays was really nasty in first place. In decent systems and languages, more modern and refined ones, people when away from this apparent lame completely. Arrays and list are self-contained objects which carry all one would need to work with then, first of all, their length. If you work with an array, you initialize it with some length, which is kept remembered in the array object itself:

C#

int length = //...
sbyte[] array = new sbyte[length];

//...

for (int index = 0; index < array.Length; ++index) {
    // array.Length == length
}

Similar thing goes for arrays of higher rank, arrays with not zero-base indices (see Array.GetLowerBound, Array.GetUpperBound), and so on:
https://msdn.microsoft.com/en-us/library/system.array%28v=vs.110%29.aspx[^],
https://msdn.microsoft.com/en-us/library/system.array.getlowerbound(v=vs.110).aspx[^],
https://msdn.microsoft.com/en-us/library/system.array.getupperbound(v=vs.110).aspx[^].

—SA

append byte array to an other array which contains '\0' ?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0