Custom tree object. Search(C#)

Question

0.00/5 (No votes)

See more:

I have developed the class to implement object tree. Here is the simplest example:

public class TreeBO
        {
            public int ID { get; set; }
            public string Name { get; set; }
            public List<treebo> Nodes { get; set; }

            public TreeBO()
            {
                Nodes=new List<treebo>();
            }

            
        }
</treebo></treebo>

Then I desided to write the method for searching tree node by id:

public TreeBO Find(int id)
            {
                TreeBO treeBo = null;
                Find(this, id, ref treeBo);
                return treeBo;
            }

private void Find(TreeBO treeBo, int id, ref TreeBO temp)
            {
                if(treeBo!=null&&temp==null)
                {
                    if (treeBo.ID == id)
                        temp=treeBo;
                    else
                    {
                        if(treeBo.Nodes.Count>0)
                        {
                            foreach (var child in treeBo.Nodes)
                            {
                                Find(child, id, ref temp);
                            }
                        }
                    }
                }
            }

I doubt this way is the most effective. May be anybody knows another solution?

Posted 26-Jun-10 12:06pm

Pavel Yermalovich

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jimmanuel · Accepted Answer · 2010-06-26T16:08:00

That's not too bad. The one performance related change I would make is to change this:

C#

foreach (var child in treeBo.Nodes)
{
    Find(child, id, ref temp);
}

to this:

C#

foreach (var child in treeBo.Nodes)
{
    Find(child, id, ref temp);
    if (temp != null) break;
}

If you've already found the match then there's no need to continue the loop, is there?

A style change I would make would be to change Find to return a node instead of taking a ref param as the return value, but that's just a personal preference thing.