How to split a string inside a List and save the output again to another List

Question

2.00/5 (1 vote)

See more:

I have a .txt file which looks like this:

VB

09:00-16:00
19:00-23:00
10:00-17:00
20:00-24:00
07:00-14:00

I simply want to load each line in a List<string>, split each line in "-", and save it in another List<string>.

my code:

string line;
            while ( (line=reader.ReadLine()) != null)
            {
                // this is a first list
                schedule_initially.Add(line);
            }
           
            
            // Thsi is the second list
            List<string> final_schedule = new List<string>();
            ArrayList sch= new ArrayList();
            foreach (string s in schedule_initially)
            {
                if(s !=null)
                sch.Add(s.Split('-'));
            }

            foreach (string v in sch)
            {
                final_schedule.Add(v);
            }
             
            // Show the result to a label
            foreach (string s in final_schedule)
            {
                label1.Text += "\n" + s;
            }

But compiler shows error.
Any ideas ?

Posted 26-Jan-15 3:12am

BibhutiAlmighty

Add a Solution

Comments

Tomas Takac 26-Jan-15 9:16am

What error? Compiler or runtime? Change sch from ArrayList to List<string[]> then you will see what's the problem.

Zoltán Zörgő 26-Jan-15 9:22am

Quite vague. If you have 5 elements, by spitting them you will have 10. Supposing you have the rows you have posted in the file, what do you want to have at the end?

2 solutions

Solution 2

s.Split('-')

returns a System.String[] type, as such,

sch.Add(s.Split('-'))

adds the String[] to sch, not the intended values, change it to:

C#

string[] temp = s.Split('-'));
for each (string s in temp)
{
    sch.Add(s);
}

Posted 26-Jan-15 3:42am

Peter Leow

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tomas Takac · Accepted Answer · 2015-01-26T03:20:00

Solution 1

I would recommend you to use LINQ:

C#

final_schedule = schedule_initially.SelectMany(x => x.Split('-')).ToList();

Posted 26-Jan-15 3:20am

Tomas Takac