Get data from edit control. I wanna get feedback

Question

0.00/5 (No votes)

See more:

I make some function.
When user type value on edit control, the value is filtered my some condition.
I change codes. I just show on some parts of my codes.
Can you check my codes and give better way?

C++

void CSerialTestDlg::SetGainData()
{  

  std::wstring a=L"";  
  std::wstring a2=L"";
  std::wstring a3=L"";
 
  CString cstr="";
  CString cstrB="";
  CString cstrC="";
  
  int iLength=0;

  int *GainData = new int[3];
  memset(GainData,0x00,sizeof(int)*3);

  iLength=  Edit_VGain.GetWindowTextLengthA();
  a.resize(iLength);
  cstr = a.c_str();
  Edit_VGain.GetWindowTextA(cstr);

  iLength=  Edit_AGain.GetWindowTextLengthA();
  a2.resize(iLength);
  cstrB = a2.c_str();
  Edit_AGain.GetWindowTextA(cstrB);

  iLength=  Edit_BoardID.GetWindowTextLengthA();
  a3.resize(iLength);
  cstrC = a3.c_str();
  Edit_BoardID.GetWindowTextA(cstrC);

  delete GainData;


}

Posted 26-May-14 16:24pm

Sun-Mi Kang

Add a Solution

Comments

karthik Udhayakumar 27-May-14 0:46am

Hello Sun mi,
pls use the "improve question" widget to explain better what you want to achieve..and better way for what:)

2 solutions

Solution 2

Hi !

Why not simply use the

C++

Edit.GetWindowText(MyStr)

where

C++

MyStr

is of type

C++

CString

to get the string in the edit box ?

Posted 26-May-14 20:22pm

AmitCohen222

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

chaau · Accepted Answer · 2014-05-26T19:52:00

Solution 1

Here is your improved code:

C++

void CSerialTestDlg::SetGainData()
{  
  CString cstr="";
  CString cstrB="";
  CString cstrC="";

  Edit_VGain.GetWindowTextA(cstr);
  Edit_AGain.GetWindowTextA(cstrB);
  Edit_BoardID.GetWindowTextA(cstrC);
}

Does exactly the same as far as I can see.

Posted 26-May-14 19:52pm

chaau