My Stored Procedure Not Working - my Table Is Null

Question

1.00/5 (1 vote)

See more:

SQL

as begin

  declare @lastval varchar(10)

  set @lastval = (select max(RealEstateNumber) from RlRegistrationRealEstate)

   if @lastval is null set @lastval = 'C0001'

   declare @i int set @i = right(@lastval,4) + 1 return 'C' + right('000' + convert(varchar(10),@i),4)

    end


UPDATE [dbo].RlRegistrationRealEstate SET RealEstateNumber=@i WHERE [GUID] = @strGUID

Posted 19-Apr-14 10:31am

haythamsoft

Updated 19-Apr-14 22:03pm

Manas Bhardwaj

v2

Add a Solution

Comments

Tomas Takac 19-Apr-14 17:19pm

Can you be more specific what exactly is NULL and shouldn't be? In case you mean the RealEstateNumber is never updated then I'd like to point your attention to the RETURN statement just before END... BTW are you sure you cannot use identity for this?

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 19-Apr-14 22:43pm

Not clear.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Answer 1 · 2014-05-24T07:51:00

Solution 1

Have a look at example:

SQL

DECLARE @RegistrationTable TABLE (Code VARCHAR(30))

INSERT INTO @RegistrationTable(Code)
VALUES('C0001'), ('C0099'), ('C0589')

SELECT SUBSTRING('C0000', 1, 5-LEN(IntCode)) + CONVERT(VARCHAR(4),IntCode) AS NewCode
FROM (
SELECT COALESCE(MAX(CONVERT(INT, RIGHT(Code,4))),0)+1 AS IntCode
FROM @RegistrationTable
) AS T

Returned value: C0590.

I hope it helps ;)

Posted 24-May-14 7:51am

Maciej Los

Comments

[no name] 24-May-14 16:32pm

I think you need an SQL- gun license. I downvotaed with 5 ;)

Maciej Los 24-May-14 18:03pm

:laugh:
I really appreciate this 'downovote' ;)
SQL-gun license - i like it!