Crystal report doesn't display all records of the datagridview but olny the last one.

Question

1.00/5 (2 votes)

See more:

I have created a back - end application in C# with embedded microsft sql server. I am pretty new to crystal reports and I had created one but in a wrong way and I am trying to correct it. I almost don't remember how I created and I feel bad for that.

So, I have a form represent orders management. So when the user runs the application, he enters an OrderID in the Search Text Box and the corresponding Order appears in the form controls. More detailed, the displayed Order comes with the appropriate Invoice Record, the appropriate Customer that made this order, all these appear in RichTextBoxes, and a DataGridView that displays the products that Customer ordered. Everything runs perfectly.

I also have button for my crystal report of the searched order, the btnPrint.
I would like also to mention that report values are place to details section.

The problem comes when I try to give values to the report from the DataGridView with GiveValuesToRpt function, all the other values appears correctly. I get to the Report only the last record of product details of the DataGridView and not all the records it's need. Any suggestions, help and explanation will be much appreciated.

Thank you so much in advanced.

What I have tried:

C#

<pre> 
private void btnPrint_Click(object sender, EventArgs e)
{
   Reports.OrderRpt orderRprt = new Reports.OrderRpt(); ;
            
   OrdersPrintReport printFrm = new OrdersPrintReport(ref orderRprt);

   IEnumerable<String> paramNames = (from CrystalDecisions.Shared.ParameterField p in orderRprt.ParameterFields

                                              where string.IsNullOrEmpty(p.ReportName)

                                              select p.Name);


   foreach (Control Container in this.Controls)
     if (Container.GetType() == typeof(GroupBox) || Container.GetType() == typeof(Panel))
   {
      GiveValuesToRpt(Container, paramNames,ref orderRprt);
   }

   printFrm.Text = this.Text;
   fromForm.OpenChildForm(printFrm, this.fromForm.menuBtn);
}

private void GiveValuesToRpt(Control Container, IEnumerable<String> paramNames, ref Reports.OrderRpt OrderReport)
{
    IEnumerable<RichTextBox> RtBoxes;
    IEnumerable<CustomCombo> Cbos;
    IEnumerable<CheckBox> checkBoxes;

    IEnumerable<DateTimePicker> dtPickers;
    dtPickers  = Enumerable.Empty<DateTimePicker>();
    IEnumerable<DataGridView> dtGridViews;


    string name, ColumnName;//, strValue;
            
    RtBoxes = SaveSQLquery.GetControls<RichTextBox>(Container.Controls);
    Cbos = SaveSQLquery.GetControls<CustomCombo>(Container.Controls);
    dtPickers = SaveSQLquery.GetControls<DateTimePicker>(Container.Controls);
    checkBoxes = SaveSQLquery.GetControls<CheckBox>(Container.Controls);
    dtGridViews = SaveSQLquery.GetControls<DataGridView>(Container.Controls);

    foreach (Control cntrl in Container.Controls)
    {
        if (RtBoxes.Any())
          foreach (var RTxtbox in RtBoxes)
          {
             if (paramNames.Contains(RTxtbox.Name))
             {
                name = RTxtbox.Name.ToString();
                OrderReport.SetParameterValue(name, RTxtbox.Text);
             }
          }
          if (Cbos.Any())
             foreach (var Cbo in Cbos)
             {
                 if (paramNames.Contains(Cbo.Name))
                     OrderReport.SetParameterValue(Cbo.Name, Cbo.Text);
             }
          if (dtPickers.Any())
             foreach (var dtP in dtPickers)
             {
                if (paramNames.Contains(dtP.Name))
                {
                   OrderReport.SetParameterValue(dtP.Name, DateTime.Parse(dtP.Text.ToString()));
                }
             }
          if (checkBoxes.Any())
          {
             foreach (var checkBox in checkBoxes)
             {
                if (paramNames.Contains(checkBox.Name))
                {
                   bool value = checkBox.Checked;
                   string yes = "Ναι";

                   if (!value) yes = "Όχι";

                   OrderReport.SetParameterValue(checkBox.Name, yes);
                }
             }
          }

                
          if (dtGridViews.Any())
          {
             foreach (var dtGridV in dtGridViews)
             {
                for (int iR = 0; iR <= dtGridV.Rows.Count - 1; iR++)
                  for (int iC = 0; iC <= dtGridV.Columns.Count - 1; iC++)
                  {
                     ColumnName = dtGridV.Columns[iC].Name;
                     if (paramNames.Contains(ColumnName))
                     {
                        if (dtGridV.Rows[iR].Cells[ColumnName].Value.GetType() == typeof(string))
                                        OrderReport.SetParameterValue(ColumnName, dtGridV.Rows[iR].Cells[ColumnName].Value.ToString());

                                   
                     }
                  }
             }
          }
    }
          
}

Posted 9-Apr-24 22:48pm

Aggeliki Asimakopoulou

Updated 9-Apr-24 23:13pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2024-04-09T23:24:00

Solution 1

Each iteration of your for (int iR = 0; iR <= dtGridV.Rows.Count - 1; iR++) loop overwrites the values from the previous row with the values from the current row. As a result, you end up only passing in the values of the last row.

If you really want to pass this data to the report in parameters, then you need to set your parameters up to accept multiple values, and build an array of values to pass to the parameter:

C#

for (int iC = 0; iC < dtGridV.Columns.Count; iC++)
{
    string columnName = dtGridV.Columns[iC].Name;
    List<string> values = new List<string>(dtGridV.Rows.Count);
    for (int iR = 0; iR < dtGridV.Rows.Count; iR++)
    {
        if (dtGridV.Rows[iR].Cells[columnName].Value is string value)
        {
            values.Add(value);
        }
    }
    
    OrderReport.SetParameterValue(columnName, values.ToArray());
}

Posted 9-Apr-24 23:24pm

Richard Deeming

Comments

Aggeliki Asimakopoulou 10-Apr-24 6:11am

So, I tried the following:

 
private void btnPrint_Click(object sender, EventArgs e)
{
      Reports.OrderRpt orderRprt = new Reports.OrderRpt(); 

       OrdersPrintReport printFrm = new OrdersPrintReport(ref orderRprt);
            
       IEnumerable< CrystalDecisions.Shared.ParameterField> params_ =
       (from CrystalDecisions.Shared.ParameterField p in orderRprt.ParameterFields
        where string.IsNullOrEmpty(p.ReportName)
        select p);
            
        foreach (ParameterField pf in params_)
           pf.EnableAllowMultipleValue = true;

        IEnumerable<string> paramNames = 
        (from CrystalDecisions.Shared.ParameterField p in orderRprt.ParameterFields
         where string.IsNullOrEmpty(p.ReportName)
         select p.Name);
          
            
        foreach (Control Container in this.Controls)
           if (Container.GetType() == typeof(GroupBox) || Container.GetType() == typeof(Panel))
            {
                 GiveValuesToRpt(Container, paramNames,ref orderRprt);
            }

            printFrm.Text = this.Text;
            fromForm.OpenChildForm(printFrm, this.fromForm.menuBtn);
        }

In order to allow multiple value to params.
But with your code, I get only the first record of the dtGridV now. What goes wrong?

Richard Deeming 10-Apr-24 6:14am

Did you update your report the process the multi-value parameters?

Aggeliki Asimakopoulou 10-Apr-24 6:17am

No, how can I do that?

Richard Deeming 10-Apr-24 6:20am

1209550 - How to display all values in a multiple-value or ranged-value parameter[^]

Aggeliki Asimakopoulou 10-Apr-24 6:30am

No effect even I refresh the Report.

 private void btnPrint_Click(object sender, EventArgs e)
        {
            Reports.OrderRpt orderRprt = new Reports.OrderRpt(); ;

            //orderRprt.EnableDrillDown = False;

            //OrdersPrintReport printFrm=new OrdersPrintReport(fromForm,ref orderRprt);
            OrdersPrintReport printFrm = new OrdersPrintReport(ref orderRprt);
            
            IEnumerable< CrystalDecisions.Shared.ParameterField> params_ =
                (from CrystalDecisions.Shared.ParameterField p in orderRprt.ParameterFields
                 where string.IsNullOrEmpty(p.ReportName)
                 select p);
            
            foreach (ParameterField pf in params_)
                pf.EnableAllowMultipleValue = true;

            IEnumerable<String> paramNames = 
                (from CrystalDecisions.Shared.ParameterField p in orderRprt.ParameterFields
                 where string.IsNullOrEmpty(p.ReportName)
                 select p.Name);


            orderRprt.Refresh();

            foreach (Control Container in this.Controls)
                if (Container.GetType() == typeof(GroupBox) || Container.GetType() == typeof(Panel))
                {
                    GiveValuesToRpt(Container, paramNames,ref orderRprt);
                }

            printFrm.Text = this.Text;
            fromForm.OpenChildForm(printFrm, this.fromForm.menuBtn);
        }

With orderRprt.Refresh(); the prompt enter parameter values window always displays and we don't want this. So your code doesn't work... If I don't use orderRprt.Refresh(); I get only the first record of datagridview and I want them all... With my code I get only the last record? What's going on?
I don't understand at all the link you shared.

Richard Deeming 10-Apr-24 6:34am

"No effect..."
I don't understand at all the link you shared."

So which is it? Did you apply the changes in the link, and it didn't work? Or did you not understand the link, not make any changes, and expect a different outcome from the previous run?

Reading the link: if you've just dragged a multi-value parameter onto your report, it will only display the first value provided. You need to modify your report to display all of the values. The link explains precisely how to do that.

Aggeliki Asimakopoulou 11-Apr-24 13:13pm

I don't understand the source code in the link. It is not writtern in C#. I don't understand at all the source in this unknown programming language... How can I change the code, when I understand nothing?

Aggeliki Asimakopoulou 11-Apr-24 13:54pm

Your code doesn't work even with parameters and the crystal report is created in C# not in other platforms, not in other programming languages

if (dtGridViews.Any())
{
foreach (var dtGridV in dtGridViews)
{

for (int iC = 0; iC < dtGridV.Columns.Count; iC++)
{
string columnName = dtGridV.Columns[iC].Name;
List<string> values = new List<string>(dtGridV.Rows.Count);
for (int iR = 0; iR < dtGridV.Rows.Count; iR++)
{
if (dtGridV.Rows[iR].Cells[columnName].Value is string value)
{
pf = params_.FirstOrDefault(x => x.Name.Contains(columnName));
name = columnName.ToString();
//pf.EnableAllowMultipleValue = true;
values.Add(value);

//OrderReport.SetParameterValue(name, dtGridV.Rows[iR].Cells[columnName].Value);
//pf.CurrentValues.Clear();
//ParameterDiscreteValue paraDescritValue1 = new ParameterDiscreteValue();
//paraDescritValue1.Value = value;
//pf.CurrentValues.Add(paraDescritValue1);
//paraFields.Add(pf);

//OrderReport.SetParameterValue(columnName, value);
//pf.CurrentValues.Clear();
//ParameterDiscreteValue paraDescritValue1 = new ParameterDiscreteValue();
//paraDescritValue1.Value = value;// value;
//pf.CurrentValues.Add(paraDescritValue1);
//paraFields.Add(pf);
}
}

//var test = values.ToArray();
OrderReport.SetParameterValue(columnName, values.ToArray().Last().ToString());
pf.CurrentValues.Clear();
ParameterDiscreteValue paraDescritValue1 = new ParameterDiscreteValue();
paraDescritValue1.Value = values.ToArray().Last();

pf.CurrentValues.Add(paraDescritValue1);
paraFields.Add(pf);
}

Richard Deeming 12-Apr-24 3:31am

"Doesn't work" is not a question, nor a proper description of a problem. How would you feel if your users called you, said "Your software doesn't work!", and put the phone down? If you want help, you need to explain the problem clearly.

Crystal Reports formulas do not use C#; they use their own proprietary language.

This is a "quick answers" forum. This is not the place to teach you how to create a Crystal Reports report.

Aggeliki Asimakopoulou 12-Apr-24 7:40am

Excuse me, but I described it a lot from the start. All source code is written in C# and the question is refered to C#. I have never written code in crystal reports.
I have created a back - end application in C# with embedded microsft sql server.

I have a form represent orders management. So when the user runs the application, he enters an OrderID in the Search Text Box and the corresponding Order appears in the form controls. All these in C#. More detailed, the displayed Order comes with the appropriate Invoice Record, the appropriate Customer that made this order, all these appear in RichTextBoxes, and a DataGridView that displays the products that Customer ordered. Everything runs perfectly.

I also have button for my crystal report of the searched order, the btnPrint in a form.
I would like also to mention that report values are place to details section in C#.

The problem comes when I try to give values to the report from the DataGridView with GiveValuesToRpt function, all the other values appears correctly. I get to the Report only the last record of product details of the DataGridView and not all the records it's need. All the source code is written in C#, the crystal report is also created in C#. And the source code I shared is written in C#, both the print button on the OrdersForm and the GiveValuesToRpt which is called form the print button. Isn't something clear? I have tried with your code, even with parameters and I get only the first record of datagridview, with my source code I get only the last record of datagridview, what if I had dozens of records to the datagridview that they refer to order products? I don't want the first or the last record of the datagrid view data, I want all these records to be displayed one under the other in my crystal Report. My crystal report represent an Order Receipt.

Richard Deeming 12-Apr-24 7:44am

1) You wrote: "Your code doesn't work even with parameters" - if you think that counts as "described it a lot", then you have some serious work to do!

2) If you're trying to do anything slightly non-standard in a Crystal Reports report, such as displaying multiple values from a parameter, then you need to write code in the report. That code cannot be written in C#.

3) This is NOT the place to badger someone into teaching you how to use Crystal Reports!

Aggeliki Asimakopoulou 12-Apr-24 14:07pm

I have never written source code in Crystal Reports as the link you shared to me and it's not properly source code because I know visual basic .net and I tried it and it has several error the debugger hits. However you didn't explain to me. If I don't understand something, if I don't have any guidance how can I solve it? If your run your source code, you will definetely see, that yes it doesn't work, it give only the first record. Through OrderReport.SetParameterValue(columnName, values.ToArray()); you set all the values but the parameter only gets the first one...
If you had explained to me as I asked it, I could do that.
Anyway, I watched this video https://www.youtube.com/watch?v=rwc6oxOG0OQ, I followed step by step and it works for me, I get all values in a different way and I will include it to my main report as a subreport.
Excuse me, but I can't accept a solution that doesn't work and without a good example in order to try it, by my own. Thank you.

Richard Deeming 15-Apr-24 3:25am

Crystal Reports DOES NOT USE any .NET language - it has its own language for writing formulas.

You CANNOT write the formula in VB.NET or C#.

And "I don't understand the code" is NOT the same as "This is not properly source code".

If you're looking for someone to teach you how to create a Crystal Reports report, then you have come to the wrong site. This is a Quick Answers forum, not a tutorials site.

I suggest you start with the SAP how-to guides[^] and work from there.