comparing textbox values with sql server database

Question

1.67/5 (5 votes)

See more:

hi every one.i am working with login functionality.i have code below

C#

protected void Button1_Click(object sender, EventArgs e)
{
SqlConnection conn = new SqlConnection();
conn.ConnectionString = System.Configuration.ConfigurationManager.ConnectionStrings["leave"].ConnectionString;
            conn.Open();

            string id = TextBox1.Text;
            string password = Textbox2.Text;
            SqlCommand cmd = new SqlCommand("Select uname, pswd from emp_details where uname = @id and pswd = @password ", conn);

            SqlDataReader dr = cmd.ExecuteReader();
            if (dr.HasRows)
            {
                conn.Close();
                Response.Redirect("Default.aspx");

            }
}

i am getting the error after button click....Must declare the scalar variable "@id".

any help would be greatly appriciated.....

Posted 17-Jan-13 23:37pm

Thanks7872

Updated 17-Jan-13 23:45pm

Mohd. Mukhtar

v3

Add a Solution

Comments

rizwan muhammed khan gouri 24-Jan-13 0:21am

who give me down vote .First check it

Thanks7872 24-Jan-13 0:22am

i am not getting you.what you mean?

3 solutions

Solution 2

To add to what Faisalabadians says (and he is right as far as it goes), do not do it that way anyway!
Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^]

Posted 17-Jan-13 23:47pm

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Faisalabadians · Accepted Answer · 2013-01-17T23:46:00

Solution 1

C#

SqlCommand cmd = new SqlCommand("Select uname, pswd from emp_details where uname = @id and pswd = @password ", conn);

after your above code, write these lines

C#

cmd.Parameters.Add(new SqlParameter("@id", "id here"));
cmd.Parameters.Add(new SqlParameter("@password", "password here"));

Posted 17-Jan-13 23:46pm

Faisalabadians

Updated 17-Jan-13 23:47pm

v2

Naman Kumar Sinha · Accepted Answer · 2013-01-17T23:58:00

You are using the scalar variable @id and @password. You should also mention what type of parameter is this! Add the following line of code.

C#

SqlCommand cmd = new SqlCommand("Select uname, pswd from emp_details where uname = @id and pswd = @password ", conn);
cmd.Parameters.Add(new SqlParameter("@id", System.Data.SqlDbType.VarChar)).Value = TextBox1.Text;
cmd.Parameters.Add(new SqlParameter("@password", System.Data.SqlDbType.VarChar)).Value = TextBox2.Text;

Here,

cmd.Parameters.Add(new SqlParameter("@id", System.Data.SqlDbType.VarChar)).Value = TextBox1.Text;

is telling the compiler that the parameter @id is of type SQL VarChar, and then assigning the value TextBox1.Text to the parameter @id.
Now, since your parameters are declared, when the compiler reaches at this line

SqlDataReader dr = cmd.ExecuteReader();

It knows the data type of your parameter and you will not get the error you mentioned in your question.

Hope that helps.
Cheers,
Naman