What is wrong with this C code ?

Question

1.00/5 (1 vote)

See more:

C++

#include <stdio.h>
int main()
{
    float a, b;
    printf("Type 0 to convert km to miles\nType 1 to convert kg to pounds\nType 2 to convert  cm to inches\n");
    scanf("%d", &a);
    if (a == 0)
    {

        printf("Enter km to convert in miles:\n");
        scanf("%f", &b); //1.609
        printf("%f km is equals to %f", b, b / 1.609);
    }
    else if (a == 1)
    {
        printf("Enter kgs to convert in pounds:\n");
        scanf("%f", &b);
        printf("%f kg is equals to %f Pounds", b, b * 2.205);
    }
    else if (a == 2)
    {
        printf("Enter cm to convert in inches:\n");
        scanf("%f", &b);
        printf("%f cm is equals to %f inches", b, b * 2.54);
    }
    return 0;
}

What I have tried:

When i run this code and enter 0 it works fine as it would be but when i try other values (ie., 1 and 2 ) code do not run . it get exit . please help me i am stucked.

Posted 3-Mar-21 12:33pm

Amaan Ahmad

Updated 3-Mar-21 20:25pm

Shao Voon Wong

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2021-03-03T20:25:00

In addition to other solutions:

Don't use float unless you have very good reason for. Use double instead.
Your code should handle incorrect user choice.
The cm to inch formula in your code is wrong.

Try

C

#include <stdio.h>
int main()
{
    double arg, result;
    int choice;
    printf("Type 0 to convert km to miles\nType 1 to convert kg to pounds\nType 2 to convert  cm to inches\n");
    scanf("%d", &choice);
    if (choice == 0)
    {
        printf("Enter km to convert in miles:\n");
        scanf("%lf", &arg); //1.609
        result = arg / 1.609;
        printf("%f km is equals to %f\n", arg, result);
    }
    else if (choice == 1)
    {
        printf("Enter kgs to convert in pounds:\n");
        scanf("%lf", &arg);
        result = arg * 2.205;
        printf("%f kg is equals to %f Pounds\n", arg, result);
    }
    else if (choice == 2)
    {
        printf("Enter cm to convert in inches:\n");
        scanf("%lf", &arg);
        result = arg / 2.54;
        printf("%f cm is equals to %f inches\n", arg, result);
    }
    else
    {
      printf("Invalid choice\n");
    }
    return 0;
}

Peter_in_2780 · Answer 2 · 2021-03-03T13:06:00

Solution 1

You have declared a as float.
Then you use scanf to store an integer value in that place.
An integer 0 has the same bit pattern as a float 0.0,
but the integer values for 1 and 2 are nothing like the floats
for 1.0 and 2.0

I'll leave you to work out the fix.

Posted 3-Mar-21 13:06pm

Peter_in_2780

Shao Voon Wong · Answer 3 · 2021-03-03T13:49:00

Solution 2

a variable type should be integer. Integer is a type of number which does not have fractional parts, unlike float. Input of zero works for both the integer and float types because 0 and 0.0 are all the bits of the variable set to zero, so they are equivalent.

Try this.

C++

int a = 0;
float b = 0.0f;

Posted 3-Mar-21 13:49pm