Need a little C# improvement

Question

0.00/5 (No votes)

See more:

Below are two sections in C#.
One: supposedly, returns ALL current windows platform usernames.

Two: supposedly, returns ALL active logged in windows users. whether one and/or many.

But yet, I'm trying to tye it down to the localhost as seen below. No hardcoding.
I cannot get section two to work. I've tried many different ways to achieve my goal of
listing ALL active logged in windows users. whether one and/or many. Can someone
also return if each windows user has admin-prov or not.

Is there some knowledgible person who could rework the code to make it better and achieve the goals.

Thanks, in advance. Member 15028314
...

What I have tried:

There is what I have done...

C#

string userlabel1 = System.Environment.UserName;            // is there a query to retrieve computer name. 
            currentuserlabel1.Text = userlabel1.ToString();

            var connectionOptions = new ConnectionOptions();
            ManagementScope xscope = new System.Management.ManagementScope("\\\\localhost", connectionOptions);  // <-- do I need this statement on each query? 

// section one.  
// get ALL usernames on the windows local platform.

           SelectQuery query = new SelectQuery("Win32_UserAccount");
            ManagementObjectSearcher searcher = new ManagementObjectSearcher(query);           //  (xscope, query);
            foreach (ManagementObject envVar in searcher.Get())
            {
                tline = (string)envVar["Status"];
                if (tline.Contains("OK"))
                {
                    listBox1.Items.Add(envVar["Name"]);
                    icnt = icnt + 1;
                }
              }
            listBox1.SelectedIndex = 0;
            listBox1.Refresh();
            xlabel1.Text = "";
            xlabel1.Text = icnt.ToString();
            ////==============================
            string userlabel1 = System.Environment.UserName;
            currentuserlabel1.Text = userlabel1.ToString();

// section two  
// get ALL Log'ed in usernames on the windows local platform.

           var connectionOptions = new ConnectionOptions();
            ManagementScope xscope = new System.Management.ManagementScope("\\\\localhost", connectionOptions);
            ObjectQuery xquery = new System.Management.ObjectQuery("select * from Win32_ComputerSystem");
            ManagementObjectSearcher xsearcher = new ManagementObjectSearcher(xscope, xquery);
            foreach (var row in xsearcher.Get())
            {
               String tlinex = (String)row["Name"].ToString();
                Console.WriteLine(row["Userame"].ToString());
            }

Posted 27-Dec-20 16:54pm

Member 15028314

Updated 28-Dec-20 4:48am

PIEBALDconsult

v3

Add a Solution

Comments

[no name] 27-Dec-20 23:05pm

Environment.MachineName.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2020-12-27T17:15:00

Where to begin...

First, a pet peeve of mine. WHY ARE YOU CALLING .ToString() ON A STRING???????? It's already a string.

You don't really need ConnectionOptions for such a simple query on a local machine.

...and you mispelled "UserName" in the last Console.WriteLine statement.

A slightly rewritten version of your code:

C#

string userNameEnv = System.Environment.UserName;
Console.WriteLine(userNameEnv);

// The path for a management scope on the local machine
// in the namespace Win32_ComputerSystem can be found.
ManagementScope scope = new ManagementScope(@"\\.\root\CIMV2");
scope.Connect();

// Query for all the Win32_ComputerSystem instances. Normally,
// this is just 1 instance, but it is still returned in a
// collection.
ObjectQuery query = new ObjectQuery("SELECT * FROM Win32_ComputerSystem");
ManagementObjectSearcher searcher = new ManagementObjectSearcher(scope, query);

// Tell the searcher to go do its thing and return the result collection.
ManagementObjectCollection results = searcher.Get();

// Output the result of the search.
foreach (var item in results)
{
    Console.WriteLine($"Computer Name: {item["Name"]}\r\nLogged In User: {item["UserName"]}");
}