Why is my code going through if and else statement

Question

0.00/5 (No votes)

See more:

Basically my code is going through both the if and else statement the first time it loops.

Basically it is going through if(length = length) and if(length < length)

[^]

The first time it runs fine but the second time it doesnot

What I have tried:

if (GuessChar.Length == ActualChar.Length)//GIVING ERROR
            {
                //Check Each Element
                for (int i = 0; i < WordLenght; i++)
                {
                    for (int p = 0; p < WordLenght; p++)
                    {
                        if (GuessChar[i] == ActualChar[p])
                        {
                            LetterGuessed++;
                        }
                    }
                }
                //Repeating in a single array
                var duplicateDict = new Dictionary<char, int>();
                foreach (var ch in GuessChar)
                {
                    if (duplicateDict.ContainsKey(ch))
                    {
                        duplicateDict[ch]++;
                    }
                    else
                    {
                        duplicateDict.Add(ch, 1);
                    }
                }

                foreach (var ch in duplicateDict.Where(x => x.Value > 1))
                {
                    //Console.WriteLine(string.Format("Duplicate Character {0}, Count {1}", ch.Key, ch.Value));
                    repeated++;
                }
                if (repeated == 1)
                {
                    repeated = 0;
                }
                for (int i = 0; i < WordLenght; i++)
                {
                    if (ActualChar[i] == GuessChar[i]) Victory = true;
                }

            }
            else if (GuessChar.Length > WordLenght)
            {
                //THIS ONE IS GIVING THE ERROR
                Console.WriteLine("Wrong Length, Actual Lenght is : Shorter");
            }
            else if (Guess.Length > WordLenght)
            {
                Console.WriteLine("Wrong Length, Actual Lenght is : Longer");
            }

Posted 13-May-20 1:44am

NotAComputerScienceStudent

Updated 15-May-20 0:19am

v3

Add a Solution

Comments

Richard MacCutchan 13-May-20 7:50am

There are a few ifs and elses in your code. Which ones are you referring to and what conditions are being checked?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2020-05-13T02:24:00

Solution 1

C#

else if (GuessChar.Length > WordLenght)
{

    Console.WriteLine("Wrong Length, Actual Lenght is : Shorter");
}
else if (Guess.Length > WordLenght) // *** this one should use < operator
{
    Console.WriteLine("Wrong Length, Actual Lenght is : Longer");
}

You are using the same compare operator for two different tests.

Posted 13-May-20 2:24am

Richard MacCutchan

Comments

Maciej Los 13-May-20 8:32am

Hawk eye!

Richard MacCutchan 13-May-20 9:42am

If I changed my name I would soon be found out. :(

NotAComputerScienceStudent 13-May-20 8:33am

if (GuessChar.Length == ActualChar.Length) and else if (GuessChar.Length > WordLenght) both of these statements are being excecuted.

Richard MacCutchan 13-May-20 9:41am

Yes, because they are testing different situations: first ActualChar.Length, second WordLenght. You really need to look more closely at the code you have written.

F-ES Sitecore 13-May-20 9:09am

One is testing GuessChar and the other just Guess.

Richard MacCutchan 13-May-20 9:43am

Oops, I missed that.

George Swan · Answer 2 · 2020-05-15T00:20:00

It seems to me that you are doing things the hard way.

C#

//Check Each Element
              for (int i = 0; i < WordLength; i++)
              {
                for (int p = 0; p < WordLength; p++)
                 {
                   if (GuessChar[i] == ActualChar[p])
                    {
                      LetterGuessed++;
                    }
                 }
              }

Can be replaced by

C#

foreach (char c in GuessChar)
{
    LetterGuessed = ActualChar.Contains(c) ? LetterGuessed+=1: LetterGuessed;
}

And this

C#

//Repeating in a single array
var duplicateDict = new Dictionary<char, int>();
foreach (var ch in GuessChar)
{
    if (duplicateDict.ContainsKey(ch))
    {
        duplicateDict[ch]++;
    }
    else
    {
        duplicateDict.Add(ch, 1);
    }
}

foreach (var ch in duplicateDict.Where(x => x.Value > 1))
{
    //Console.WriteLine(string.Format("Duplicate Character {0}, Count {1}", ch.Key, ch.Value));
    repeated++;
}

Can be refracted to

C#

var letters = GuessChar.GroupBy(c => c, (k, x) => (Letter:k, DuplicateCount:x.Count()-1));
 foreach(var letter in letters)
 {
     repeated += letter.DuplicateCount;
 }

Not sure why you are setting repeated to 0 if it is 1 but you can remove the if statement by doing this

C#

//if (repeated == 1)
//{
//    repeated = 0;
//}
repeated= repeated==1?0:repeated;

This loop should have an early exit option

C#

for (int i = 0; i < WordLength; i++)
              {
                  if (ActualChar[i] == GuessChar[i]) Victory = true;
              }
for (int i = 0; i < WordLength; i++)
              {
                  if (ActualChar[i] == GuessChar[i])
                   {
                    Victory = true;
                    break;
              }

Finally, the last else if statement

C#

else if (GuessChar.Length > WordLength)
{
    //THIS ONE IS GIVING THE ERROR
    Console.WriteLine("Wrong Length, Actual Lenght is : Shorter");
}
else if (GuessChar.Length > WordLength)
{
    Console.WriteLine("Wrong Length, Actual Lenght is : Longer");
}