Casting error while converting datetime.now into datetime2(0)

Question

0.00/5 (No votes)

See more:

The column named "updated_at" in my table has datetime2(0) datatype and there is a variable named "_updated_at" in my code-behind has datatype "DateTime".

DateTime _updated_at=System.DateTime.Now;

How to convert System.DateTime.Now into "datetime2(0)"

I tried the following but still the casting exception is thrown saying Conversion failed when converting date and/or time from Character string.

I am using MS-SQL Server 2014.

What I have tried:

DateTime _updated_at =(DateTime)System.DateTime.Now;

Posted 13-Jan-20 19:36pm

Member 14649908

Updated 15-Jan-20 5:55am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-01-13T19:53:00

You don't need the cast: DateTime.Now already returns a DateTime value, so a cast is redundant.

The error message refers to a character string:

Conversion failed when converting date and/or time from Character string.

Which means that you are passing the DateTime value to your DB by concatenation strings:

C#

string sql = "UPDATE MyTable SET Updated_At='" + _updated_at + "'";

And that is what is causing your problem because the string you pass is being interpreted incorrectly by SQL, And you should be glad it is, because the chances are it would have worked two days ago, but stored the wrong values into your DB.

Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Fix that throughout your app, and the problem you have noticed will go at the same time.

Member 14649908 · Answer 2 · 2020-01-15T05:56:00

Solution 2

C#

DateTime _updated_at=DateTime.Now;

........
.......

cmd.Parameters.Add("@updated_at", SqlDbType.DateTime2).Value = _updated_at;

Posted 15-Jan-20 5:56am