I connected my database and everything runs perfectly but data won't get entered to the database. What should I do?

Question

1.00/5 (1 vote)

See more:

Data won't get entered in the database. But it runs.. what should I do?

using System.Data.OleDb;

namespace TO_Inspection_Leaving_Form
{
    public partial class SLIC_TOILForm : Form
    {
        OleDbConnection con = new OleDbConnection(@"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Users\Kalindu Washington\Downloads\TOInspectionLeaving_Database.accdb");
        public SLIC_TOILForm()
        {
            InitializeComponent();
        }

        private void btn_Submit_Click(object sender, EventArgs e)
        {
            con.Open();
            OleDbCommand cmd = con.CreateCommand();
            cmd.CommandType = CommandType.Text;
            cmd.CommandText = "insert into TOInspectionRecordTable (TO_Name,Emp_ID,Inq_ID,Policy_No,InqVeh_No) values('" + txt_TOName.Text + "','" + txt_EmpID.Text + "','" + txt_InqID.Text + "','" + txt_PolNo.Text + "','" + txt_InqVehNo.Text + "')";
            cmd.ExecuteNonQuery();
            con.Close();
            MessageBox.Show("Record Submitted");

        }
    }
}

What I have tried:

Tried again and again but don't seem to work.

Posted 10-Dec-19 20:35pm

Kalindu Washington

Updated 10-Dec-19 22:27pm

Add a Solution

2 solutions

Solution 2

The OleDbCommand.ExecuteNonQuery Method (System.Data.OleDb) | Microsoft Docs[^] returns a value that lets you know how many rows were inserted. So you need to check that value in your code; do not assume that your insert command has been successful - as you are doing.

Posted 10-Dec-19 22:28pm

Richard MacCutchan

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2019-12-10T20:43:00

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

Fix that throughout your app, and you may find your problem goes away.