Stochrsi algorithm quickly gets over brought and over sold ...looks havig sum issue . Please help .

Quote:

I have doubt does it working perfectly . Please help .

Nobody but you can workout something with the piece of code in your question because you are the only one knowing the untold.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

Debugging C# Code in Visual Studio - YouTube[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

My stochrsi code as follows .. Please help .

private double CalculateStochRSI(List<PriceCollectionWithId> RSiColl, int RsiPeriod, int isHigherTimeFrame)
       {

           double stochRsi_last_val = 0;
           List<PriceCollectionWithId> RSiCollDesc = RSiColl.OrderByDescending(o => o.AutoId).ToList();
           List<PriceCollectionWithId> RSiCollDesc_HigherTimeframe = null;
           if (isHigherTimeFrame == 2)
           {
               RSiCollDesc_HigherTimeframe = RSiColl.FindAll(x => x.Rsi1 != -11).OrderByDescending(o => o.AutoId).ToList();
           }
           else
           {
               RSiCollDesc_HigherTimeframe = RSiCollDesc;
           }


           if (RSiColl.Count >= Convert.ToInt32(RsiPeriod + 5))
           {
               int MaxSlNo = RSiCollDesc_HigherTimeframe.Max(t => t.SlNo);
               List<PriceCollectionWithId> NeedToProcessRsiDesc = RSiCollDesc_HigherTimeframe.FindAll(x => x.SlNo >= (MaxSlNo - RsiPeriod) && x.SlNo <= MaxSlNo);
               List<PriceCollectionWithId> NeedToProcessRsiAsc = NeedToProcessRsiDesc.OrderBy(o => o.AutoId).ToList();
               PriceCollectionWithId lastVal = NeedToProcessRsiAsc.LastOrDefault();
               if (lastVal != null)
               {
                   if (isHigherTimeFrame == 1)
                   {
                       stochRsi_last_val = 0;
                       double maxVal = NeedToProcessRsiAsc.Max(t => t.RsiValue);
                       double minVal = NeedToProcessRsiAsc.Min(t => t.RsiValue);
                       double lastRsi = lastVal.RsiValue;
                       stochRsi_last_val = ((lastRsi - minVal) / (maxVal - minVal));
                       stochRsi_last_val = Math.Round(stochRsi_last_val, 2, MidpointRounding.AwayFromZero);
                   }
                   if (isHigherTimeFrame == 2)
                   {
                       stochRsi_last_val = 0;
                       double maxVal = NeedToProcessRsiAsc.Max(t => t.Rsi1);
                       double minVal = NeedToProcessRsiAsc.Min(t => t.Rsi1);
                       double lastRsi = lastVal.Rsi1;
                       stochRsi_last_val = ((lastRsi - minVal) / (maxVal - minVal));
                       stochRsi_last_val = Math.Round(stochRsi_last_val, 2, MidpointRounding.AwayFromZero);
                   }
               }
           }
           return stochRsi_last_val;
       }

Class Definition -

public class PriceCollectionWithId
{
    public int AutoId { get; set; }
    public int SlNo { get; set; }
    public double RsiValue { get; set; }
    public double StochRsiValue { get; set; }
    public double OtherIndicatorValue { get; set; }



    public double Rsi1 { get; set; }
    public double Rsi2 { get; set; }
    public double StockRsi1 { get; set; }
    public double StockRsi2 { get; set; }
}