WPF ObservableCollection problem

Question

4.50/5 (2 votes)

See more:

Hi all, newbie coder needs help please,
I have a combobox set up displaying images and text (works great) but for the life of me I can't change the class to pass in image paths, below is the class code, I would be eternally greatful if someone can adjust code to be useful rather than use hard coded paths.
Thanks in advance.

'-------------------------------------------------------------

VB

Imports System.Collections.ObjectModel
Imports System.ComponentModel
Imports System.Collections.Generic
Imports System.Text

    Public Class ImageFactory
        
        Public Shared count As Integer = 0
    Private Shared _myactualdata As New Images()
        Public Shared ReadOnly Property MyImages() As Images
            Get
                Return _myactualdata
            End Get
        End Property
        Public Class Images
            Inherits ObservableCollection(Of ImageData)
        Public Sub New()
            ' this works but not much use to me as it is.
            Me.Add(New ImageData("Resources\Images\0.jpg"))
            Me.Add(New ImageData("Resources\Images\1.jpg"))
            Me.Add(New ImageData("Resources\Images\2.jpg"))
            Me.Add(New ImageData("Resources\Images\3.jpg"))
            Me.Add(New ImageData("Resources\Images\4.jpg"))
            Me.Add(New ImageData("Resources\Images\5.jpg"))
            Me.Add(New ImageData("Resources\Images\6.jpg"))
            Me.Add(New ImageData("Resources\Images\7.jpg"))
            Me.Add(New ImageData("c:\test\100_DSC_1727-s.jpg"))
        End Sub
       
    End Class


        Public Class ImageData
            Implements INotifyPropertyChanged
            '
            Private _sImageName As [String] = ""

            Public Sub New(ByVal sImageName As String)
                ImageFactory.count += 1
                ImageName = sImageName
            End Sub

            Public Property ImageName() As [String]
                Get
                    Return _sImageName
                End Get
                Set(ByVal value As [String])
                    _sImageName = value
                    NotifyPropertyChanged(ImageName)
                End Set
            End Property

            Protected Sub NotifyPropertyChanged(ByVal sProp As [String])
                RaiseEvent PropertyChanged(Me, New PropertyChangedEventArgs(sProp))
            End Sub

            Public Event PropertyChanged(ByVal sender As Object, ByVal e As PropertyChangedEventArgs) Implements INotifyPropertyChanged.PropertyChanged
        End Class

    End Class

Posted 30-Jul-12 15:10pm

Member 7278598

Add a Solution

Comments

[no name] 30-Jul-12 21:17pm

You might want to consider passing a Collection to your class for your strings.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kenneth Haugland · Accepted Answer · 2012-07-30T18:08:00

There are a number of minor mistakes in you code. One is that you created a custom notifycation when changing the properties and it wants a string, so do that:

VB

NotifyPropertyChanged("ImageName")

The only reason you need this class is the you want to know if a memeber gets an updated source, like a change in the Url etc. The ObservableCollection was made to fire an event when the collection gets updated, like adding an item and removing an item. It does however not fire an event when an item gets changed/updated.

And why did you make this class shared readonly?

VB

Public Shared ReadOnly Property MyImages() As Images

A shared list is usually not needed, as the same would be seen by all new instances of the new class.

To make make the code work according to your specs, you only need the ImageData class, An ObservableCollection and not the other code. You could simply bind the observable collection to any list, grid or whatever.