Error array out of bound is giving when i remove chielditem of menu1

Question

2.00/5 (1 vote)

See more:

When i removing child item of menu1 .It is giving array out of bound why ?

VB

If user_type = "User" Then
            For i As Integer = 0 To Menu1.Items.Count - 1
                If (Menu1.Items(i).Text = "Master") Then
                    For j As Integer = 0 To Menu1.Items(i).ChildItems.Count - 1
                        If (Menu1.Items(i).ChildItems(j).Text = "Grade Detail") Then
                            'Menu1.Items(i).ChildItems(j).Selectable = False
                            Menu1.Items(i).ChildItems(j).Enabled = False
                            'Menu1.Items.RemoveAt(i)

                        End If
                        If (Menu1.Items(i).ChildItems(j).Text = "Machine Detail") Then
                            Menu1.Items(i).ChildItems(j).Enabled = False
                        End If
                        If (Menu1.Items(i).ChildItems(j).Text = "Customer Detail") Then
                            Menu1.Items(i).ChildItems(j).Enabled = False
                        End If
                        If (Menu1.Items(i).ChildItems(j).Text = "Max Rebar Per Cycle") Then
                            Menu1.Items(i).ChildItems(j).Enabled = False
                        End If
                        If (Menu1.Items(i).ChildItems(j).Text = "Plant Capacity") Then
                            Menu1.Items(i).ChildItems(j).Enabled = False
                        End If
                    Next
                End If
            Next
        End If

Posted 10-Jul-12 17:32pm

Janardan Pandey

Updated 10-Jul-12 17:35pm

Sergey Alexandrovich Kryukov

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2012-07-10T17:44:00

The problem is very simple, it is visible from the first glance. Consider some simplified code:

VB

For j As Integer = 0 To Menu1.Items(i).ChildItems.Count - 1 'incorrect, Count changes when you delete inside the loop
    If (someCondition) Then
       Menu1.Items.RemoveAt(i) 'incorrect: index is shifted as a result of previous deletion
    End If
Next

Are you getting the idea? One possible and simple work-around is: 1) assign Count to some variable initialized before the loop, use this variable in the condition of the loop end instead of Menu1.Items(i).ChildItems.Count; this way, the loop end condition will depend on a value which is not modified in the cycle (so called cycle invariant); 2) execute the loop in reverse, from count - 1 down to 0; this will eliminate the problem of shifting the item indices as a result of item removal.

Yes, this simple.

—SA