C++ read all lines in text file

Question

1.00/5 (1 vote)

See more:

I am getting all 10 lines (line by line ) in mfc project as CStringArray but recieve error on to getting 4th line string.

my text file is:

C:\Program Files (x86)\GRETECH\GOMPlayer\GOM.EXE
C:\Program Files\VideoLAN\VLC\vlc.exe
C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
C:\Windows\notepad.exe
C:\Windows\System32\cmd.exe
C:\Windows\System32\mspaint.exe
C:\Windows\System32\calc.exe
C:\Windows\System32\calc.exe
C:\Windows\System32\osk.exe
C:\Windows\System32\msconfig.exe

Please check my function or alternate to this function. And please code me fuction for updating any line.

What I have tried:

    CString AMyClass::getStringfromText(CString filename, int linenumber)
    {
    CStdioFile file;	
    CStringArray aLineArray;
    CString All_Lines;
    CString out;
    CString strExePath;
    
    linenumber=linenumber-1;
    CString applicationPath;
    char fname[_MAX_PATH+1];
    
    ::GetModuleFileNameA(NULL,fname,_MAX_PATH);
    applicationPath = fname;
    applicationPath.MakeLower();
    strExePath = applicationPath.Left(applicationPath.ReverseFind('\\') + 1);

    file.Open(strExePath+filename, CFile::modeRead);

    while (file.ReadString(All_Lines))
    {
    aLineArray.Add(All_Lines);

    }
    file.Close ();
    out=aLineArray[linenumber];
    return out;
    }

**and code is:**

    CString str_s4;
    str_s4=AMyClass::getStringfromText (_T("MyApps.ini"),4);
    AfxMessageBox(str_s4);

Posted 28-Jun-18 18:12pm

Shahzad Naseer

Updated 28-Jun-18 20:13pm

v3

Add a Solution

Comments

Richard MacCutchan 29-Jun-18 3:21am

What error?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Accepted Answer · 2018-06-28T20:15:00

You should use the debugger and step into the code. I guess from reading that the the file wasnt found in the directory and so the aLineArray is empty.

Good coding means also checking functions like the file.Open and some error handling:

C++

if( !file.Open(strExePath+filename, CFile::modeRead) ) {
  TRACE("File couldnt get opened");
  return "";
}