Saving a windows size position and state in MFC

Question

5.00/5 (1 vote)

See more:

If I bring up the GUI, and then I resize and close it, when I start it up again it reverts back to the original size.
it should remember the old values

What I have tried:

the below method will get intiate while closing GUI and it will write the size
void CMainFrame::OnDestroy()
{
m_bShuttingDown = true;

WINDOWPLACEMENT wp;
GetWindowPlacement(&wp);
AfxGetApp()->WriteProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE)&wp, sizeof(wp));
CFrameWndEx::OnDestroy();
}

the below method will get call while loading GUI

oid CMainFrame::OnShowWindow(BOOL bShow, UINT nStatus)
{
    CFrameWndEx::OnShowWindow(bShow, nStatus);

    if (bShow && !IsWindowVisible()) //The formal parameter bShow is true when the window is about to be shown, 
                                        //and false when it is about to be hidden
       
    {
       
        WINDOWPLACEMENT *lwp;
        UINT nl;
     
        if (AfxGetApp()->GetProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE*)&lwp, &nl))
        {
            SetWindowPlacement(lwp);           
           
            UpdateWindow();
            delete[] lwp;
        }
}the above method its returning old values but gui is positioning as per that values
could you please tell me if anything is wrong here

Posted 4-Sep-17 20:15pm

Member 13089825

Updated 5-Sep-20 11:19am

Add a Solution

Comments

Richard MacCutchan 5-Sep-17 2:41am

Use the debugger to check which values are being saved and loaded in each case.

Member 13089825 5-Sep-17 2:46am

i have debugged ,values are restoring correctly but GUI is not updating with restoring values

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Michael Haephrati · Answer 1 · 2020-09-05T11:20:00

I found these 2 functions to work for me.

void MyDialog::LoadDialogPlacement()
{
	static WINDOWPLACEMENT last_wp = {};
	// Load last stored DB version
	WINDOWPLACEMENT *wp = new WINDOWPLACEMENT;
	GetStoredWindowPlacement(&wp);
	if (memcmp((void *)&last_wp, (const void *)wp, sizeof(WINDOWPLACEMENT)) == 0) return;
	memcpy((void *)&last_wp, (const void *)wp, sizeof(WINDOWPLACEMENT));
	SetWindowPlacement(wp);
	delete[] wp;

}
void MyDialog::SaveDialogPlacement()
{
	static WINDOWPLACEMENT last_wp = {};

	if (IsWindowVisible())
	{
		WINDOWPLACEMENT wp = {};
		wp.length = sizeof(WINDOWPLACEMENT);
		GetWindowPlacement(&wp);
		if (memcmp((void *)&last_wp, (const void *)&wp, wp.length) == 0) return;
		memcpy((void *)&last_wp, (const void *)&wp, wp.length);
		StoreWindowPlacement(&wp);
	}

}

Jochen Arndt · Answer 2 · 2017-09-04T20:56:00

Solution 1

It looks like you have used the code from the CodeProject article Saving a windows size position and state in MFC[^] but did not read it completely.

OnShowWindow might be also called during program execution but you probably want it to be called only at program start. The article mentions that and provides code using the state variable bOnce to set the placement only when OnShowWindow is called the first time.

[EDIT: A different approach that I have used in the past]
Save the placement in CMainFrame::OnClose instead of OnDestroy.

Set the placement in CMainFrame::OnCreate instead of OnShowWindow. However, this will set only the position and the size will be set later when calling ShowWindow from InitInstance requiring that the command is passed stored:

int CMainFrame::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
    // ... (call OnCreate of base class)
    
    WINDOWPLACEMENT *lwp;
    UINT nl;
    if (AfxGetApp()->GetProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE*)&lwp, &nl))
    {    
        // save show state
        m_nCmdShow = lwp->showCmd;
        // must set this to normal here
        lwp->showCmd = SW_SHOWNORMAL;
        SetWindowPlacement(lwp);
        delete[] lwp;
    }
    
    // ...
}

// To be called from InitInstance()
void CMainFrame::ShowWindowInitial()
{
    ShowWindow(m_nCmdShow);
    UpdateWindow();
}

BOOL CMyApp::InitInstance()
{
    // ...
    //CMainFrame pMainFrame = new CMainFrame;
    pMainFrame->ShowWindowInitial();
    // ...
}

[/EDIT]

Posted 4-Sep-17 20:56pm

Jochen Arndt

Updated 5-Sep-17 0:37am

v6

Comments

Member 13089825 5-Sep-17 3:03am

void CMainFrame::OnShowWindow(BOOL bShow, UINT nStatus)
{
CFrameWndEx::OnShowWindow(bShow, nStatus);

static bool bOnce = true;

if (bShow && !IsWindowVisible()
&& bOnce)
{
bOnce = false;

WINDOWPLACEMENT *lwp;
UINT nl;

if (AfxGetApp()->GetProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE*)&lwp, &nl))
{
SetWindowPlacement(lwp);
delete[] lwp;
}
}
}
Still same issue

Jochen Arndt 5-Sep-17 3:24am

"the above method its returning old values but gui is positioning as per that values"
Can you try to explain that in another (better) way?

I read that as:
- Returning old values = Data saved at last program exit are read: OK
- But GUI is positioning as per that values = ?
"that" would then refer to the data read which are the correct ones.

Member 13089825 5-Sep-17 3:30am

I read that as:
- Returning old values = Data saved at last program exit are read: OK
- But GUI is positioning as per that values = ? gui is not positioning as per the values
"that" would then refer to the data read which are the correct ones.

Jochen Arndt 5-Sep-17 3:41am

I have updated my solution with code used by one of my applications.
If that does not work too, you have to use the debugger to check if your code reaches the SetWindowPlacement call and which values are set.

Member 13089825 5-Sep-17 3:41am

x and y position is updating correctly but width and height not updating

Jochen Arndt 5-Sep-17 3:45am

See my updated solution.

There x and y (the position) are applied within OnCreate and the size is applied when the window is shown.

Member 13089825 5-Sep-17 3:45am

hi jochen,sorry to trouble you
screen position seems to be remembered correctly, it is the screen size that doesn't get remembered

Jochen Arndt 5-Sep-17 3:47am

Is the screen size not stored correctly in the registry or is it not applied?
Note also that the size is affected by the command. So check that value too.

However, my updated solution should work.

Member 13089825 5-Sep-17 4:57am

Is the screen size not stored correctly in the registry or is it not applied?
its not applied

// save show state
m_nCmdShow = wpl->showCmd;// throwing error like uninitialzed variable wpl used

Jochen Arndt 5-Sep-17 5:32am

I have not posted the code to read the replacement which is indicated by

// Get placement here

You have to insert the code as already used by you (read from registry). Don't forget to delete wpl aftwerwards. And don't call UpdateWindow() when doing that from OnCreate().

Member 13089825 5-Sep-17 6:01am

void CMainFrame::OnClose()
{

WINDOWPLACEMENT wp;
GetWindowPlacement(&wp);
AfxGetApp()->WriteProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE)&wp, sizeof(wp));
CFrameWndEx::OnClose();
}

int CMainFrame::OnCreate(LPCREATESTRUCT lpCreateStruct)
{

if (CFrameWndEx::OnCreate(lpCreateStruct) == -1)
return -1;
WINDOWPLACEMENT *lwp;
// Get placement here
UINT nl;
if (AfxGetApp()->GetProfileBinary(_T("MainFrame"), _T("WP"), (LPBYTE*)&lwp, &nl))
{
m_nCmdShow = lwp->showCmd;// m_nCmdShow i have created locally
// must set this to normal here
lwp->showCmd = SW_SHOWNORMAL;
SetWindowPlacement(lwp);

delete[] lwp;
}

still same issue

Jochen Arndt 5-Sep-17 6:12am

m_nCmdShow must be a member of your CMainFrame class.

Have you implemented CMainFrame::ShowWindowInitial() and called it from InitInstance()?
That is the moment where the size is applied (when calling UpdateWindow() afterwards; you may put the call also into ShowWindowInitial).

As already noted: It is working here.
If you still have problems, you must debug your application; e.g. by checking the actual size settings at various steps.

Member 13089825 5-Sep-17 6:26am

void CMainFrame::ShowWindowInitial()
{
OnShowWindow(m_nCmdShow);// we dont have any function OnShowWindow()right (we have only ShowWindow or OnShowWindow(BOOL bShow, UINT nStatus)
}

Jochen Arndt 5-Sep-17 6:36am

You are right: It must be ShowWindow(int nCmdShow) there, not the OnShowWindow() handler.

Member 13089825 5-Sep-17 6:43am

sorry,i have followed same but its not working for me(size is not updating in gui and position is updating)
sorry for wasting your time

Jochen Arndt 5-Sep-17 6:49am

As already mentioned: Time to debug.
You have to find out where the size is not applied. You can for example check the size before and after calling ShowWindow() by using GetWindowRect() and GetWindowPlacement() and compare with the expected values read from the registry.