How to handle null-able type convert datatable to list

Question

0.00/5 (No votes)

See more:

C#

public static class DataTableToList
   {
       public static List<T> ToList<T>(this DataTable table) where T : class, new()
       {
           try
           {
               List<T> list = new List<T>();

               foreach (var row in table.AsEnumerable())
               {
                   T obj = new T();

                   foreach (var prop in obj.GetType().GetProperties())
                   {
                       try
                       {
                           PropertyInfo propertyInfo = obj.GetType().GetProperty(prop.Name);
                           propertyInfo.SetValue(obj, Convert.ChangeType(row[prop.Name], propertyInfo.PropertyType), null);
                       }
                       catch
                       {
                           continue;
                       }
                   }

                   list.Add(obj);
               }

               return list;
           }
           catch
           {
               return null;
           }
       }
   }

What I have tried:

How to handle null-able type convert datatable to list

Posted 22-Aug-16 3:55am

Member-515487

Updated 22-Aug-16 7:37am

Add a Solution

Comments

Philippe Mori 22-Aug-16 19:02pm

continue is the catch block is useless...

2 solutions

Solution 1

All you need to do is in your existing code, add a line to check if the data row value is null and also if the property of <T> is nullable too:

C#

if(row[prop.Name] == DBNull.Value /* or == null */
   && prop.PropertyType.IsValueType
   && Nullable.GetUnderlyingType(prop.PropertyType) != null)
   // if property is nullable, underlying nullable type will eval as true.
{
    propertyInfo.SetValue(obj, Convert.ChangeType(row[prop.Name], propertyInfo.PropertyType), null);
}

Posted 22-Aug-16 4:24am

njammy

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2016-08-22T06:09:00

try this code,
i am using this for long time.

C#

public static List<T> DataTableToList<T>(DataTable dt) where T : class, new()
{
    List<T> lstItems = new List<T>();
    if (dt != null && dt.Rows.Count > 0)
        foreach (DataRow row in dt.Rows)
            lstItems.Add(ConvertDataRowToGenericType<T>(row));
    else
        lstItems = null;
    return lstItems;
}

private static T ConvertDataRowToGenericType<T>(DataRow row) where T : class,new()
{
    Type entityType = typeof(T);
    T objEntity = new T();
    foreach (DataColumn column in row.Table.Columns)
    {
        object value = row[column.ColumnName];
        if (value == DBNull.Value) value = null;
        PropertyInfo property = entityType.GetProperty(column.ColumnName, BindingFlags.Instance | BindingFlags.IgnoreCase | BindingFlags.Public);
        try
        {
            if (property != null && property.CanWrite)
                property.SetValue(objEntity, value, null);

        }
        catch (Exception ex)
        {
           throw ex;
        }
    }
    return objEntity;
}

How to handle null-able type convert datatable to list

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us