How do I fix my implicit error...

Question

0.00/5 (No votes)

See more:

Using Visual Studio 2015 with VC++

char buffer[100];

CString strTmp = _T("");

strTmp.Format(_T("%s"), buffer); doesn't make no error message.

But after analysing the code, it makes warning "invald parameters transit position.....etc"

Is there any dangerous point of above code?

What I have tried:

In almost of my programs with the moving value from char buffer to CString variable,
I don't know what is error.

Posted 30-Jun-16 1:27am

Member 12330615

Updated 30-Jun-16 2:07am

v2

Add a Solution

2 solutions

Solution 2

In addition to solution 1:

If you need to format a string with a char* string argument, you can specify this in the format by using the h prefix:

char buffer[100] = "A char* string";
CString strTmp;
strTmp.Format(_T("%hs"), buffer)

This will convert the char* string to a wide string during runtime and insert that with Unicode builds. With non-Unicode builds the prefix is ignored.

Posted 30-Jun-16 2:07am

Jochen Arndt

Comments

KarstenK 1-Jul-16 3:36am

Nice, but it makes the code harder to understand because it leads to mixing the string type. And only leads to bugs.

Jochen Arndt 1-Jul-16 3:46am

Thank you.

My intention was not to suggest to do it this way when using a local instance of the buffer.

It is for the cases when having an existing char* string that must be formatted (e.g. passed as parameter to a function, retrieved from a library function call, or read from an ANSI/ASCII file, device, or socket).

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Accepted Answer · 2016-06-30T01:37:00

It is the old ANSI and UNICODE problem.

To avoid I use TCHAR, which brings the preprocessor to use the right char-type.

C++

TCHAR buffer[100];

CString strTmp = _T("");

strTmp.Format(_T("%s"), buffer);

I guess that your compiler will find after this change some errors in accesing the buffer. And it is right: change that too!!!