What Are The Drawback If I Put All Properties In One Modal Class?

Question

0.00/5 (No votes)

See more:

In mvc generally we keep separate class for different properties according to our requirement(as given below). now my question is what are the drawback if i put all properties in one modal class(as given below)?

C#

public class category
{
public int CatId { get; set; }
public string CatName { get; set; }
}

public class subcategory
{
public int subcatId { get; set; }
public string catid { get; set; }
public string subcatname { get; set; }
}

public class item
{
public string itemid { get; set; }
public int catid { get; set; }
public string subcatid { get; set; }
public string item { get; set; }
}

=========== all properties ====

C#

public class allitems
{

public string CatName { get; set; }
public string subcatname { get; set; }
public string itemid { get; set; }
public int catid { get; set; }
public string subcatid { get; set; }
public string item { get; set; }
}

Posted 30-Aug-15 20:02pm

utm

Updated 30-Aug-15 20:34pm

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sinisa Hajnal · Answer 1 · 2015-08-31T23:46:00

Programmatically, you have bigger object to pass around when you need to edit parts of the object (such as category name based on category id).

Logically, you have single blob of properties instead of domain objects that accurately model your app workspace.

This particular situation also shows some design problems (but it may be a requirement so take this considering your own domain):
- you should not have category and subcategory as separate objects (assuming parent - child relationship implicated by subcategory catid property) - they are both categories of various "levels" in a tree
- item could also have multiple categories so you could have List<category> categories; instead of single category (again, depending on the requirements)
- in the item, single category id would take care of sub and main category due to parent-child relationship

Instead (I would) create category like this (standard for C# classes is upper case first letter, full names are also recommended, intellisense takes care of extra typing) :

C#

public class Category {
/* since you're in a class named Category, you don't need property CategoryId, just Id suffices (this is personal preference so feel free to disregard this) :)
*/

    public int Id { get; set; }
    public int ParentId { get; set; }
    public string Name { get; set; }
}

public class Item {
/* since you're in a class named Item, you don't need property ItemId, just Id suffices (this is personal preference so feel free to disregard this) :)
*/
int Id ;
string Name;
string OtherItemProperties...

List<category> categories;
}
</category>

Now you can have any kind of tree structure between categories and subcategories, not just one category and one subcategory.

F-ES Sitecore · Answer 2 · 2015-09-01T00:01:00

The issue is that you don't know what your model actually is. Given all views see all properties you don't know which ones are going to be populated and available to you. Likewise if you need to make a change to your model it is harder to know which views are affected.

This is assuming you are using a single model for all your views. If you actually mean that one particular view needs three items sent to it then there is nothing inherently wrong with creating a new model for that view that has each of the items as a property.

What Are The Drawback If I Put All Properties In One Modal Class?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0