invalid column name in windows forms application how to solve it?

Question

0.00/5 (No votes)

See more:

in button click event

C#

private void button3_Click(object sender, EventArgs e)
        {
            SqlStr = String.Format("insert into employee(empid,ename,salary,deptno) values ({0},{1},{2},{3})", textBox1.Text, textBox2.Text, textBox3.Text, textBox4.Text);
            ExecuteDML();
            button3.Enabled = false;
        }

in command exection method i have written the code like this

C#

private void ExecuteDML()
{
    DialogResult d = MessageBox.Show("Are you sure of executing the below SQl Statement?\n\n" + SqlStr, "Confirmation", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
    if(d==DialogResult.Yes)
    {
        cmd.CommandText = SqlStr;
        int Count = cmd.ExecuteNonQuery();
        if(Count>0)
        {
            MessageBox.Show("Statement executed Successfully");
        }
        else
        {
            MessageBox.Show("Statement failed execution");
        }
        LoadData();
    }
}

but i am getting the invalid column name error while executing the code.
someone help me thanks.

Posted 16-Jul-15 20:32pm

raxhemanth

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Answer 1 · 2015-07-16T20:36:00

Basically the error comes because you add the values from the text boxes without having starting and ending '.

However the bigger problem is that you don't use parameters.

Correct way to fix this is to use SqlParameter[^]
So instead of

C#

SqlStr = String.Format("insert into employee(empid,ename,salary,deptno) values ({0},{1},{2},{3})", textBox1.Text, textBox2.Text, textBox3.Text, textBox4.Text);
ExecuteDML();

You should have something like

C#

SqlStr = "insert into employee(empid,ename,salary,deptno) values (@empid,@ename,@salary,@deptno)");
ExecuteDML();

and then using AddWithValue[^] you add the parameters to the parameter collection of the command to be used.