C / C++ / MFC

Re: Shell Icon not right?

29-Aug-04 17:35

Hi Coders

I have a weird problem. I'm trying to emulate Explorer's TreeView and I can't seem to load the correct Shell icons on Windows XP. Some icons do load correctly, but "My Computer", "My Network Places" and "Control Panel" don't load (ie. they load the default unknown icon). The code I use for ALL icons is found below:

// Retreive the shell's system icon index
SHFILEINFO shInfo;
ZeroMemory(&shInfo, sizeof(shInfo));
if(SHGetFileInfo((LPCTSTR)Pidl, 0, &shInfo, sizeof(shInfo),
SHGFI_PIDL | SHGFI_ICON | SHGFI_SHELLICONSIZE | SHGFI_SMALLICON | SHGFI_SYSICONINDEX))
{
ImageIndex = shInfo.iIcon;
}

Does anyone know why some icons work but others don't?

Michael Dunn29-Aug-04 17:50

Michael Dunn

29-Aug-04 17:50

How are you getting the PIDL for My Computer and the other ones? Also, I don't think SHGFI_SHELLICONSIZE and SHGFI_SMALLICON make sense together.

--Mike--
Personal stuff:: Ericahist | Homepage
Shareware stuff:: 1ClickPicGrabber | RightClick-Encrypt
CP stuff:: CP SearchBar v2.0.2 | C++ Forum FAQ
----
#include "witty-quote.h"

Re: Shell Icon not right?

Anonymous29-Aug-04 20:57

29-Aug-04 20:57

The Pidl comes from enumerating an IShellFolder. This is basically the code I used (with minor modifications to reduced space):-

void TShellTreeView::Enumerate(IShellFolder* ParentFolder)
{
LPITEMIDLIST Pidl = NULL;
LPENUMIDLIST Enum = NULL;
if(ParentFolder->EnumObject(Control->Handle, SHCONTF_FOLDERS, &Enum) != NOERROR)
{
while(SUCCEEDED(Enum->Next(1, &Pidl, 0)) == true)
{
if(Pidl == NULL)
break;

// Extract shell icon using SHGetFileInfo() ...
// See original post for code
}

// Free Pidl using global malloc
}

// Release Enum
}

Hope this helps

Disable Window Resizing

Anonymous29-Aug-04 17:23

Re: Disable Window Resizing

29-Aug-04 17:23

I have a window that I dont want people to resize. I have set up the size I want by changing the cx and cy values in the CREATESTRUCT and would like it to stay this size at all times. Just wondering how I might do that. Is it something in the CREATESTRUCT? I'm using VC++ 6, MFC doc/view.

Thanks a lot! Smile | :)

Michael Dunn29-Aug-04 17:33

Michael Dunn

29-Aug-04 17:33

See the FAQ
7.7 How can I make my main frame window non-resizable?[^]

--Mike--
Personal stuff:: Ericahist | Homepage
Shareware stuff:: 1ClickPicGrabber | RightClick-Encrypt
CP stuff:: CP SearchBar v2.0.2 | C++ Forum FAQ
----
You cannot stop me with paramecium alone!

Re: Disable Window Resizing

Anonymous29-Aug-04 21:48

29-Aug-04 21:48

in the PreCreateWindow function
write:

cs.style &= ~WS_THICKFRAME;

WS_THICKFRAME is the flag for enabling sizing
so ...... disable it

MemDC !!!

Andre Massada29-Aug-04 9:58

29-Aug-04 9:58

I use the celebre memDC to avoid flickering in my DIALOG app.
I got the fickering out, but if i set the return value of OnEraseBkgnd() to false or true, the whole background is set to black, and on move it refreshes window with the contents of the window below. Any suggestion will be great.

NOTE: in my app i use a button-class that also uses the memDC. Could those two interfere in some way ?

PJ Arends29-Aug-04 10:30

29-Aug-04 10:30

Andre Massada wrote:
I use the celebre memDC to avoid flickering

Are you refering to http://www.codeproject.com/gdi/flickerfree.asp[^] or did you roll your own?

I wrote a tool a while ago that works great for figuring out what is going on with memory DCs and bitmaps. Check it out at http://www.codeproject.com/tools/imageviewer.asp[^]

"You're obviously a superstar." - Christian Graus about me - 12 Feb '03

"Obviously ??? You're definitely a superstar!!!" mYkel - 21 Jun '04

Within you lies the power for good - Use it!

Andre Massada29-Aug-04 10:45

29-Aug-04 10:45

http://www.codeproject.com/gdi/flickerfree.asp[^] - that's the one

Andre Massada29-Aug-04 11:45

29-Aug-04 11:45

I've tried it, but it tells me that ShowDC(memDC) is not defined, even if
i added the macro definition and the include line.
My OnPaint() looks like below. Is there anything worng with it ?

void CDecDlg::OnPaint()
{
if (IsIconic())
{
//CPaintDC dc(this); // device context for painting

CRect rect;
GetClientRect(&rect);
CPaintDC dc(this);
CRect rcClient;
GetClientRect(rcClient);
dc.SetMapMode(MM_HIENGLISH);
CMemDC pDC(&dc);

SendMessage(WM_ICONERASEBKGND, reinterpret_cast<wparam>(dc.GetSafeHdc()), 0);

// Center icon in client rectangle
int cxIcon = GetSystemMetrics(SM_CXICON);
int cyIcon = GetSystemMetrics(SM_CYICON);
int x = (rect.Width() - cxIcon + 1) / 2;
int y = (rect.Height() - cyIcon + 1) / 2;

// Draw the icon
pDC.DrawIcon(x, y, m_hIcon);
}
else
{
CTrayDialog::OnPaint();
}
//MovieWindowed.Repaint();
}

... well ?

PJ Arends29-Aug-04 13:03

29-Aug-04 13:03

Andre Massada wrote:
I've tried it, but it tells me that ShowDC(memDC) is not defined, even if
i added the macro definition and the include line.

Are you including it in the *.cpp file that you called ShowDC() from? There is no reason that I can think of the ShowDC() would not be defined.

I use it all the time with absolutely no problems.

Andre Massada wrote:
... well ?

Other than the fact that it does absolutely nothing but call CTrayIcon::OnPaint()?

Put a breakpoint somewhere in your code and try to trace it. You will find it is never called.

"You're obviously a superstar." - Christian Graus about me - 12 Feb '03

"Obviously ??? You're definitely a superstar!!!" mYkel - 21 Jun '04

Within you lies the power for good - Use it!

Andre Massada29-Aug-04 20:39

29-Aug-04 20:39

I know .. it makes no sens for either why it says that is not defined from what i've looked.
You seem to know your way around these drawing things. Do you know some articles or something usefull about what should i do in "OnPaint " (i mean i have absolutely no clue on what should i write there). Any tip will be usefull. Thanks alot in advance.

Andre Massada31-Aug-04 9:42

31-Aug-04 9:42

Maybe PJ Arends could give us a hint ?

KaЯl29-Aug-04 22:46

KaЯl

29-Aug-04 22:46

To avoid flickering, you have to set the return value of OnEraseBkgnd to FALSE: this will avoid your dialog to be erased by the MFC framework, which causes the flickering.
But once you return FALSE on OnEraseBkgnd, then you have to draw yourself the background of your dialog box when painting it.

Typically the OnPaint method wil begin like this (in the general case):

void CMyWnd::OnPaint()
{
	CPaintDC dc(this); // device context for painting
	
	// Draw
	CRect clipRect;
	
	// no need to draw if the clipping rect is empty
	if(dc.GetClipBox(&clipRect) == NULLREGION)
		return;
	
	CMemDC pDC(&dc, clipRect);
	// painting the background
	pDC->FillSolidRect(clipRect, ::GetSysColor(COLOR_ACTIVEBORDER));
	// begin the painting of the foreground
	...
}

Note: you should never call directly the base class method during OnPaint: the way to do it is to use the function DefWindowProc

DefWindowProc(WM_PAINT, (WPARAM) pDC->GetSafeHdc(), 0);

Собой остаться дольше...

Andre Massada30-Aug-04 5:14

30-Aug-04 5:14

Thanks ... so that's what i have to do. That i understud. What i did not get is 2 things:
1. I don't need to init the clipRect with a GetClientRect(clipRect) ?
2. Should i use DefWindowProc(WM_PAINT, (WPARAM) pDC->GetSafeHdc(), 0) in a MFC application ? I've tested and saw that it needs no declaration, but where do i write the actual code for it?(the help for this is like 1/2page)
(BTW ... with your code on OnPaint and the return value of OnEraseBkgnd set to FALSE the flickering still persists)
Please let me know if you have ANY ideea.

KaЯl30-Aug-04 5:38

KaЯl

30-Aug-04 5:38

1- The method CDC::GetClipBox will give you the rectangle to draw. The clipping region will be equal to the client area if everything needs to be redrawn.

2- I use DefWindowProc in some MFC code, like in a class derived from CListCtrl. You will also find this function in the sources of the MFC library. DefWindowProc is part of the Win32 API,and enables to call the default processing for the message.

Andre Massada wrote:
the flickering still persists
If the flickering still occurs, it could mean that something else is drawing on your dialog box. Another question is, what is flickering, is it the dialog box itself or the controls embedded in the dialog box?

Собой остаться дольше...

Andre Massada30-Aug-04 9:02

30-Aug-04 9:02

KaЯl wrote:
what is flickering, is it the dialog box itself or the controls embedded in the dialog box?

No, it's not the dialog box that flickers, some of the contrlols(picture control, some text controls). Do i have to control the flickering for each of them ? (the weird part is that if i do nothing on my OnPaint and return FALSE on OnEraseBkgnd, the background does not refreshes, but ALL the flickering is gone and the controls are OK)

Having trouble with arrays.

KaЯl31-Aug-04 3:16

KaЯl

31-Aug-04 3:16

So, you were right, the problem isn't that simple! The problem comes from the controls embedded in the dialog box, and how to redraw them, knowing than some like the static controls don't draw the background by themselves.
If we want to do the painting of the dialog box through the CmyDialog::OnPaint method, then we have to paint everything by ourselves (forget what I said about DefWindowProc, I was wrong, the MFC architecture doesn't use the WPARAM of the WM_PAINT message, it won't use the DC we are providing so we can't use the base class), the dialog box and its child windows. Sadly, I didn't found yet an easy solution to indicate to the child windows how to use the MemDC we build Sigh | :sigh:

Собой остаться дольше...

nigma_x29-Aug-04 9:18

nigma_x

29-Aug-04 9:18

I'm using Visual C++.net 2002. I'm using CIni in an MFC from this site. http://www.codeproject.com/cpp/CIni.asp#xx909443xx. The problem I'm having is I Can declare the CStringArray in the function. Pass it to GetKeyNames. I'm unable to access any of the elements in the Array. Don't know If I'm declaring the array correct or not. I've tried to declare the CStringArray variable using the variable wizard. This allows me to access the elements but I'm unable to pass the array to GetKeyNames. Sort of new with C++ MFC. Any help would be great. This is the code so far. What I'm tring to do is get a list of the Keys in a section and display them in a Edit Control. Tried to get an anwser from the site forum but no response. Any help would be great.

void CRunProgramDlg::OnBnClickedOk()<br />
{<br />
//// TODO: Add your control notification handler code here<br />
<br />
<br />
<br />
<br />
<br />
LPTSTR Current = NULL;<br />
DWORD dwBuffer = 100;<br />
CString ArrayString;<br />
<br />
//CStringArray Declared with the variable wizard and using <br />
//Using SetSize to set the size of the array<br />
m_FindKey.SetSize(32,0);<br />
<br />
//CStringArray declared in the function set array to 1<br />
CStringArray ProfileSearch[1];<br />
<br />
CIni ini;<br />
ini.SetPathName("C:\\amrtemp\\file2.ini");<br />
ini.GetKeyNames("Routing Indicator",Current,dwBuffer);<br />
<br />
//When using this CStringArray in GetKeyNames recieve error<br />
// error C2664: 'void CIni::GetKeyNames(LPCTSTR,CStringArray *) <br />
// const' : cannot convert parameter 2 from 'CStringArray' to 'CStringArray *<br />
ini.GetKeyNames("Routing Indicator",m_FindKey);<br />
<br />
//When using this CStringArray in ProfileSearch I don't recieve an error here<br />
ini.GetKeyNames("Routing Indicator",ProfileSearch);<br />
<br />
<br />
<br />
<br />
<br />
//Don't know if this works. Wont'compile after ini.GetKeyNames <br />
//("RoutingIndicator",m_FindKey);<br />
ArrayString = m_FindKey.GetAt(1);<br />
<br />
//Recieve error C2679: binary '=' : no operator found which takes a right-hand<br />
//operand of type 'CStringArray' (or there is no acceptable conversion)<br />
ArrayString = ProfileSearch[1];<br />
<br />
m_strBrowse = ini.GetString("Routing Indicator", ArrayString,"Dev");<br />
<br />
<br />
<br />
UpdateData(FALSE);<br />

I'm at a loss I don't think I'm declaring the variables correctly.

Re: Having trouble with arrays.

PJ Arends29-Aug-04 9:34

Re: Having trouble with arrays.

29-Aug-04 9:34

nigma_x wrote:
Tried to get an anwser from the site forum but no response.

Patience young grasshopper.

You posted on friday afternoon. The author is probably away for the weekend.

nigma_x wrote:
//CStringArray declared in the function set array to 1
CStringArray ProfileSearch[1];

//When using this CStringArray in ProfileSearch I don't recieve an error here
ini.GetKeyNames("Routing Indicator",ProfileSearch);

ProfileSearch is a pointer to an array of one CStringArray objects.

nigma_x wrote:
//When using this CStringArray in GetKeyNames recieve error
// error C2664: 'void CIni::GetKeyNames(LPCTSTR,CStringArray *)
// const' : cannot convert parameter 2 from 'CStringArray' to 'CStringArray *
ini.GetKeyNames("Routing Indicator",m_FindKey);

You need to pass a pointer. try

ini.GetKeyNames("Routing Indicator", <font color=#ff0000>&</font>m_FindKey);

"You're obviously a superstar." - Christian Graus about me - 12 Feb '03

"Obviously ??? You're definitely a superstar!!!" mYkel - 21 Jun '04

Within you lies the power for good - Use it!

nigma_x30-Aug-04 3:54

nigma_x

30-Aug-04 3:54

Thank you for the help.

Registry question

Andre Massada29-Aug-04 8:35

29-Aug-04 8:35

Can anyone give me some tips about saving some variables in registry and retrieve them afterwards ?

Re: Registry question

PJ Arends29-Aug-04 8:53

29-Aug-04 8:53

http://www.codeproject.com/system/#Registry[^]

"You're obviously a superstar." - Christian Graus about me - 12 Feb '03

"Obviously ??? You're definitely a superstar!!!" mYkel - 21 Jun '04

Within you lies the power for good - Use it!

Re: Registry question

Andre Massada29-Aug-04 9:53