C / C++ / MFC

Re: To Christian Graus & Nish

28-Nov-01 7:21

Hello, it's me again.

I did all your advises but still have nothing changes ...
If it's possible, can you, please look my code, where is mistake?

all best ..
-----------------------------

void CRegListDlg::QueryKey(HWND hDlg, HKEY hKey)
{
CHAR achKey[MAX_PATH];
CHAR achClass[MAX_PATH] = ""; // buffer for class name
DWORD cchClassName = MAX_PATH; // length of class string
DWORD cSubKeys; // number of subkeys
DWORD cbMaxSubKey; // longest subkey size
DWORD cchMaxClass; // longest class string
DWORD cValues; // number of values for key
DWORD cchMaxValue; // longest value name
DWORD cbMaxValueData; // longest value data
DWORD cbSecurityDescriptor; // size of security descriptor
FILETIME ftLastWriteTime; // last write time

DWORD i, j;
DWORD retCode, retValue;

CHAR achValue[MAX_VALUE_NAME];
DWORD cchValue = MAX_VALUE_NAME;
CHAR achBuff[80];

// Get the class name and the value count.
RegQueryInfoKey(hKey, // key handle
achClass, // buffer for class name
&cchClassName, // length of class string
NULL, // reserved
&cSubKeys, // number of subkeys
&cbMaxSubKey, // longest subkey size
&cchMaxClass, // longest class string
&cValues, // number of values for this key
&cchMaxValue, // longest value name
&cbMaxValueData, // longest value data
&cbSecurityDescriptor, // security descriptor
&ftLastWriteTime); // last write time

// SetDlgItemText(hDlg, IDE_CLASS, achClass);
// SetDlgItemInt(hDlg, IDE_CVALUES, cValues, FALSE);

::SendMessage(GetDlgItem(hDlg, m_list),
LB_ADDSTRING, 0, (LONG) "..");

DWORD dwLength = MAX_PATH;

// Enumerate the child keys, until RegEnumKeyEx fails. Then
// get the name of each child key and copy it into the list box.

SetCursor(LoadCursor(NULL, IDC_WAIT));
for (i = 0, retCode = ERROR_SUCCESS;
retCode != ERROR_NO_MORE_ITEMS; i++)
{
retCode = RegEnumKeyEx(hKey,
i,
achKey,
&dwLength,
NULL,
NULL,
NULL,
&ftLastWriteTime);
if (retCode != (DWORD)ERROR_NO_MORE_ITEMS)
{
::SendMessage(GetDlgItem(hDlg, m_list),
LB_ADDSTRING, 0, (LONG) achKey);
}

dwLength = MAX_PATH;
}
SetCursor(LoadCursor (NULL, IDC_ARROW));

// Enumerate the key values.
SetCursor(LoadCursor(NULL, IDC_WAIT));

if (cValues)
{
for (j = 0, retValue = ERROR_SUCCESS;
j < cValues; j++)
{
cchValue = MAX_VALUE_NAME;
achValue[0] = '\0';
retValue = RegEnumValue(hKey, j, achValue,
&cchValue,
NULL,
NULL, // &dwType,
NULL, // &bData,
NULL); // &bcData

if (retValue != (DWORD) ERROR_SUCCESS &&
retValue != ERROR_INSUFFICIENT_BUFFER)
{
wsprintf (achBuff,
"Line:%d 0 based index = %d, retValue = %d, "
"ValueLen = %d",
__LINE__, j, retValue, cchValue);
// MessageBox (m_hWnd, achBuff, "Debug", MB_OK);
}

achBuff[0] = '\0';

// Add each value to a list box.
if (!lstrlen(achValue))
lstrcpy(achValue, "<no name="">");
wsprintf(achBuff, "%d) %s ", j, achValue);
::SendMessage(GetDlgItem(hDlg,m_list2),
LB_ADDSTRING, 0, (LONG) achBuff);
}
}
SetCursor(LoadCursor(NULL, IDC_ARROW));
}

-------------------------------------------------
and it makes this mistake
: error C2664: 'void __thiscall CWnd::GetDlgItem(int,struct HWND__ ** ) const' : cannot convert parameter 1 from 'struct HWND__ *' to 'int'
This conversion requires a reinterpret_cast, a C-style cast or function-style cast

each time when it goes to "SendMessage" ..

Confused | :confused:

==============
www.design.kg

C^hris L^osinger28-Nov-01 7:46

C^hris L^osinger

28-Nov-01 7:46

GetDlgItem doesn't take a handle to a window as its first parameter, it takes a control ID (ID_MY_BUTTON or something).

-c

Smaller Animals Software, Inc.

Re: Who are these guys?

Masaaki Onishi28-Nov-01 9:47

28-Nov-01 9:47

Hello, the codegurus around the world;)

The poster simply misunderstands between CWnd function and Windows API function.

Windows API

HWND GetDlgItem(
  HWND hDlg,       // handle to dialog box
  int nIDDlgItem   // control identifier
);

And, MFC

CWnd* GetDlgItem( int nID ) const;
void CWnd::GetDlgItem( int nID, HWND* phWnd ) const;

Also, if the poster wants to use WinAPI function in MFC,
we need the global resultion ::GetDlgItem(...); Roll eyes | :rolleyes:

Please, don't send me your email about your questions directly.
Have a nice day!
Sonork - 100.10571:vcdeveloper Wink | ;)

-Masaaki Onishi-

Re: Who are these guys?

Karavaev Denis28-Nov-01 17:20

Re: To Christian Graus & Nish

28-Nov-01 17:20

Yah! And as you can see exactly like this I called this function:
::GetDlgItem

Or I did smf wrong?

==============
www.design.kg

Karavaev Denis28-Nov-01 17:23

Re: OK, This is a tricky one!

28-Nov-01 17:23

I found it here:
http://msdn.microsoft.com/library/en-us/sysinfo/regapi_0tq1.asp?frame=true
is it MSDN mistake, that GetDlgItem take a handle to a window as its first parameter?

==============
www.design.kg

Masaaki Onishi28-Nov-01 17:34

I think, I'm an idiot ....

28-Nov-01 17:34

Hello, the codegurus around the world.;)

First of all, you must understand the dif between C and C++ code.

In msdn example, this is written by C code.
In this case, we don't need the global resolution "::".

VOID QueryKey(HWND hDlg, HANDLE hKey)
{
   .....
   //GetDlgItem means the Windows API function.
   SendMessage(GetDlgItem(hDlg, IDL_LISTBOX), 
        LB_ADDSTRING, 0, (LONG) ".."); 
   ......
}

However, if you use this one in MFC,

void CMyDialog::QueryKey(...)
{
   .....
   //In this case, this->GetDlgItem(...) is called.
  // this means CMyDialog's pointer.
  // So, you got the compiler error!
   SendMessage(GetDlgItem(hDlg, IDL_LISTBOX), 
        LB_ADDSTRING, 0, (LONG) ".."); 
   ......
   //As a result, this is right.
   //
   .....
   SendMessage(::GetDlgItem(hDlg, IDL_LISTBOX), 
        LB_ADDSTRING, 0, (LONG) ".."); 
   ......
   or GetDlgItem(IDL_LISTBOX);

}

Please, don't send me your email about your questions directly.
Have a nice day!
Sonork - 100.10571:vcdeveloper Wink | ;)

-Masaaki Onishi-

Karavaev Denis28-Nov-01 17:47

Re: I think, I'm an idiot ....

28-Nov-01 17:47

Like this:

::SendMessage(::GetDlgItem(m_hWnd, m_list),
LB_ADDSTRING, 0, (LONG) "..");

The result is:
: error C2664: 'GetDlgItem' : cannot convert parameter 2 from 'class CString' to 'int'
No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

==============
www.design.kg

Masaaki Onishi28-Nov-01 18:44

Re: I think, I'm an idiot ....

28-Nov-01 18:44

Hello, the codegurus around the world.;)

::SendMessage(::GetDlgItem(m_hWnd, m_list),
LB_ADDSTRING, 0, (LONG) "..");

How did you declare m_list? CString m_list?
GetDlgItem has the second parameter as ID of the control.
So, this should take something like IDC_LIST1.
But, are you sure that you add ListBox (ID: IDC_LIST1) on your dialog box?

Simply copying the code never works unless you have enough knowledge
of both MFC and Win32 program in this case. Cool | :cool:

Or, to be sure, you add ListBox on your dialog box.
This works.
If you declare CListBox m_list;

::SendMessage(m_list.m_hWnd, LB_ADDSTRING, 0, (LONG) "..");
or
m_list.AddString ("..");
or
m_list.SendMessage(LB_ADDSTRING, 0, (LONG)"..");

Please, don't send me your email about your questions directly.
Have a nice day!
Sonork - 100.10571:vcdeveloper Wink | ;)

-Masaaki Onishi-

Karavaev Denis28-Nov-01 19:01

Re: I think, I'm an idiot ....

28-Nov-01 19:01

Oh, ÎÃÐÎÌÍÎÅ ÑÏÀÑÈÁÎ!
thats in my language mean THANK YOU VERY MUCH! Masaaki Smile | :)

==============
www.design.kg

Nish Nishant28-Nov-01 18:45

Nish Nishant

28-Nov-01 18:45

"::GetDlgItem(m_hWnd, m_list)" <--- error line

The second parameter should be the control id.
replace m_list with the control id,something like IDLIST01

Nish

Sonork ID 100.9786 voidmain
www.busterboy.org
If you don't find me on CP, I'll be at Bob's HungOut

Re: Ooops, I forgot to say...

Masaaki Onishi29-Nov-01 7:03

CFileDialog and CFile::Open

29-Nov-01 7:03

Hello, the codegurus around the world.;)

Yesterday, I forgot to say that if we use the class wziard... Dead | X|

Simply if we declare CListBox listbox, listbox will never get the right stuff.
If we declare CListBox listbox by the class wizard, DoDataExchange(...) assign
the right stuff to listbox.

Or, we can use Create or CreateEx function like listbox.Create(...)
Dead | X|

Please, don't send me your email about your questions directly.
Have a nice day!
Sonork - 100.10571:vcdeveloper Wink | ;)

-Masaaki Onishi-

28-Nov-01 5:34

RobJones28-Nov-01 5:23

28-Nov-01 5:23

Hello,
In the following code, I open a MP3 and read the last 128 bytes of information (to see if the MP3 has a ID3 tag).. This code works fine most of the time.. I click the open button on my app which calls this function.. it works 95% of the time, but every now and then it gives me an error.. "an unnamed file was not found", the file does exist and its in the same directory as all the previous files that I have opened.. if I move or copy the file to another location and try to open it, it opens fine.. weird! Any ideas why??

CFileDialog MP3(TRUE,NULL,NULL,OFN_HIDEREADONLY,"MP3 Files (*.mp3)|*.mp3|");
	
	if(MP3.DoModal() == IDOK)
	{
		strPath = MP3.GetPathName();
		
		ID3TAG.Open(strPath, CFile::modeRead);
		ID3TAG.Seek(-128,CFile::end);
		ID3TAG.Read(tagData,128); //after this line I do a bunch of other stuff with the data..

Thanks,
Rob

Nish Nishant28-Nov-01 5:26

Nish Nishant

28-Nov-01 5:26

perhaps the file is open by some other process or thread already?

Nish

Sonork ID 100.9786 voidmain
www.busterboy.org
If you don't find me on CP, I'll be at Bob's HungOut

RobJones28-Nov-01 5:38

28-Nov-01 5:38

It shouldn't be open by any other processes. It's on my local machine, I don't have any other apps that are using the file and I don't have any shares open on my PC. I wonder if the strPath string is getting corrupted some how.. I'll do some traces.

If you have any other ideas please let me know.

Thanks!!

Rob

RobJones28-Nov-01 6:35

28-Nov-01 6:35

It appears that the CFile::Seek function is throwing the error.. Any ideas why? It's like it can't find the end of the file. Is there any trouble shooting methods that I can use to determine the cause of the exception?

Thanks again for you help!
Rob

RobJones28-Nov-01 9:19

28-Nov-01 9:19

I don't usually reply to my own msg's but I figured everything out.. so disregard my last few posts..

Thanks,

Rob

28-Nov-01 14:27

Are you sure, that the file is opened properly ???

For a better error description you might use SDK functions CreateFile, ReadFile, CloseHandle and GetLastError instead of mfc.

And perhaps a work-around:
Get the file length, move to byte position (FileLength-128) from start, read the last lines ... But to be honest, I don`t believe that it is the Seek which really causes the trouble here...

Regards, Marco

GetDiskFreeSpaceEx

RickyC28-Nov-01 5:22

RickyC

28-Nov-01 5:22

Hy everyone,

I'm tryng to do an application that show in some window the current amount of memory in the user's hard disc. But when the user is using win 95 before OSR2 the function GetDiskFreeSpaceEx must be replaced by GetDiskFreeSpace, and the MSDN Library tell's me to "you should dynamically link to it via GetProcAddress"... I do everything they tell me to do... but in win 95 my program do not work...
causes an error on kernel32.dll that can't find de GetDiskFreeSpaceExA... please, if someone can help me it's will be great!
I'll post an part of my code that I do the implementation of the MSDN Library:

P_GDFSE pGetDiskFreeSpaceEx = NULL;
pGetDiskFreeSpaceEx = (P_GDFSE)GetProcAddress (GetModuleHandle ("kernel32.dll"),"GetDiskFreeSpaceExA");
if(pGetDiskFreeSpaceEx)
{
fresult = GetDiskFreeSpaceEx (windowsDir,
(PULARGE_INTEGER)&FreeBytesToCaller,
(PULARGE_INTEGER)&TotalBytes,
(PULARGE_INTEGER)&FreeBytes);

m_strDirSistema = _T( windowsDir );
m_dwQuotaLivreUsuario = /*(DWORD*/FreeBytesToCaller / MEGABYTE; // this lines given
- me warnings of conversion but it's work correctly m_dwEspacoTotal = /*(DWORD)*/TotalBytes / MEGABYTE;
m_dwEspacoLivre = /*(DWORD)*/FreeBytes /MEGABYTE;
}
thanks all, for the attention!
cheers!!
and sorry my english, I'm brazilian Smile | :)

Jon Hulatt28-Nov-01 5:47

Jon Hulatt

28-Nov-01 5:47

You say that "MSDN Library tell's" [you to] "dynamically link to it via GetProcAddress"

But in your code, you're trying to dynamically link to GetDiskFreeSpaceExA, not GetDiskFreeSpace.

Sorry to dissapoint you all with my lack of a witty or poignant signature.

Nish Nishant28-Nov-01 5:53

Nish Nishant

28-Nov-01 5:53

RickyC wrote:
and the MSDN Library tell's me to "you should dynamically link to it via GetProcAddress"...

It does nothin of that sort

It says "To determine whether GetDiskFreeSpaceEx is available, call the LoadLibrary or LoadLibraryEx function to load the KERNEL32.DLL file, then call the GetProcAddress function to obtain an address for GetDiskFreeSpaceEx. If GetProcAddress fails, or if GetDiskFreeSpaceEx fails with the ERROR_CALL_NOT_IMPLEMENTED code, use the GetDiskFreeSpace function instead of GetDiskFreeSpaceEx"

so since you are sure you are on pre-osr2 win 95 dont bother using the GetDiskFreeSpaceEx call and stick to using GetDiskFreeSpace

Nish

Sonork ID 100.9786 voidmain
www.busterboy.org
If you don't find me on CP, I'll be at Bob's HungOut

RickyC28-Nov-01 6:19

RickyC

28-Nov-01 6:19

Hy,
I'm new to MFC... and don't know much...
but in my MSDN Library (january 2001) has something like this:
/*
Use GetDiskFreeSpaceEx if available; otherwise, use
GetDiskFreeSpace.
Note: Since GetDiskFreeSpaceEx is not in Windows 95 Retail, we
dynamically link to it and only call it if it is present. We
don't need to call LoadLibrary on KERNEL32.DLL because it is
already loaded into every Win32 process's address space.
*/
pGetDiskFreeSpaceEx = (P_GDFSE)GetProcAddress (
GetModuleHandle ("kernel32.dll"),
"GetDiskFreeSpaceExA");
if (pGetDiskFreeSpaceEx)
{
fResult = pGetDiskFreeSpaceEx (pszDrive,
(PULARGE_INTEGER)&i64FreeBytesToCaller,
(PULARGE_INTEGER)&i64TotalBytes,
(PULARGE_INTEGER)&i64FreeBytes);
if (fResult)
{

}
}
else
{
fResult = GetDiskFreeSpace (pszDrive,
&dwSectPerClust,
&dwBytesPerSect,
&dwFreeClusters,
&dwTotalClusters);
if (fResult)
{
//some code that I'll not put because the space in this page
}
}

if (!fResult)
printf ("error: %lu: could not get free space for \"%s\"\n",
GetLastError(), argv[1]);
}
I Just try to follow this...
and is not working... sorry if I'm doing something stupid
:\

Michael Dunn28-Nov-01 8:34

Michael Dunn

28-Nov-01 8:34

Download the latest Platform SDK and #include <newapis.h>. That header has wrappers for GetDiskFreeSpaceEx() and other APIs that handle all that linking nonsense for you. Smile | :)

--Mike--
http://home.inreach.com/mdunn/
While I can't be correct on all matters, I can make the reassuring claim that where I am inaccurate, I am at least definitively inaccurate.
Heart | [heart]

your

with

and

Sonork - 100.10414 AcidHelm

Test out a prerelease build of my Hotfix Checker v2.0! (1