Re: inserting data into Access using C#?? - C# Discussion Boards

5-Dec-03 2:47

Hi,

I am trying to learn ADO.net using C# and I keep running into problems trying to insert data into my Access Database: data.mdb.

here is my code:

<br />
		// Database Variables<br />
		private string connectionStr = @"Jet OLEDB:Global Partial Bulk Ops=2;Jet OLEDB:Registry Path=;Jet OLEDB:Database Locking Mode=1;Data Source=""C:\data.mdb"";Jet OLEDB:Engine Type=5;Provider=""Microsoft.Jet.OLEDB.4.0"";Jet OLEDB:System database=;Jet OLEDB:SFP=False;persist security info=False;Extended Properties=;Mode=Share Deny None;Jet OLEDB:Encrypt Database=False;Jet OLEDB:Create System Database=False;Jet OLEDB:Don't Copy Locale on Compact=False;Jet OLEDB:Compact Without Replica Repair=False;User ID=Admin;Jet OLEDB:Global Bulk Transactions=1";<br />
		private string selectStr = "Select id, date, day, time, comments, timeout, status, process from data";<br />
<br />
		private System.Data.DataSet myDataSet;<br />
		private System.Data.OleDb.OleDbConnection myConnection;<br />
		private System.Data.OleDb.OleDbDataAdapter myDataAdapter;<br />
		private System.Data.OleDb.OleDbCommandBuilder myCmdBuilder;<br />
		<br />
		private System.Data.OleDb.OleDbCommand mySelectCmd;<br />
<br />
		public Schedule()<br />
		{          <br />
			this.InitilizeDb();<br />
			this.PopulateDataSet();<br />
		}<br />
<br />
		private OleDbConnection ConnectDb()<br />
		{<br />
			return new OleDbConnection(connectionStr);<br />
		}<br />
<br />
		public void InitilizeDb()<br />
		{<br />
			myDataAdapter = new OleDbDataAdapter();<br />
			myCmdBuilder = new OleDbCommandBuilder(myDataAdapter);<br />
			myDataSet = new DataSet();<br />
		}<br />
<br />
		private void PopulateDataSet()<br />
		{<br />
			// get the connection object<br />
			myConnection = (OleDbConnection) this.ConnectDb();<br />
<br />
			// Initilize the Select Command<br />
			mySelectCmd = new OleDbCommand(selectStr, myConnection);<br />
<br />
			// Define that the Select Command is an SQL statement<br />
			mySelectCmd.CommandType = CommandType.Text;<br />
<br />
			try<br />
			{<br />
				myConnection.Open();<br />
<br />
				myDataAdapter.SelectCommand = mySelectCmd;<br />
<br />
				// Populate the DataSet from the "data" table<br />
				myDataAdapter.Fill(myDataSet,"data");<br />
			}<br />
			finally<br />
			{<br />
				myConnection.Close();<br />
			}<br />
		}<br />
<br />
		public string InsertSchedule(string date, string day, string time, string process,<br />
			string comments, string timeout, string status)<br />
		{<br />
			// get the connection object<br />
			myConnection = (OleDbConnection) this.ConnectDb();<br />
<br />
			try<br />
			{<br />
				myConnection.Open();<br />
<br />
				// create a new row to insert the data into<br />
				DataRow newRow = myDataSet.Tables["data"].NewRow();<br />
<br />
				// initilize the new row<br />
				newRow["id"] = 3;<br />
				newRow["date"] = date;<br />
				newRow["day"] = day;<br />
				newRow["time"] = time;<br />
				newRow["process"] = process;<br />
				newRow["comments"] = comments;<br />
				newRow["timeout"] = timeout;<br />
				newRow["status"] = status;<br />
<br />
				// add the new row into the dataset<br />
				myDataSet.Tables["data"].Rows.Add(newRow);<br />
<br />
				myDataAdapter.Update(myDataSet, "data");<br />
<br />
				return "true";<br />
			}<br />
			catch(Exception e)<br />
			{<br />
				return e.Message + "\n\n" + e.StackTrace + "\n\n" + e.InnerException;<br />
			}<br />
			finally<br />
			{<br />
				myConnection.Close();<br />
			}<br />
		}<br />

the problem is when I try to insert into the database, I keep getting this Exception:

Syntax error in INSERT INTO statement.<br />
<br />
   at System.Data.Common.DbDataAdapter.Update(DataRow[] dataRows, DataTableMapping tableMapping)<br />
   at System.Data.Common.DbDataAdapter.Update(DataSet dataSet, String srcTable)<br />
   at ShutdownMgr.Schedule.InsertSchedule(String date, String day, String time, String process, String comments, String timeout, String status) in c:\documents and settings\azel\my documents\visual studio projects\shutdownmgr\schedule.cs:line 99<br />

I have tried different ways but none were successful. Is anyone able to spot where I am going wrong? Dead | X|

thanks.

Heath Stewart5-Dec-03 4:04

5-Dec-03 4:04

Because you haven't specified a INSERT SqlCommand. The SqlDataAdapter isn't magical - you need to provide SELECT, INSERT, UPDATE, and DELETE SqlCommands for full functionality. Specifying just a SELECT SqlCommand doesn't generate the others. If you're unsure about how to do this, read about the SqlCommand and SqlDataAdapter classes in the SDK documentation, or use drop a SqlDataAdapter onto your form or control in VS.NET and run through the wizard. Be sure to look at what source it generates though to fully understand what is going on.

-----BEGIN GEEK CODE BLOCK-----
Version: 3.21
GCS/G/MU d- s: a- C++++ UL@ P++(+++) L+(--) E--- W+++ N++ o+ K? w++++ O- M(+) V? PS-- PE Y++ PGP++ t++@ 5 X+++ R+@ tv+ b(-)>b++ DI++++ D+ G e++>+++ h---* r+++ y+++
-----END GEEK CODE BLOCK-----

Azel Low5-Dec-03 4:10

5-Dec-03 4:10

Oic,

I thought the commandbuilder class is suppose to auto generate the insert, update and delete commands?

so even if i have set the commandbuilder to my data adapter, I must still initilize my insert, update and delete commands?

I will also take a look at the SDK documentation..

thanks.

Heath Stewart5-Dec-03 4:32

5-Dec-03 4:32

I missed that line, sorry. The SqlCommandBuilder may have trouble with your SELECT statement. Another possibility is with the table mappings of the SqlDataAdapter. You're setting your table name as "data". Does that actually map to the name of the table from which you're selecting records? These should match and you might have to set up a table mapping using the SqlDataAdapter.TableMappings property. This fairly straight-forward.

Azel Low5-Dec-03 4:41

5-Dec-03 4:41

the dataset table name is "data" which is the same as the one from the source table name.

i got the idea from MSDN that table mapping is use when your data source and dataset names are different? So if I have used the same name do I still need tablemapping?

thanks

Heath Stewart5-Dec-03 4:46

5-Dec-03 4:46

Yes, unless you use a strongly-typed DataSet. In most cases, the SELECT SqlCommand (with one or multiple result sets) loads tables by default named "Table", "Table1", "Table2", ..., "TableN". Your TableMappings should map these table names to your actual tables in your database.

Azel Low5-Dec-03 4:53

5-Dec-03 4:53

humm.. still wondering y i got the exception thrown when i try to perform an update to the database.

just wondering if you are able to point me or share with me some sample that has insert, delete and update without the use of stored procedure?

Heath Stewart5-Dec-03 5:21

5-Dec-03 5:21

I did actually. Drag a SqlDataAdapter to your form or control and go through the wizard, specifying that new commands should be created instead of using new or existing stored procs. Take a look at what's generated in your source file.

You can also read the SDK documentation for SqlDataAdapter, which does have examples in various class and method documentation.

Jerry Hammond5-Dec-03 5:39

Jerry Hammond

5-Dec-03 5:39

If you do have to browse to find the assemblies and all you find are xml files of the managed assemblies then go here for the latest DirectX 9 managed download: http://msdn.microsoft.com/library/default.asp?url=/downloads/list/directx.asp[^]

Just follow the instructs and viola you should have the assemblies. You'll know right away if you've got them installed correctly because when you fire up VS.Net you'll see the green directx logo along with your other languages on the splash screen.

Have fun!

Best,
Jerry

The only way of discovering the limits of the possible is to venture a little past them into the impossible.--Arthur C. Clark

Toasty0.com

Heath Stewart5-Dec-03 6:08

5-Dec-03 6:08

Wrong thread Smile | :)

What is the best way for Return Messages? Exceptions, return strings, return classes?

Jerry Hammond5-Dec-03 16:16

Jerry Hammond

5-Dec-03 16:16

Oh damn! Sorry!

The only way of discovering the limits of the possible is to venture a little past them into the impossible.--Arthur C. Clark

Toasty0.com

gokselm5-Dec-03 1:55

gokselm

5-Dec-03 1:55

Hi,

I want to ask a question about how to return messages from a general class.
How should I warn the users.

When something happened that must not be done what the object must do?

The senario is, there are several classes. Each of them has specific functionality.

It seems to me that the best way is defining a class that has properties like MessageID and and the Message. User can compare the MessageID with the const integers on the class to understand what happens and takes action.

Is there a general approach?

Kind Regards

Re: What is the best way for Return Messages? Exceptions, return strings, return classes?

Paul Watson5-Dec-03 2:31

Paul Watson

5-Dec-03 2:31

From what I have seen everybody has a different opinion on this one.

I say clean up and throw a descriptive exception, but there will undoubtedly be many who will say that is a bad idea and recommend output params or returning strings etc.

But my vote is on exceptions Smile | :)

regards,
Paul Watson
Bluegrass
South Africa

Brian Welsch wrote:
"blah blah blah, maybe a potato?" while translating my Afrikaans.

Crikey! ain't life grand?

Re: What is the best way for Return Messages? Exceptions, return strings, return classes?

David Stone5-Dec-03 3:33

David Stone

5-Dec-03 3:33

Paul Watson wrote:
But my vote is on exceptions

Ditto. Exceptions are the best way to notify the class consumer of an error.

When I can talk about 64 bit processors and attract girls with my computer not my car, I'll come out of the closet. Until that time...I'm like "What's the ENTER key?"
-Hockey on being a geek

Re: What is the best way for Return Messages? Exceptions, return strings, return classes?

Heath Stewart5-Dec-03 4:01

Re: What is the best way for Return Messages? Exceptions, return strings, return classes?

5-Dec-03 4:01

I cast my vote for exceptions, too. A callee can pass far more data about any errors that occur to its caller in a polymorphic way that would be difficult - if not stupid - to do with out params.

Stephane Rodriguez.5-Dec-03 2:38

Stephane Rodriguez.

5-Dec-03 2:38

The one that complies with FxCop[^]. Wink | ;)

RSS feed

Re: What is the best way for Return Messages? Exceptions, return strings, return classes?

David Stone5-Dec-03 3:32

David Stone

5-Dec-03 3:32

FxCop rocks! Did you know it's included in the Longhorn SDK download? Smile | :)

When I can talk about 64 bit processors and attract girls with my computer not my car, I'll come out of the closet. Until that time...I'm like "What's the ENTER key?"
-Hockey on being a geek

How Can I get the MSN style Use C#???

lupa_84215-Dec-03 1:06

lupa_8421

5-Dec-03 1:06

As we know, In The Dialog Window of MSN Messenger We Can Change the BackColor.
How can i do this in C#.Thanks a Lot!

Re: How Can I get the MSN style Use C#???

Alex Korchemniy5-Dec-03 8:31

Alex Korchemniy

5-Dec-03 8:31

Type "this." and search through the intellisense. You *should* be able to find it.

View a panel in fullscreen?

thomasa5-Dec-03 0:56

thomasa

5-Dec-03 0:56

Does someone know how to view a System.Windows.Forms.Panel in a fullscreen mode?

Thanks in advance for your help Rose | [Rose]

,
Thomas

Re: View a panel in fullscreen?

Heath Stewart5-Dec-03 3:59

DataGrid & DataView Speed

5-Dec-03 3:59

You can't display a Panel without a parent window, but you can display a Form with that Panel in fullscreen mode (it's just how window managers work).

If you want the form maximized, just set its WindowState property to FormWindowState.Maximized. If you want it to be really full-screened (like a game normally would be), it's similar: set FormBorderStyle to FormBorderStyle.None, and then set WindowState to FormWindowState.Maximized. The trick is in what the BorderStyle property does under the cover, since it's really just a wrapper for a dialog in Win32. See the Windows Styles for more information if you're interested.

mitdej5-Dec-03 0:26

mitdej

5-Dec-03 0:26

Hi,
I'm creating a windows form that has master-detail data on it.
I've implemented my own classes that take care of the bussiness logic and retreiving/writing data from/to database.

When I change the master record I call a method from the detail class to retrieve all the detail rows from the database and put this into dataset.tabel and then I return the default dataview to the method of the form. Then in the method I change the datasource of the datagird to the new dataview. This is very slow (I have to wait for 1 second for data to come up on the datagrid.
Please help.

<br />
private void FillDetail()<br />
		{<br />
			dvDetail1=refdata.RetrieveData();<br />
			dgRefData.SetDataBinding(dvDetail1, ""); //this is the slow part<br />
			cm_d1 = (CurrencyManager)BindingContext[dvDetail1];<br />
			cm_d1.PositionChanged+=g2td1;<br />
			Grid2Text_D1(new object(),new System.EventArgs());<br />
		}<br />

Dejan Mitev

Re: DataGrid & DataView Speed

Heath Stewart5-Dec-03 3:49