Welcome to the Lounge

honey the codewitch6-Apr-23 10:04

6-Apr-23 10:04

I've found with IoT, those are helpful in some cases, but I don't like instrumenting my code extensively for that kind of thing, or substituting a custom heap on these platforms because I haven't found a way to do it without impacting flash size, runtime performance, and/or maintainability/readability. Every solution I've found carries with it significant drawbacks, with IoT firmware usually doing sparse allocations, and generally on initialization, plus there's no teardown because there's no "prompt" to drop back to so it's easy to structure your code to avoid leaks and overruns for the most part.

I've ran into a couple in my most complicated codebases that weren't stupid errors, but most of the time it's me having an "oh duh" moment D'Oh! | :doh:

so while somewhat embarrassing, they're easy to catch if I stare at it sideways or hard enough. It's such that those tools don't really benefit me so much (I think? I haven't done any actual real world testing on it, it's just my hunch)

I would use this stuff in a complicated desktop app, but honestly? I'd just as soon use something like Boehm's collector if I was even writing a desktop app in C++.

To err is human. Fortune favors the monsters.

jschell7-Apr-23 9:10

jschell

7-Apr-23 9:10

I would never consider it part of the product delivery. I only use it when I know there is a problem and I need to track it down. Add it, test to the problem, then remove it.

jmaida5-Apr-23 10:32

5-Apr-23 10:32

Age old problem. The best one can do is lot of bounds checking in one's code.
As my old college CS. prof used to say about people coming to him with programming issues:
"You are off by 1 somewhere."

"A little time, a little trouble, your better day"
Badfinger

honey the codewitch5-Apr-23 10:37

5-Apr-23 10:37

It wasn't a fencepost error/off-by-one error.

It was something far more destructive. I ended up writing out twice the memory I intended to.

To err is human. Fortune favors the monsters.

FreedMalloc5-Apr-23 10:57

FreedMalloc

5-Apr-23 10:57

Hey, if you're going overrun the buffer at least make it worth your while! Double your fun, that's what I always say!

honey the codewitch5-Apr-23 11:09

5-Apr-23 11:09

Specifically

C++

static void wav_voice_16_1_to_16_2(const voice_func_info_t& info, void*state) {
    wav_info_t* wi = (wav_info_t*)state;
    if(!wi->loop&&wi->pos>=wi->length) {
        return;
    }
    uint16_t* dst = (uint16_t*)info.buffer;
    for(int i = 0;i<info.frame_count;++i) {
        int16_t i16;
        if(wi->pos>=wi->length) {
            if(!wi->loop) {
                break;
            }
            wi->on_seek_stream(wi->start,wi->on_seek_stream_state);
            wi->pos = 0;
        }
        if(player_read16s(wi->on_read_stream,wi->on_read_stream_state,&i16)) {
            wi->pos+=2;
        } else {
            break;
        }
        uint16_t u16 = (uint16_t)((i16+32768U)*wi->amplitude);
        for(int j=0;j<info.channels;++j) {
            *dst+=u16;
            ++dst;
            // YIKES! I lost track of the loop i was in and tried
            // writing out both channels here. removing these
            // two lines fixes it:
            *dst+=u16;
            ++dst;

        }
    }
}

To err is human. Fortune favors the monsters.

Kenneth Haugland5-Apr-23 11:24

Kenneth Haugland

5-Apr-23 11:24

This reminds me of some programming I did once upon a time in C++ Borland. Did not like it one bit. Literally. Laugh | :laugh:

jmaida5-Apr-23 15:26

5-Apr-23 15:26

"Off by one" example is not meant to be necessarily be literal. It means that somewhere a boundary check is not occurring or is not detected, a memory operation is corrupted, lots of things that may lead to a single point failure. Buffer overflows were and maybe still are reasons many virus attacks because they wander into uncontrolled parts of memory. Recall the infamous P = malloc( 0 ); not returning a null pointer.
I know your system is quite complex, hence your explorations into the complex interactions in world of hardware and software at the lower levels, so my feedback may be naive. Keep at it.

"A little time, a little trouble, your better day"
Badfinger

honey the codewitch5-Apr-23 15:34

5-Apr-23 15:34

jmaida wrote:
Buffer overflows were and maybe still are reasons many virus attacks

Yeah, I often joke when this happens that I wind up attacking my own code with an exploit. Big Grin | :-D

To err is human. Fortune favors the monsters.

jmaida5-Apr-23 16:04

5-Apr-23 16:04

"A little time, a little trouble, your better day"
Badfinger

den2k885-Apr-23 21:42

den2k88

5-Apr-23 21:42

jmaida wrote:
The best one can do is lot of bounds checking in one's code.

In embedded you really have to make each line count. When you have a handful of microseconds to compute the nes state of the transistors that are piloting a motor, your clock is 40 Mhz if you're lucky and you have 3kB of RAM and 64kB of flash bounds checking in the code is really on a if-needed basis.

You just check the memory window while debugging step by step and infer from that.

GCS/GE d--(d) s-/+ a C+++ U+++ P-- L+@ E-- W+++ N+ o+ K- w+++ O? M-- V? PS+ PE Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- r+++ y+++* Weapons extension: ma- k++ F+2 X

jmaida6-Apr-23 6:42

6-Apr-23 6:42

understood. tight coding

"A little time, a little trouble, your better day"
Badfinger

BernardIE53176-Apr-23 3:09

BernardIE5317

6-Apr-23 3:09

buffer over/under write/read is probably the only bug i have never created as i have always been painstakingly careful about such . in fact at a job many years ago i wrote a quick little memory protection scheme . it quickly found the source of memory errors though the project failed miserably . as for your situation would it make sense to run your code on a desktop/laptop in a kind of simulator of your devices w/ memory protection code so as to find any such errors ? - Best

honey the codewitch6-Apr-23 10:09

6-Apr-23 10:09

as for your situation would it make sense to run your code on a desktop/laptop in a kind of simulator of your devices w/ memory protection code so as to find any such errors ?

In some cases - well many cases - yes, because I write my code to be cross platform wherever possible, but in this case, it wouldn't have made sense because it's I2S driver level stuff where there's no corollary on a PC. I'd have to write (and debug!) an emulator for it, so it just adds to the test matrix rather than solving anything.

My errors were dumb ones, TBH. The kind that are somewhat embarrassing but easy to find and fix once you step away and come back to it.

Pointer ops are nothing special to me. I take to them pretty readily and don't often make mistakes. When I do, they're usually kind of typo or memory lapse varieties.

To err is human. Fortune favors the monsters.

BernardIE53176-Apr-23 11:45

BernardIE5317

6-Apr-23 11:45

regarding the cause of errors , many years ago at a small firm it occurred to me to investigate the ultimate presumably psychological cause of each of the many errors in our then project . i never began the investigation but it would not have succeeded anyway had i attempted as it would have required considerable cooperation from my 2 co-workers who each held me in contempt not to mention the 3 owners who disliked me as they were aware i believed each of them to be insane .

jeron16-Apr-23 12:25

jeron1

6-Apr-23 12:25

Boy that sounds like a fun place to work. Unsure | :~

"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle

jschell7-Apr-23 9:35

jschell

7-Apr-23 9:35

BernardIE5317 wrote:
co-workers who each held me in contempt not to mention the 3 owners who disliked me as they were aware i believed each of them to be insane .

Wow. Just Wow.

But since then you have learned to not tell people that they are insane?

jschell7-Apr-23 9:34

jschell

7-Apr-23 9:34

BernardIE5317 wrote:
it quickly found the source of memory errors though the project failed miserably

Not sure what that means but you cannot find the memory problems you stated in C/C++ using static analysis. It requires runtime analysis and it requires, at a minimum, fully exercising the application. Even then there is no guarantee.

BernardIE53177-Apr-23 11:01

BernardIE5317

7-Apr-23 11:01

my recollection was faulty . it was merely detecting un-freed memory . this was long before C++ . the project was all C . though fences and vector of stack addresses and automatic inspection of fences upon freeing or at end of execution of un-freed memory vector and manual inspection of stack addresses in either case would work reasonably well far better than examining every line of code in project it seems to me .

240DL6-Apr-23 4:23

240DL

6-Apr-23 4:23

I feel your pain.

Just located and fixed two buffer overruns yesterday where my code was writing I422 video to buffers sized for I420. D'Oh! | :doh:

It would run for hours, but just don't try to allocate/free anything! (... or try to make sense of the data that follows!)

honey the codewitch6-Apr-23 10:05

6-Apr-23 10:05

So much nicer when it crashes immediately!

To err is human. Fortune favors the monsters.