|
I am assigned to new role now: review peers' code.
do you have any good books or documents to recommend on this topic?
diligent hands rule....
|
|
|
|
|
How to Win Friends and Influence People - Dale Carnegie
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
|
|
|
|
|
thanks for this great book! I bought it right away as my thanksgiving gift for myself...
diligent hands rule....
|
|
|
|
|
“Your Code is Crap” - by Never Make It Personal
“Only A Moron Would Write Code Like This!” - by Offer Alternatives
Good luck. 👍
If you can't laugh at yourself - ask me and I will do it for you.
|
|
|
|
|
Once upon a time there were a bunch of coders that were given some incomplete requirements. They sat is a dark room with an illuminated white board and tried to figure out what the requirements were supposed to be. Then they sat in a dimly lit pub and worked out the architecture on beer-stained napkins. Then they sat in front of glowing monitors and LED illuminated keyboards and pounded out the code.
One day, a shining knight was added to the project to review their code. He discovered that his "peers" had decided to use to twelve incompatible frameworks, eleven coding styles, ten unit test frameworks, nine different databases, eight different REST API styles, seven different TypeScript versions, six back-end languages, five UX tools, four different CI packages, three bug trackers, two ticket managers, and one partridge in a pear tree that nobody knew was part of the requirements.
The knight, now with dulled and dented armor, went to management and recommended the whole thing be rewritten. Management went to marketing with the bad news that the product would be delayed for another year. Marketing went to the CFO with the bad news that the product would be $1,000,000 overbudget and cost the customer 10 times what they had planned for the street price. The CFO went to the CEO and suggested an illegal inside trader move before the stock price sunk.
The CEO told marketing to ship the product and advertise the bugs as features the customer must have. The CEO told the CFO to freeze all hiring and fire half the developers. The CEO told the managers to outsource the remaining work. The managers told the programmers they would be in maintenance mode only.
One dark and stormy night, the remaining programmers took the peer review knight out to a lonely field where the crows crowed "nevermore" and declared the knight to be a heretic of the all the dogmatic religions in the programming world, the Vue-ites, the React-ians, the Angular-ons. The knight was burned on the stake with much functional language incantations. It was all done with svelt discretion.
The competition lived happily ever after.
THE END
|
|
|
|
|
That's the best code review story I've heard  .
All my code review stories are drab tales of rolled eyes and ignored comments.
Mircea
|
|
|
|
|
|
Southmountain wrote: I am assigned to new role now: review peers' code.
Your organization has a special role for that? 
At my company, every dev is required to take Andrejs Doronins' course Code Review: Best Practices[^]. It's brief, to the point and IMHO very effective.
/ravi
|
|
|
|
|
Hi there!
I created a website and put it on a free hosting site to which I uploaded my files, and it appeared to me well on the computer, and when I minimized the width of the browser window, the response was good exactly as I designed it, but when I open the program on the mobile, the site is very bad and not as I designed it at all and the elements Overlapping ...
Likewise, when someone else opened the site for him on his Macintosh computer, he had errors that I do not have when I open the site from my computer, even though he has the same browser as I have, which is Chrome. My operating system is Windows 10.
What is the reason and what is the solution?
Note that I have provided the required formatting codes:
meta charset="UTF-8
meta lang="en-US
meta http-equiv="X-UA-Compatible" content="IE=edge
meta name="viewport" content="width=device-width,initial-scale=1.0
Please I prefer replying from people who have experience or any successful experience in raising a site on the Internet and its appearance well on the mobile, as well as who can point me to a source where I can find the solution.
Website link:
Thanks to any replies! Much appreciated.
|
|
|
|
|
Madi - you're asking sort of a programming question - go check out the Web Development forum.
That said, this is the specific reason I gave up doing any sort of web development. FWIW, your title is incorrect. Your issue has nothing to do with a different OS. You are dealing with display geometry and perhaps browser differences.
Charlie Gilley
“They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
Has never been more appropriate.
|
|
|
|
|
|
Thank you for your answer, do you mean I have to check my html, or css ?
|
|
|
|
|
Pushing your luck.
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
|
|
|
|
|
A true believer is an honest person who searches for the truth, the path of God Almighty.
|
|
|
|
|
by answering his question in the Lounge, he now thinks this is an acceptable place to discuss programming questions.
I could be wrong.
|
|
|
|
|
Should I now move the question to the programming section or re-question in that section?
modified 11-Nov-22 13:42pm.
|
|
|
|
|
|
He's either a genius or a complete moron, because I can't work out what the heck he thinks he is doing ...
That's a stupid amount of money to spend just to effectively burn it note by note. So either he has a grand plan that is so complex nobody but him understands it, or it's so dumb that he may as well be burning $100 bills to heat his home.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I'm not a big believer in 4D chess. If someone looks like they're stepping in it, it's because they're stepping in it, in my experience.
To err is human. Fortune favors the monsters.
|
|
|
|
|
Mostly, that's true.
But the actions of someone with a big enough intelligence would be incomprehensible to me; I just wouldn't have the mental capacity to understand it - like my cat cannot understand how to open a foil pouch full of cat food ... 
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
OriginalGriff wrote: like my cat cannot understand how to open a foil pouch full of cat food
Mine can, he tears open the pouch in the middle.
If we don't keep them locked away he will feed himself in the middle of the night.
|
|
|
|
|
I haven't seen Elon do anything that would make me think his intelligence is particularly exceptional except choose the right parents to be born to. I'm not saying he's not smart. But I also never saw Einstein steal other people's inventions or burn $44 million billion dollars to make a political point (or whatever it is he thinks he is doing). Just sayin'
To err is human. Fortune favors the monsters.
|
|
|
|
|
OriginalGriff wrote: like my cat cannot understand how to open a foil pouch full of cat food ...
Oh he understands, he gives his servants a certain look, and a pouch gets opened, simples.
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment
"Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst
"I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
|
|
|
|
|
OriginalGriff wrote: with a big enough intelligence would be incomprehensible to me
The fallacy in that statement is in thinking that being smart translates to every possible human activity.
Whether Musk is intelligent or just lucky is debatable. He certainly has had failures.
|
|
|
|
|
I do enjoy watching the 4D contortions people put themselves through in order to believe Musk is playing 4D chess!
Except their gullibility is so sad to watch that my feelings are somewhat tempered.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
