|
It's re-inventing the wheel when you haven't discovered what you already have (access to).
It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food
|
|
|
|
|
DI injecting is not that hard to build on top of for example resx - but indeed - is it worth it? There is no single answer to that. I would for example be tempted to use it for supporting pseudo-translation tests directly in the app without having to go through the localization tools to get the pseudo-translated resources for a quick I18N test.
If I have translations with the UI or not depends on a lot of things - for example, if it is a WinForm application (not that I do those anymore) then the size of the controls is typically in the resource file along with the translation - typically making it more of a view thing than entity/business logic. Even in WPF/HTML the layout can effect the chosen translation (i.e. a less accurate but more concise translation being chosen for a label). In reality I think you always end up with plenty of strings throughout the layers.
I understand both the translation and programming workflows, which makes it a bit easier for me to know when to customize and when to stick to standards. If you do not understand the translation workflow, stick to standards. Your little "optimization" could end up being rather problematic. This is less of a problem if you do not use professional translators with access to proper tools though (they won't know when you are wasting their time) 
|
|
|
|
|
Hello - I had records to be processed at a time, and the 4th record had an issue. The entire program failed, not processing the rest of the records which had no issue. How can I can continue the program processing the good records?
Thanks!!
|
|
|
|
|
|
I have a catch block in the code which catches all exceptions and writes to log file.
How can I make it that the program continues processing the good records instead of not processing the entire batch.
|
|
|
|
|
You haven't supplied any relevant code so it's impossible to tell you with any accuracy.
But, the try/catch block should surround only the processing of a single record, NOT THE ENTIRE LIST OF THEM.
|
|
|
|
|
That sums it up.
It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food
|
|
|
|
|
There is no specific way to answer you because we have no idea how you are processing the records.
One way to do it is to process one record at a time and put that code in a try catch, inside the loop. That way the loop will continue. However, if the problem is that the database is not available, for example, then it's going to throw an exception for every single record you are processing.
|
|
|
|
|
Ask what you want the try-catch to do; retry the current item, or skip it and progress to the next.
Retrying should be limited.
Bastard Programmer from Hell 
"If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.
|
|
|
|
|
To add to what the others have said, you might also want to look at why the record failed - what did it contain that you didn't expect? Was it something you should have expected, or been able to handle?
For example, if a user is to enter a page full of information and a single item is wrong, you shouldn't invalidate the whole page - just get the user to enter the right value.
We can't see your screen, access your HDD, or read your mind - so we have no idea what your code is doing, or how it is doing it; but graceful error handling is an important part of any app!
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
I'm trying to get the list of allocated ranges for a sparse file on Windows 10 from a C# program. DeviceIOControl requires an array of FILE_ALLOCATED_RANGE_BUFFER structures as the output buffer. I just can't seem to get the correct way of passing these. So far I have....
public static bool GetSparseRange(SafeFileHandle hdrive, in FILE_ALLOCATED_RANGE_BUFFER query, ref FILE_ALLOCATED_RANGE_BUFFER[] response, int count)
{
int nInBufferSize = (int)Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER));
IntPtr lpInBuffer = Marshal.AllocHGlobal(nInBufferSize);
Marshal.StructureToPtr(query, lpInBuffer, true);
uint bytesread=0;
IntPtr[] ptrArr = new IntPtr[count];
for (int i = 0; i < count; ++i)
{
ptrArr[i] = Marshal.AllocHGlobal(Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER)));
Marshal.StructureToPtr(response[i], ptrArr[i], true);
}
bool rc = DeviceIoControl(
hdrive, // device to be queried
(uint)EIOControlCode.FsctlQueryAllocatedRanges, // operation to perform
lpInBuffer, (uint)nInBufferSize, // input buffer
ptrArr, (uint)(nInBufferSize * count)), // output buffer
ref bytesread, // # bytes returned
IntPtr.Zero); // synchronous I/O
// Get the last error and display it.
int error = Marshal.GetLastWin32Error();
for (int j = 0; j < count / nInBufferSize; ++j)
{
if (j < bytesread / nInBufferSize)
Marshal.PtrToStructure(ptrArr[j], response[j]);
Marshal.FreeHGlobal(ptrArr[j]);
}
Marshal.FreeHGlobal(lpInBuffer);
return rc;
}
However this return rc=false, byteread=0 and error=5.
Can anyone suggest the correct way to do this?
Thanks
|
|
|
|
|
|
He was so casual about "error 5" that I assumed everyone knew what it meant, except me ...and it was somehow not relevant.
It was only in wine that he laid down no limit for himself, but he did not allow himself to be confused by it.
― Confucian Analects: Rules of Confucius about his food
|
|
|
|
|
Yeah, At least one of his problems is ERROR_ACCESS_DENIED but it's entirely possible that there are other errors. I don't see anything else that stands out. I guess it would be nice to know how the SafeFileHandle hdrive is obtained.
|
|
|
|
|
Radnor,
You were on the right track. The program was running as administrator so the "Access denied" was confusing me as well. The SafeFileHandle was created like this ...
using (dd = new FileStream(path + ".dd", FileMode.Open, FileAccess.Write, FileShare.Write))
{
bool finished = NativeMethods.GetSparseRange(ldd.SafeFileHandle, query, ref response, 1024);
}
So when the DeviceIoControl was called the file was empty which for some reason caused the return code 5.
Changing the FileStream creation for an existing file stopped the error.
However now I get an 0x00000057 error, parameter error which brings me back to the original question as how to pass an array of structures to DeviceIoControl.
This is what I've tried, the output buffer is the issue I think....
public static bool GetSparseRange(SafeFileHandle hdrive, in FILE_ALLOCATED_RANGE_BUFFER query, ref FILE_ALLOCATED_RANGE_BUFFER[] response, int count)
{
int nInBufferSize = (int)Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER));
IntPtr lpInBuffer = Marshal.AllocHGlobal(nInBufferSize);
Marshal.StructureToPtr(query, lpInBuffer, true);
uint bytesread=0;
int nOutBufferSize = nInBufferSize * count;
IntPtr lpOutBuffer = Marshal.AllocHGlobal(nOutBufferSize);
bool rc = DeviceIoControl(
hdrive,
(uint)EIOControlCode.FsctlQueryAllocatedRanges,
lpInBuffer, (uint)nInBufferSize,
lpOutBuffer, (uint)nOutBufferSize,
ref bytesread,
IntPtr.Zero);
int error = Marshal.GetLastWin32Error();
Marshal.PtrToStructure(lpOutBuffer, response);
Marshal.FreeHGlobal(lpInBuffer);
Marshal.FreeHGlobal(lpOutBuffer);
return rc;
}
Thanks
|
|
|
|
|
Hello,
Your GetSparseRange function is working for me. I simply wrote a quick test application and used the function you provided.
using System;
using Microsoft.Win32.SafeHandles;
using System.Runtime.InteropServices;
using System.Text;
using System.IO;
using System.Diagnostics;
namespace SparseRanges
{
#region Structs
struct FILE_ZERO_DATA_INFORMATION
{
public long offset;
public long zero;
}
struct FILE_ALLOCATED_RANGE_BUFFER
{
public long offset;
public long length;
}
#endregion
class Program
{
#region Const ints
const uint FSCTL_SET_SPARSE = 590020;
const uint FSCTL_QUERY_ALLOCATED_RANGES = 606415;
#endregion
[DllImport("kernel32.dll", SetLastError = true)]
extern static bool GetVolumeInformation(string vol, StringBuilder name, int nameSize, out uint serialNum, out uint maxNameLen, out uint flags, StringBuilder fileSysName, int fileSysNameSize);
[DllImport("kernel32.dll", SetLastError = true)]
static extern bool DeviceIoControl([In] SafeFileHandle hDevice, [In] uint dwIoControlCode, IntPtr lpInBuffer, [In] int nInBufferSize, IntPtr lpOutBuffer, [In] int nOutBufferSize, ref uint lpBytesReturned, [In] IntPtr lpOverlapped);
public static bool GetSparseRange(SafeFileHandle hdrive, in FILE_ALLOCATED_RANGE_BUFFER query, ref FILE_ALLOCATED_RANGE_BUFFER[] response, int count)
{
int nInBufferSize = (int)Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER));
IntPtr lpInBuffer = Marshal.AllocHGlobal(nInBufferSize);
Marshal.StructureToPtr(query, lpInBuffer, true);
int nOutBufferSize = nInBufferSize * count;
IntPtr lpOutBuffer = Marshal.AllocHGlobal(nOutBufferSize);
uint bytesread = 0;
bool rc = DeviceIoControl(hdrive, FSCTL_QUERY_ALLOCATED_RANGES, lpInBuffer, nInBufferSize, lpOutBuffer, nOutBufferSize, ref bytesread, IntPtr.Zero);
int error = Marshal.GetLastWin32Error();
Marshal.FreeHGlobal(lpInBuffer);
Marshal.FreeHGlobal(lpOutBuffer);
return rc;
}
private static void PrintSparseRange(FILE_ALLOCATED_RANGE_BUFFER range)
{
Console.WriteLine("{0:d} offset, length = {1:d}", range.offset, range.length);
}
static void Main(string[] args)
{
uint temp1, temp2, flags, bytes=0;
if (GetVolumeInformation("C:\\", null, 0, out temp1, out temp2, out flags, null, 0))
{
uint supports_sparse = flags & 0x40;
if (supports_sparse == 0x40)
{
Console.WriteLine("Volume supports sparse files...");
string sparse_filename = Path.GetTempFileName();
System.IO.FileStream f = System.IO.File.Create(sparse_filename);
if (DeviceIoControl(f.SafeFileHandle, FSCTL_SET_SPARSE, IntPtr.Zero, 0, IntPtr.Zero, 0, ref bytes, IntPtr.Zero))
{
Console.WriteLine("Successfully generated a sparse file.");
f.SetLength(10240);
FILE_ALLOCATED_RANGE_BUFFER[] response = new FILE_ALLOCATED_RANGE_BUFFER[64];
FILE_ALLOCATED_RANGE_BUFFER query;
query.length = 10240;
query.offset = 0;
int count = 64;
if(GetSparseRange(f.SafeFileHandle, query, ref response, count))
{
Action<FILE_ALLOCATED_RANGE_BUFFER> print_all = new Action<FILE_ALLOCATED_RANGE_BUFFER>(PrintSparseRange);
Array.ForEach(response, print_all);
}
f.Close();
Console.WriteLine("Removing temp sparse file.");
File.Delete(sparse_filename);
}
}
}
}
}
}
BobZscharnagk wrote: The SafeFileHandle was created like this ...
using (dd = new FileStream(path + ".dd", FileMode.Open, FileAccess.Write, FileShare.Write))
Any particular reason why you are opening the file without Read access?
Best Wishes,
-David Delaune
|
|
|
|
|
Radnor,
Thanks for the reply and the time. When I tried your code, unmodified, i just get 64 lines of "0 offset, length = 0", which is because I think you didn't copy the Marshall'd response back into the passed response. I added two lines to your code...
f.SetLength(10240);
f.Write(new byte[] { (byte)'H', (byte)'e', (byte)'l', (byte)'l', (byte)'o' }, 0, 5);
and
int error = Marshal.GetLastWin32Error();
Marshal.PtrToStructure(lpOutBuffer, response);
Adding f.Write by itself should cause one of the blocks to be allocated and not show in the output. Testing with just this line gives the same result as if the write wasn't there.
Adding the second change, Marshal.PtrToStructure, causes an error "Quote: System.ArgumentException: 'The specified structure must be blittable or have layout information.
Which I think is where I started.
|
|
|
|
|
Finally got it working....
public static int GetSparseRange(SafeFileHandle hdrive, in FILE_ALLOCATED_RANGE_BUFFER query, ref FILE_ALLOCATED_RANGE_BUFFER[] response, out int count)
{
int nInBufferSize = Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER));
IntPtr lpInBuffer = Marshal.AllocHGlobal(nInBufferSize);
Marshal.StructureToPtr(query, lpInBuffer, false);
uint bytesreturned = 0, command = (uint)EIOControlCode.FsctlQueryAllocatedRanges;
int nOutBufferSize = nInBufferSize * 1024;
IntPtr lpOutBuffer = Marshal.AllocHGlobal(nOutBufferSize);
DeviceIoControl(
hdrive,
(uint)command,
lpInBuffer, (uint)nInBufferSize,
lpOutBuffer, (uint)nOutBufferSize,
out bytesreturned,
IntPtr.Zero);
int rc = Marshal.GetLastWin32Error();
count = (int)bytesreturned / nInBufferSize;
for (int j = 0; j < count; ++j)
{
response[j] = (FILE_ALLOCATED_RANGE_BUFFER)Marshal.PtrToStructure(lpOutBuffer + (j * nInBufferSize), typeof(FILE_ALLOCATED_RANGE_BUFFER));
}
Marshal.FreeHGlobal(lpInBuffer);
Marshal.FreeHGlobal(lpOutBuffer);
return rc;
}
|
|
|
|
|
Yep.
In my code sample I gave you you can add:
for (int i = 0; i < count; i++)
{
IntPtr ptr= new IntPtr(lpOutBuffer.ToInt64() + i * Marshal.SizeOf(typeof(FILE_ALLOCATED_RANGE_BUFFER)));
response[i] = Marshal.PtrToStructure<FILE_ALLOCATED_RANGE_BUFFER>(ptr);
}
Under the call to DeviceIoControl to marshal the unmanaged array.
I am a Windows API guy... I got involved to help you figure out why DeviceIoControl was giving you an ERROR_ACCESS_DENIED. Didn't know I would need to fix your C# code too. 
Glad you got it working, good luck. 
Best Wishes,
-David Delaune
|
|
|
|
|
Hi, folks.
I created a user control with some properties and methods and used it in a Forms project where it appears many times. It's working fine.
But now I decided to improve some characteristics and I eliminated some properties and added some.
The problem is that the forms where this control appears show errors and it' very difficult to open the form. After I open the form I removed the old control and tried to add the new version, but it appears that only the old version is accepted.
What is the best way to substitute a control under these circumstances?
I use C# in Visual Studio 2019.
Thanks.
|
|
|
|
|
The problem is probably that as you say:
Quote: I eliminated some properties and added some.
If any of the classes that use your control are referencing those properties, the new version will just not work: the properties no longer exist.
The proper way to do that is to depreciate the properties, not remove them: that way they can still be used but there is a warning that they shouldn't be used in new projects.
That is documentation only, however - for later versions, you can make them actually obsolete: ObsoleteAttribute Class (System) | Microsoft Docs[^] but you should allow a good time for people to migrate to the newer version before that happens.
Often, a more developer friendly way to do this with drastic changes is to end support for the existing version, and develop a new version for future projects.
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Make the properties obsolete? I'll read more about.
Thanks.
|
|
|
|
|
You're welcome!
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!
|
|
|
|
|
Member 14792393 wrote: I decided to improve some characteristics and I eliminated some properties and added some.
A key question is what you did to the Forms that had instances of the UserControl that used the removed Properties: of course any attempted use/access of/to removed "anything" results in compile errors.Member 14792393 wrote: After I open the form I removed the old control and tried to add the new version, but it appears that only the old version is accepted
This just doesn't make sense: did you edit the form code to remove any code that used the UserControl instance, and, then, re-build the Project/Solution? Did you re-build the solution after adding the new version of the UserControl?
There is (imho) a defect in Visual Studio that has never been fixed: you can modify a UserControl ... for example, add some new Control to it ... and, the change doesn't appear in currently open design-time Form Windows even after you re-build the solution. However, if you close the designer window, and re-open it: the view has been updated.
«One day it will have to be officially admitted that what we have christened reality is an even greater illusion than the world of dreams.» Salvador Dali
|
|
|
|
|
"did you edit the form code to remove any code that used the UserControl instance, and, then, re-build the Project/Solution? Did you re-build the solution after adding the new version of the UserControl?"
Yes, but the application is too big and has many instances of the control.
What I intend to do now is to rename the new version of the control and add it to the project. Then I open each form, erase the old version and insert the new version. After that I can remove the old version. It's a hard job, but I think it's the only way.
What do you think?
Thanks.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
