C / C++ / MFC

Re: .bmp and .ico MFC vc++

24-Oct-19 4:05

You just need to add the relevant resource to your dialog. Either by adding a manual resource statement like:

C++

ICON IDI_APPLICATION, IDC_STATIC, 7, 7, 20, 20

, or via the Visual Studio resource editor.

Perhaps if you explain clearly what the problem is we may be able to offer further suggestions.

Member 1457555625-Oct-19 3:26

Member 14575556

25-Oct-19 3:26

Thank you for the reply. After a lot of trial and error and following the guidance. I got what I wanted. Big Grin | :-D

Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

arnold_w22-Oct-19 22:33

arnold_w

22-Oct-19 22:33

I need to save space and reduce some of my function pointers from 32-bit to 16-bit and this is ok since the flash region I've specified in the linker script is only 32 kBytes. Does anybody know how I can make my 3rd example below compile properly?

C++

typedef struct {
    uint16_t myFunctPtrTruncated;
} myUint16struct_s;

typedef struct {
    void* myFunctPtr;
} myVoidstruct_s;

static void myDummyFunc()  {}

myVoidstruct_s   myStruct1 = { myDummyFunc  };                    // Ok
myUint16struct_s myStruct2 = { 0  };                              // Ok
myUint16struct_s myStruct3 = { (uint16_t)(uint32_t)myDummyFunc }; // Error: "initializer element is not constant"

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

Richard MacCutchan22-Oct-19 23:35

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

22-Oct-19 23:35

I just tried this with Microsoft's Visual C++ compiler and it compiles cleanly.

arnold_w23-Oct-19 0:49

arnold_w

23-Oct-19 0:49

I am using System Workbench (=gcc?) and I get error (not warning) message "initializer element is not constant".

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

Richard MacCutchan23-Oct-19 1:29

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

23-Oct-19 1:29

arnold_w wrote:
I am using System Workbench (=gcc?)

A pity you did not mention that in your original message.

CPallini23-Oct-19 1:25

CPallini

23-Oct-19 1:25

Are you sure you are using the right tools for (cross?) compilation? The compiler should be aware of the target addressing modes and adjust the pointers size accordingly.

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

leon de boer23-Oct-19 2:21

leon de boer

23-Oct-19 2:21

Your statement 3 as written will only compile in C++ it isn't valid C code.
Which is why the person who tried it on VC++ it worked.

In C "myDummyFunc" can not be typecast to an address like in C++, in C "&myDummyFunc" is the pointer address that needs typecasting
Remember what that pesky "&" character means in C

The first case you list was defined as valid in C99, but your 3rd case is junk and correctly rejected
So try proper C code using the "&" so it understands what you are trying to do

myUint16struct_s myStruct3 = { (uint16_t)(uint32_t)&myDummyFunc };

Now if you want to do it properly so its portable the correct way is to use uintptr_t for the translation and C99 dot format
This allows you move the pointer anywhere within the struct and it sets correctly

myUint16struct_s myStruct4 = { .myFunctPtrTruncated = (uint16_t)(uintptr_t)&myDummyFunc };

In C99, uintptr_t will put some safety around your code because it is defined as

an unsigned integer type with the property that any valid pointer to void can be converted to this type, then converted back to pointer to void, and the result will compare equal to the original pointer

In vino veritas

modified 23-Oct-19 8:28am.

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

arnold_w23-Oct-19 2:26

arnold_w

23-Oct-19 2:26

I still get the same error message.

Re: Why can't I initialize ("initializer element is not constant") a struct with a truncated function pointer?

leon de boer23-Oct-19 2:30

leon de boer

23-Oct-19 2:30

Set the compiler flags -std=c11 or -std=c99 either standard will accept the code

The portable case has to work or you are on an old C89 compiler which I find odd given it accepts the shortcut syntax in 1

The only other choice is you are on something like a PIC where you have to use builtins to get function addresses because of the crazy 32K block arrangements on memory

In vino veritas

modified 23-Oct-19 8:40am.

AMD or Intel

_Flaviu22-Oct-19 9:00

22-Oct-19 9:00

Is there any reliable location in windows registry that tell if the architecture of the machine is AMD or Intel ? If there is, where is this location ?

I know this location:

C++

HKEY_LOCAL_MACHINE\HARDWARE\DESCRIPTION\System\CentralProcessor\0

and Identifier key, but my machine is Intel ... and I don't know what would be this value on AMD case ... is this a reliable location ?

P.S. Also, I know that I could find here:

C++

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment

PROCESSOR_ARCHITECTURE has AMD64 value, even if I have Intel machine ...

modified 22-Oct-19 15:17pm.

David Crow22-Oct-19 10:00

David Crow

22-Oct-19 10:00

Can you do something like:

SYSTEM_INFO si;
GetSystemInfo(&si);
TRACE(_T("%u\n"), si.wProcessorArchitecture);

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

modified 22-Oct-19 16:08pm.

_Flaviu22-Oct-19 19:35

22-Oct-19 19:35

Thank you, but the request is to get this value from registry, not from API.

Richard MacCutchan22-Oct-19 21:42

22-Oct-19 21:42

The information can also be found by the following powershell command:

PS C:\Users\rjmac> Get-WmiObject Win32_Processor


Caption           : Intel64 Family 6 Model 142 Stepping 9
DeviceID          : CPU0
Manufacturer      : GenuineIntel
MaxClockSpeed     : 2701
Name              : Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
SocketDesignation : U3E1

_Flaviu22-Oct-19 22:53

22-Oct-19 22:53

Yes, I could do that even with cmd, but I need to do this task with my code (VC++).

Richard MacCutchan22-Oct-19 23:12

22-Oct-19 23:12

Then I guess the registry key that you already referred is what you need to look at.

_Flaviu23-Oct-19 0:39

23-Oct-19 0:39

Then someone who has AMD processor could take a look on that location and tell me what value has PROCESSOR_IDENTIFIER key (on location: HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment) Smile | :)

Richard MacCutchan23-Oct-19 0:52

23-Oct-19 0:52

You could always try and find someone where you are who has an AMD system.

_Flaviu23-Oct-19 1:28

23-Oct-19 1:28

Maybe it is just a feeling, but is hard to find on someone who has AMD processor.

Richard MacCutchan23-Oct-19 1:31

23-Oct-19 1:31

What problem are you actually trying to solve?

_Flaviu23-Oct-19 1:51

23-Oct-19 1:51

To know what is there, in PROCESSOR_ARCHITECTURE and PROCESSOR_IDENTIFIER from HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\Environment when machine has AMD processor.

Richard MacCutchan23-Oct-19 2:22

23-Oct-19 2:22

Yes, but what problem are you actually trying to solve?

_Flaviu23-Oct-19 2:33

23-Oct-19 2:33

To know from registry if the machine has AMD or Intel processor. I guess is possible that.

Richard MacCutchan23-Oct-19 4:42

23-Oct-19 4:42

OK, last try: what actual problem are you trying to resolve? Knowing whether it is AMD or Intel will not make any difference to the execution of your application, so I can only assume that you have found some other issue which you are keeping secret from us.

_Flaviu23-Oct-19 6:53