C / C++ / MFC

Re: A complex macro definition

21-Mar-17 2:32

You have to lookup first how V_ROM1_FAR and V_ROM2_FAR are defined.
Then it will be something like

far * tblHead far * V_ROM3

far is a compiler and platform specific keyword. See Far pointer - Wikipedia[^].

See also Cx51 User's Guide: Abstract Pointers[^] (I did not found a better link that explains such castings).

samzcs21-Mar-17 2:36

samzcs

21-Mar-17 2:36

Thanks, I understand it.

Looked into V_ROM2_FAR V_ROM3, V_ROM2_FAR be defined as const, V_ROM3 blank

dev c

Alvi ZaDa20-Mar-17 7:18

Alvi ZaDa

20-Mar-17 7:18

i hv problem in using basic rules of dev c Frown | :(

Re: dev c

Richard Deeming20-Mar-17 8:47

Richard Deeming

20-Mar-17 8:47

You also seem to have a problem in using the basic rules of asking a question! D'Oh! | :doh:

HOW TO ASK A QUESTION - C / C++ / MFC Discussion Boards[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Re: dev c

Victor Nijegorodov20-Mar-17 9:58

Victor Nijegorodov

20-Mar-17 9:58

Alvi ZaDa wrote:
i hv problem in using basic rules of dev c

1. What is "hv"?
2. What is "dev c"?
What exactly is the "problem in using basic rules" you have?

Re: dev c

Patrice T20-Mar-17 11:45

Patrice T

20-Mar-17 11:45

Alvi ZaDa wrote:
i hv problem in using basic rules of dev c

Asking questions is a skill[^]
Some guidelines for posting questions in the forums[^]

Patrice

“Everything should be made as simple as possible, but no simpler.” Albert Einstein

Change from Cstring to double in listview vc++

lolici20-Mar-17 1:31

20-Mar-17 1:31

Hello everyone!
I've used a list control to display data and an edit box to edit them. So I used this function:

void CDataDialog::SetCell(HWND hWnd1,
CString value, int nRow, int nCol)

I want to make this change:

void CDataDialog::SetCell(HWND hWnd1,
double value, int nRow, int nCol)

but I have problem with other functions such as GetDlgItemText which I don't know how to change. Here is the code:

void CDataDialog::SetCell(HWND hWnd1,
	double value, int nRow, int nCol)
{
	TCHAR     szString[256];
	swprintf(szString, value, 0);

	//Fill the LVITEM structure with the 
	//values given as parameters.
	LVITEM lvItem;
	lvItem.mask = LVIF_TEXT;
	lvItem.iItem = nRow;
	lvItem.pszText = szString;
	lvItem.iSubItem = nCol;
	if (nCol >0)
		//set the value of listItem
		::SendMessage(hWnd1, LVM_SETITEM,
		(WPARAM)0, (WPARAM)&lvItem);
	else
		//Insert the value into List
		ListView_InsertItem(hWnd1, &lvItem);

}

CString CDataDialog::GetItemText(
	HWND hWnd, int nItem, int nSubItem) const
{
	LVITEM lvi;
	memset(&lvi, 0, sizeof(LVITEM));
	lvi.iSubItem = nSubItem;
	CString str;
	int nLen = 128;
	int nRes;
	do
	{
		nLen *= 2;
		lvi.cchTextMax = nLen;
		lvi.pszText = str.GetBufferSetLength(nLen);
		nRes = (int)::SendMessage(hWnd,
			LVM_GETITEMTEXT, (WPARAM)nItem,
			(LPARAM)&lvi);
	} while (nRes == nLen - 1);
	str.ReleaseBuffer();
	return str;
}

void CDataDialog::OnClickList1(NMHDR *pNMHDR, LRESULT *pResult)
{
	//LPNMITEMACTIVATE pNMItemActivate = reinterpret_cast<LPNMITEMACTIVATE>(pNMHDR);
	// TODO: Add your control notification handler code here
	//*pResult = 0;
	Invalidate();
	HWND hWnd1 = ::GetDlgItem(m_hWnd, IDC_LIST1);
	LPNMITEMACTIVATE temp = (LPNMITEMACTIVATE)pNMHDR;
	RECT rect;
	//get the row number
	nItem = temp->iItem;
	//get the column number
	nSubItem = temp->iSubItem;
	if (nSubItem == 0 || nSubItem == -1 || nItem == -1)
		return;
	//Retrieve the text of the selected subItem 
	//from the list
	CString str = GetItemText(hWnd1, nItem,
		nSubItem);

	RECT rect1, rect2;
	// this macro is used to retrieve the Rectanle 
	// of the selected SubItem
	ListView_GetSubItemRect(hWnd1, temp->iItem,
		temp->iSubItem, LVIR_BOUNDS, &rect);
	//Get the Rectange of the listControl
	::GetWindowRect(temp->hdr.hwndFrom, &rect1);
	//Get the Rectange of the Dialog
	::GetWindowRect(m_hWnd, &rect2);

	int x = rect1.left - rect2.left;
	int y = rect1.top - rect2.top;

	if (nItem != -1)
		::SetWindowPos(::GetDlgItem(m_hWnd, IDC_EDIT1),
			HWND_TOP, rect.left + x, rect.top + 4,
			rect.right - rect.left - 3,
			rect.bottom - rect.top - 1, NULL);
	::ShowWindow(::GetDlgItem(m_hWnd, IDC_EDIT1), SW_SHOW);
	::SetFocus(::GetDlgItem(m_hWnd, IDC_EDIT1));
	//Draw a Rectangle around the SubItem
	::Rectangle(::GetDC(temp->hdr.hwndFrom),
		rect.left, rect.top - 1, rect.right, rect.bottom);
	//Set the listItem text in the EditBox
	::SetWindowText(::GetDlgItem(m_hWnd, IDC_EDIT1), str);
	*pResult = 0;
}

void CDataDialog::OnOK()
{
	CWnd* pwndCtrl = GetFocus();
	// get the control ID which is 
	// presently having the focus
	int ctrl_ID = pwndCtrl->GetDlgCtrlID();
	double str;
	switch (ctrl_ID)
	{   //if the control is the EditBox 
	case IDC_EDIT1:
		//get the text from the EditBox
		GetDlgItemText(IDC_EDIT1, str);

		//set the value in the listContorl with the
		//specified Item & SubItem values
		SetCell(::GetDlgItem(m_hWnd, IDC_LIST1),
			str, nItem, nSubItem);

		::SendDlgItemMessage(m_hWnd, IDC_EDIT1,
			WM_KILLFOCUS, 0, 0);
		::ShowWindow(::GetDlgItem(m_hWnd, IDC_EDIT1),
			SW_HIDE);
		break;
	default:
		break;
	}
}

Thank you in advance! Smile | :)

Jochen Arndt20-Mar-17 2:02

20-Mar-17 2:02

A list control can not store double values without additional handling. To set the text of an item to a floating point value it must be converted. Read the documentation of the used sprintf, _sprintf_l, swprintf, _swprintf_l, __swprintf_l[^] function.
So you have to use something like

WCHAR szString[256];
swprintf(szString, sizeof(szString) / sizeof(WCHAR), L"%G", value);

But it would be better to use _snprintf_s, _snprintf_s_l, _snwprintf_s, _snwprintf_s_l[^] here:

TCHAR szString[256];
_sntprintf_t(szString, sizeof(szString) / sizeof(TCHAR), _T("%G"), value);

To get a double value back when reading the cell text use _tstof (atof, _atof_l, _wtof, _wtof_l[^]):

// double CDataDialog::GetItemText(HWND hWnd, int nItem, int nSubItem) const
double CDataDialog::GetItemDouble(HWND hWnd, int nItem, int nSubItem) const
{
    CString str = GetItemText(hWnd, nItem, nSubItem);
    return _tstof(str);
}

modified 20-Mar-17 9:01am.

lolici20-Mar-17 2:56

20-Mar-17 2:56

I did it but I got this: "no suitable constructor exists from double to ATL::CStringT wchar_t StrTraitMFC__DLL<wchar_t,atl chtraitsctr<wchar_t="">>>" on

CString str = GetItemText(hWnd, nItem, nSubItem);

If I don't turn data from string to double could I "pass" them in a text file after edit them on the list view? Smile | :)

Jochen Arndt20-Mar-17 3:00

20-Mar-17 3:00

Sorry, forget to rename it during copy & paste. Should be named GetItemDouble:.

C++

double CDataDialog::GetItemDouble(HWND hWnd, int nItem, int nSubItem) const
{
    CString str = GetItemText(hWnd, nItem, nSubItem);
    return _tstof(str);
}

lolici20-Mar-17 3:32

20-Mar-17 3:32

Thank you very much Sir!It was compiled fine!! I got a message about "Unhandled exception" when tried to write on second dialog but I must have made a mistake on code.Could I save editable data from list view on text file without converting them from string type?

Jochen Arndt20-Mar-17 3:39

20-Mar-17 3:39

Use the debugger to find out when the exception occurs and check the code lines that has been executed before.

You can write strings directly to text files when using appropriate file functions. But those will be then Unicode text files (when having a Unicode build) and the file class does no perform implicit conversion to ANSI text.

lolici20-Mar-17 8:02

20-Mar-17 8:02

Vielen Dank! Smile | :)

Victor Nijegorodov20-Mar-17 6:56

Victor Nijegorodov

20-Mar-17 6:56

Is there some very important reason for you to use in a MFC application plain Win32 macros/messages to handle List Control?
What is wrong to use CListCtrl Class methods?

lolici20-Mar-17 7:58

20-Mar-17 7:58

Yes!As I mentioned above I am looking for a way to save all editable data in list view in a text file.

David Crow20-Mar-17 9:52

David Crow

20-Mar-17 9:52

lolici wrote:
...I am looking for a way to save all editable data in list view in a text file.

What does that have to do with not using MFC?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

Crc 32 bit

yagokhan19-Mar-17 21:58

19-Mar-17 21:58

Hi I am trying to commucate with a sensor usimg 32 bit crc. I am using pre-built 32bit crc table. How can I implement error detection code? Sensor sends 38bytes of data with a header 0x93.

Jochen Arndt19-Mar-17 22:15

19-Mar-17 22:15

There is an error if the CRC send with the message is not the same as those calculated for the received message. So you have to

Receive message
Calculate CRC for received message
Compare with CRC which is part of the message

The final implementation depends on the used message format which should be part of the sensor documentation.

yagokhan19-Mar-17 22:20

19-Mar-17 22:20

thank you for your answer here is the code part of my project.

		for aye=bytePullIdx:(crcIdx-1) 
a = bitand(bitxor(byteBufferPtr(aye),bitshift(crc,-24)),hex2dec('FF'));
crc = bitxor(bitshift(crc,8),crcLookupTable2(a));

abowe byteBufferPtr is coming message (38bytes) crcLookupTable is pre-built table for crc polynom '04C11DB7'. after calculating crc I check if (crc==byteBufferPtr(crcIdx) condition to get the data.
Is there anything wrong here? because I could not get the right if condition here. I could not find the right crc value among the crc table values.
Thank you.

Richard MacCutchan19-Mar-17 22:57

Richard MacCutchan

19-Mar-17 22:57

You need to find out what the sensor uses to calculate its CRC.

yagokhan19-Mar-17 22:59

19-Mar-17 22:59

Actually I am working on code offline. I took 38byte of data starting with header and put it my code. The sensor is sensonor stim300

Richard MacCutchan19-Mar-17 23:19

Richard MacCutchan

19-Mar-17 23:19

I do not think anyone here can guess what data the device will produce. You should check the technical documentation for the device, or contact the manufacturer.

yagokhan19-Mar-17 23:22

19-Mar-17 23:22

The device produces 32bit crc with polynomial

0x04c11db7

What else do i need to ask?

Jochen Arndt20-Mar-17 2:36