|
There's a bit much here to look at so I haven't completely gone through the logic, but it seems that you're making clients on new threads and those clients never kill themselves so they're basically leaked.
|
|
|
|
|
i guess you are right
please check that code part
while (true)
{
counter += 1;
clientSocket = serverSocket.AcceptTcpClient();
handleClinet client = new handleClinet();
client.startClient(clientSocket, Convert.ToString(counter));
}
clientSocket.Close();
serverSocket.Stop();
it will never go to the close part
|
|
|
|
|
I don't see you close the connection or the NetworkStream. So, it may be one of the issues.
|
|
|
|
|
i'm using
using (SqlConnection conn = new SqlConnection(ConnStr))
{
conn.Open();
using (SqlCommand comm = new SqlCommand("Select id from T_SafeArea", conn))
{
}
conn.Close();
conn.Dispose();
}
|
|
|
|
|
you are right about closing the network stream and the clients
could you point out where in the code to do so
|
|
|
|
|
When you call GetStream, do it with a using clause. Put an {
And at the end of the method, the closing }
This would solve the issue.
|
|
|
|
|
i tried that it got worse it hang after starting by 2 minutes
|
|
|
|
|
Yeah... I didn't notice the GetStream was inside a while(true)... so you shouldn't dispose the stream at that moment.
Yet, I think I found your issue. You put the try / catch inside the while (true). That means that as soon as there is the first exception, your code will be actively rerunning and rethrowing exceptions forever.
So, the right thing would be to put the while(true) inside the try... actually, inside the using clause for the network stream. But if you want to test it without too many changes, simply put returns in your catch clauses and it should solve the eternal loop issue.
|
|
|
|
|
sorry for late replay
it didn't work
still 92% CPU after 20 min
with only 4 devices
i put stream.close inside the catch
i put clientsocket.close inside the catch the error was
cannot access a disposed object system.net.sockets.socket
should i use Async
Asynchronous Server Socket
|
|
|
|
|
It is not a matter of calling Dispose or Close in the catch. The problem is that you have an eternal loop and, inside the loop, you have a try/catch accessing an object that may be disposed.
That means:
You start running it OK. As soon as the client disconnects, you receive an exception, you catch it, maybe you close/dispose objects, it doesn't matter, the loop runs again, you try to access a disposed object, you get a new exception, you catch it, you dispose again (nothing changes) and you run again... infinitely.
So, with a while(true) and a try/catch inside the while, you will always make the application consume 100% CPU when you have as many disconnected clients as you have CPUs (that is, on a 4-cpu machine, the CPU will go up to a total near of 100% as soon as 4 clients disconnect, as you simply don't allow the code to exit the eternal loop).
|
|
|
|
|
Hi, Avoid creating too many instances using new keyword. If you still need then dispose them once used immediately.
ravindrapc
|
|
|
|
|
hi all I developing a program in c#, I have two form. in the form1 I have a texbox, label and combobox, and in the second form I have a button the name cleaning and the class clean.I need is calling me class clean with me button clean and cleaning the form 1
|
|
|
|
|
Sorry?
That doesn't make a whole lot of sense - what does your Clean class have to do with Form1?
If you mean "I want to press a button on Form2, and it empties the data on Form1" then it depends who opened what.
IF Form1 opened Form2, then you need an event in Form2, which is handled in Form1: Transferring information between two forms, Part 2: Child to Parent[^] - Form1 then clears out it's own fields.
If Form2 opened Form1, then use a method in Form1 which is called from Form2, and which clear out teh info: Transferring information between two forms, Part 1: Parent to Child[^] - the example uses a property, but a method is more appropriate.
If neither of them knows about the existence of the other (i.e. both were opened from Form3) then combine the two methods: Transferring information between two forms, Part 3: Child to Child[^]
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
in my form1 I have a texbox and I want to clean from my button clean in my form 2 whit my class clean
I think is the is the second opcion
|
|
|
|
|
Assume you create a Windows Class Library, 'MyLibrary'; you create a Windows Form project 'MyProject;' you add a reference to MyLibrary's .dll to MyProject.
If MyLibrary has a static variable, 'MyVar,' every instance of MyLibrary in MyProject will, of course, access the one-and-only MyVar.
However, what if you want each instance of MyLibrary to store a reference to itself that can be accessed from outside the scope of the instance ... as if each instance of MyLibrary had a unique static value ?
Perhaps there is a way using separate Application Contexts ?
Will add code samples, shortly (hardware problems, here).
thanks, Bill
«There is a spectrum, from "clearly desirable behaviour," to "possibly dodgy behavior that still makes some sense," to "clearly undesirable behavior." We try to make the latter into warnings or, better, errors. But stuff that is in the middle category you don’t want to restrict unless there is a clear way to work around it.» Eric Lippert, May 14, 2008
|
|
|
|
|
I'm not sure I get how that would work. If you are accessing an instance from outside that instance, how could you tell which instance you were actually accessing?
The only thing I can come up with that comes close, that I actually have used in the past, is a static Dictionary, where the keys are some sort of instance identifier, and the value is the instance itself. The constructor adds itself to that dictionary, and Dispose or some sort of release method removes it again.
Cheers,
Mick
------------------------------------------------
It doesn't matter how often or hard you fall on your arse, eventually you'll roll over and land on your feet.
|
|
|
|
|
Maybe I don't get it but there is only one instance of a DLL in a process.
However, a DLL might use Thread Local Storage (Windows)[^] so that each thread of a process has access to it's own data.
|
|
|
|
|
You're over thinking it. A static variable has nothing to do with any instance of a class, the point of static means it's tied to the Class and not the Instance.
For example
class ClassName {
static string VariableName;
}
it wouldn't matter if you said..
ClassName newInstance = new ClassName();
newInstance.VariableName = "test";
or if you said
ClassName.VariableName = "test";
In both instances, you're dealing with the same thing.
If you want to have a variable tied to an instance, you shouldn't mark it as static. In that way, each instance of ClassName would have it's own instance of VariableName
Hope that helps!
|
|
|
|
|
DataSet ds = new DataSet();
conn_DB();
OracleCommand Cmd = null;
Cmd = new OracleCommand();
Cmd.Connection = mConn;
try
{
string sql = "SELECT * FROM USER_INFO WHERE USE_UID='" + userid + "'" + " AND PWD='" + userpw + "'";
Cmd.CommandText = sql;
OracleDataAdapter adapter = new OracleDataAdapter(Cmd);
adapter.Fill(ds);
}
catch (OracleException e)
{
return null;
}
How to fix "
System.InvalidOperation.Exception"
or Exception "
modified 7-Nov-16 2:36am.
|
|
|
|
|
You set Cmd to Null, create a new command called navicallCmd, set it up then pass Cmd as the argument to the adapter...try passing navicallCmd.
|
|
|
|
|
Just to add to what Micheal says, don't do it like that either: Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
|
I'm using parallel arrays to display names and grades of students. I am stuck at displaying the arrays. I get System.String[] instead of the input value I want. This is my code what am I doing wrong:
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
namespace Parrallel_Arrays {
public partial class frmGrades : Form {
String nameString = "Aaron Ben Carmelina Dorethy Erinn Karin " +
"Lester Mitsue Nichol Ria Sherie Zachary";
String assignmentsString = "44 92 100 100 100 97 100 95 100 0 100 100 " +
"95 95 97 90 100 95 100 100 100 100 100 75 " +
"98 100 65 0 100 100 100 100 100 100 95 75 " +
"85 100 0 50 100 95 90 0 80 100 100 100";
String[] arrayNames = new String[12];
String[,] arrayGrades = new String[4, 12];
String[] arrayAverage = new String[12];
public frmGrades() {
InitializeComponent();
}
private void frmGrades_Load(object sender, EventArgs e) {
}
//Method to Fill Array
private void FillArray(String[] name, String[,] grade) {
String[] arrayNames = { nameString };
String[,] arrayGrades = { { assignmentsString } };
String[] arrayAverage = { };
char[] separator = new char[] { ' ' };
String[] tokens = assignmentsString.Split(separator);
String[] token2 = nameString.Split(separator);
foreach (String token in tokens) ;
}
//Method to Display Array of names and assignment grades
private void DisplayArray(String[] nameString, String[,] assignmentsString) {
for (int i = 0; i < nameString.Length; i++) {
lbxDisplay.Items.Add(nameString[i] + " ");
}
}
|
|
|
|
|
String[] arrayNames = { nameString };
You cannot assign a string to an array like that. You must create the array first, or use String.Split[^] to separate the individual fields.
|
|
|
|
|
Just to back up what Pete Richard says, this code:
String[] arrayNames = { nameString };Doesn't do what you think.
When you use this construct:
string[] x = {...}You are telling the system that each item inside the "{" and "}" is to be treated as a single string - so if it isn't a string already, the system will apply an implicit conversion:
String[] arrayNames = { nameString.ToString() };Since nameString is an array and the Array class doesn't provide an explicit ToString override, the default object ToString implementation is used instead, which returns the name of the class instead of the content: "System.String[]"
As Pete says, use Split instead:
String[] arrayNames = nameString.Split(' ');
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
modified 7-Nov-16 6:51am.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
