|
So the function call is from outside the class in the interrupt?
That will be fun trying to make sure the class in a stable running state not starting or closing, before you start passing interrupts into it. You will get a nice big crash if you pass an interrupt into the class and it isn't stable 
In vino veritas
modified 10-Oct-16 10:42am.
|
|
|
|
|
The original code has ISR collecting the (video ) data and when it detects end of frame another function does the actual video output to the LCD.
I put the ISR code in one class and the output to LCD in another class.
Now both classes inherited from Print class so I can do code debugging etc.
There are other hardware inheritances - USB , SPI but that is all working.
That is how the compound inheritance came to be, and that is basically working.
The issue is the link between the ISR and LCD class.
I was hoping for another upper layer of class to be the controlling class, but that seems to be convoluted way to do it.
I think I have a better grasp on using function pointers and will try to just call from one class to another using pointers.
BTW the hardware interrupt is continuous and there are some checks in the actual interrupt handler and ISR functions making sure it is running and getting correct data / USB packages.
Thanks to the group I think I got the basics, now it is just a matter of organizing the puzzle.
|
|
|
|
|
What you have just said above is what makes what you are doing weird to us.
There is no need to inherit a print class just to print, you just hold a print
class instance in your class data and initialize it and you can print to it at
any time you need.
You don't inherit things just so you can use them. You only inherit things you
need to change the behaviour. Your class interface is just bloating up and
you gain exactly zero as you could already print what you need using the
original class.
So let me ask the specific question does your class change the print interface
it inherits in any way? If you answer no then you don't need to inherit it just
create an instance of the class in your class.
In vino veritas
|
|
|
|
|
The idea was - lazy man way .
As written originally - the LCD class was derived / inherited from class Print.
All usage of class Print was just calling the Print methods via inheritance, directly.
To do what you suggest , which make perfect sense, I would have to change my other classes using Print methods to use the Print object. That is why I though multiple inheritance would work. It does , but things get tangled.
And yes, I know how to do "find and replace ".
I also have these "chain" dependencies and not sure how to tackle that using your method.
I guess going from "flat" implantation to OOP is not that easy, but I hope I have Lerner few things in process.
Would using "friend" class be of any advantage? Not that I need another headache.
And no, my usage of inheritance does not change anything in class itself , they all basically just change / modify the data for their usage.
|
|
|
|
|
You said ... "To do what you suggest , which make perfect sense, I would have to change my other classes using Print methods to use the Print object."
No you don't all you need to do is create a printer class at initialization, lets say you have a private variable printer class called "ThePrinter". All it means is at the moment you are calling the inherited methods of the printer class directly so xyz_func(); so instead of that it would become ThePrinter.xyz_Func(); Really from a code point it's that simple a small change in the constructor and the name of the held printer infront of the printer class methods you are directly calling.
Besides making your interface a hell of a lot smaller and removing bloating code and data in your class it also allows you to do things you can't do like change the printer device on the fly or pass the printer class to another object or a block of code. If you want to share the printer, so two different classes can write to the exact same printer (which may be likely in your case), you get one class to make the printer and then simply make a function on that class so the other classes can get a pointer to the printer. So the class that has the printer does this via a function GetMyPrinter
class IHavePrinter{
public:
PrinterClass* GetMyPrinter(void);
private:
PrinterClass ThePrinter;
}
IHavePrinter:: PrinterClass* GetMyPrinter(void){
return(&ThePrinter);
}
That is the point of keeping classes detached so you can do things you can't possibly do if you bind them into your object inheritance and you stop the vicious cross connection you are getting. I think most of your dependency issues is actually cause by your inheritance scheme and wouldn't exist if you did it properly.
You could just have exposed the printer object as a public but the few lines to pass it on a function means that later on if you want to track who is using the printer or know if it's in use you can modify that function to track that etc. So a bit of forward planning built into the concept and trying to keep the classes as detached as possible not accessing each others fields.
In vino veritas
modified 11-Oct-16 23:43pm.
|
|
|
|
|
Thanks, so in my simple words - instead of using multiple inheritance in downstream fashion doing it this way is sort of in reverse - the printer class goes first.
Your are very helpful and much appreciated.
Thanks.
Cheers Vaclav
|
|
|
|
|
Yes we are putting composition over inheritance, so our classes are trying to achieve multiple
and flexible behaviour (reusing as much code as possible) rather than inheritance from a base
or parent class.
I would also add there is one final thing you will be able to do if you go that path which you
can't possibly do with your current scheme, which is to thread the classes or at least the one
that had the old ISR code to help its response and speed.
In vino veritas
|
|
|
|
|
I am still not too comfortable with passing variables to
constructor, but eventually I'll get over it.
But this got me stumped - never heard of having const used this way. Why?
So how do you read this -X(x) with relation to following function double x()?
Please if this is too basic for you just let someone else answer, OK?
I am asking for help and have no intent to waste your time on trivia.
Thanks
class Point2d{
public:
Point2d() {}
Point2d(double x, double y)
: X(x), Y(y) {}
double x() const { return X; }
double y() const { return Y; }
/**
* Returns the norm of this vector.
* <a href="http://www.codeproject.com/Members/return">@return</a> the norm
*/
double norm() const {
return sqrt( X * X + Y * Y );
}
void setCoords(double x, double y) {
X = x; Y = y;
}
|
|
|
|
|
Using const that way in the declaration of the method tells the compiler that the method is able to be called on constant instances of that object. It indicates that the object is not altered in any way by calling that method. Examples using the class defined above:
const Point2d p1(2,3);
Point2d p2(4,5);
p1.setCoords(3,2);
p2.setCoords(5,4);
double n = p1.norm();
Cheers,
Mick
------------------------------------------------
It doesn't matter how often or hard you fall on your arse, eventually you'll roll over and land on your feet.
|
|
|
|
|
|
The link is broken.
Thanks anyway
|
|
|
|
|
It was working this morning, because I read the content to see that it answered the question. Most likely a problem at Microsoft's end; keep trying. Or just use Google to find an alternate page.CodeProject bug, link now fixed.
modified 10-Oct-16 5:02am.
|
|
|
|
|
There's a colon missing between the "https" and "//" in your link - but it's there in the link text. Maybe this a CodeProject bug?
|
|
|
|
|
Thanks, there is a message in Bugs & Suggestions about this, but it is supposed to be fixed now. I will edit my response.
|
|
|
|
|
*i am also new to C++*
i'm not able to figure out where are X and Y defined
i mean the capital ones.
|
|
|
|
|
Ratul Thakur wrote:
i'm not able to figure out where are X and Y defined
They aren't. The OP's code is incomplete and thus will not compile.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
how do you initialize this CString array in msvc mfc 2015?
CString weekday[] = {"Sun", "Mon", "Tue", "Wed", "Thr", "Fri", "Sat"};
It worked from msvc++ 2010 but does not work for 2015.
Thanx in Advance
|
|
|
|
|
By not working, do you mean it doesn't compile, doesn't show the values you thought, or someting other?
|
|
|
|
|
It will not compile using msvc++ 2015
|
|
|
|
|
Member 9411471 wrote: It will not compile using msvc++ 2015
And what compiler error does it produce?
|
|
|
|
|
CString weekday[] = {CString ("Sun"), CString( "Mon")...};
|
|
|
|
|
OK, this is really simple question, with example code to boot.
The function pointer declaration is this
void (*gpf_isr)(void) = (0UL);
It is used by this function
void UOTGHS_Handler( void )
{
if (gpf_isr)
gpf_isr();
}
and I access it like so
extern void (*gpf_isr)(void);
then I assign my local poiter / version of the function
gpf_isr = ( object ) . UTOGHS_Handler;
The silly question why this also get pass the compiler , no errors
extern void (*gpf_isr)(void) = (0UL);
The pointer gets reassigned , but ...
|
|
|
|
|
|
That is pretty clear that defining the variable is OK, but if optioned GCC will give a warning.
Kind like deleting a file and being ask "are you sure?"
Thanks
.
|
|
|
|
|
Yes. You may find (on the web) folks arguing that warning is not legitimate.
In a clean implementation you don't qualify with extern the variable in the source file wherein you define it.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
