|
Don't concatenate strings to form your database queries - use Parameterised queries.
For example:
cmd.CommandText =
"insert into tbElogsheet(Allocate_id,Number_plate,Depart_date,Destination,Department,Traveller,NAME,km_read_dept,km_read_arr,Departure_time,Arrival_time,Over_time,Accident) VALUES (@code1,@code2,@code3,@code4,@code5,@code6,@code7,@code8,@code9,@code10,@code11,@code12,@code13)"
cmd.Parameters.AddWithValue("@code1", code1)
cmd.Parameters.AddWithValue("@code2", code2)
cmd.Parameters.AddWithValue("@code3", code3)
cmd.Parameters.AddWithValue("@code4", code4)
cmd.Parameters.AddWithValue("@code5", code5)
cmd.Parameters.AddWithValue("@code6", code6)
cmd.Parameters.AddWithValue("@code7", code7)
cmd.Parameters.AddWithValue("@code8", code8)
cmd.Parameters.AddWithValue("@code9", code9)
cmd.Parameters.AddWithValue("@code10", code10)
cmd.Parameters.AddWithValue("@code11", code11)
cmd.Parameters.AddWithValue("@code12", code12)
cmd.Parameters.AddWithValue("@code12", code13)
cmd.ExecuteNonQuery()
This might well cure your problem.
If it does not then use the Debugger to determine which line is causing the problem and let us know.
|
|
|
|
|
Hi chill,
i am getting same error after modified.
Public Sub frmElogsheet_SAVE()
btneditelog.Enabled = False
btndelelog.Enabled = False
Dim conn As New SqlConnection
Dim cmd As New SqlCommand
' Dim dr As SqDataReader
conn = GetConnect()
conn.Open()
cmd.Connection = conn
Try
Dim code1 As Integer
Dim code2, code4, code5, code6, code7, code13 As String
Dim code8, code9 As Integer
Dim code3, code10, code11, code12 As String 'date
code1 = txtallocateelog.Text
code2 = txtvehicleElog.Text
code3 = txtRequestdateElog.Text
code4 = txtDestElog.Text
code5 = txtdeptElog.Text
code6 = txttravellerElog.Text
code7 = txtdvr2.Text
code8 = txtkmreaddept.Text
code9 = txtkmarr.Text
code10 = dtpdepttime.Text
code11 = dtparr.Text
code12 = dtpovertime.Text
code13 = Combacci.Text
'g900 = code2 'it will pass value to accident form
'cmd.CommandText = "insert into tbElogsheet(Allocate_id,Number_plate,Depart_date,Destination,Department,Traveller,NAME,km_read_dept,km_read_arr,Departure_time,Arrival_time,Over_time,Accident) VALUES (" & code1 & ",'" & code2 & "','" & code3 & "','" & code4 & "','" & code5 & "','" & code6 & "','" & code7 & "'," & code8 & "," & code9 & ",'" & code10 & "','" & code11 & "','" & code12 & "','" & code13 & "')"
'cmd.ExecuteNonQuery()
cmd.CommandText ="insert into tbElogsheet(Allocate_id,Number_plate,Depart_date,Destination,Department,Traveller,NAME,km_read_dept,km_read_arr,Departure_time,Arrival_time,Over_time,Accident) VALUES (@code1,@code2,@code3,@code4,@code5,@code6,@code7,@code8,@code9,@code10,@code11,@code12,@code13)"
cmd.Parameters.AddWithValue("@code1", code1)
cmd.Parameters.AddWithValue("@code2", code2)
cmd.Parameters.AddWithValue("@code3", code3)
cmd.Parameters.AddWithValue("@code4", code4)
cmd.Parameters.AddWithValue("@code5", code5)
cmd.Parameters.AddWithValue("@code6", code6)
cmd.Parameters.AddWithValue("@code7", code7)
cmd.Parameters.AddWithValue("@code8", code8)
cmd.Parameters.AddWithValue("@code9", code9)
cmd.Parameters.AddWithValue("@code10", code10)
cmd.Parameters.AddWithValue("@code11", code11)
cmd.Parameters.AddWithValue("@code12", code12)
cmd.Parameters.AddWithValue("@code13", code13)
cmd.ExecuteNonQuery()
MsgBox("ELOGSHEET Added Sucessfully")
'frmElogsheet_clear() 'clear elogsheet items after saving
'txtkmreaddept.Text = g101
Catch ex As Exception
MsgBox(ex.Message)
End Try
'conn.Close()
End Sub
|
|
|
|
|
|
See the replies from Sacha and Richard. Fix the line
code1 = txtallocateelog.Text and also the lines for Code and Code.
Alternatively use the text box values for the cmd.Parameter values and you should not have to do any parsing or converting
|
|
|
|
|
Hi Team,
Now issue resoved.Thanks for your valauable support.
Regards
kishore
|
|
|
|
|
I'm not one to hate on VB6, but today's gonna be an exception. Also I want this message to be on the internet so the next poor swine who gets this message might be lucky enough to see this post.
I recently added some functionality to an OCX in our legacy VB6 system. The OCX compiled without errors, but any program that used it could no longer load it. When I tried to reference it in a new project, I got the error "File not found: 'C:\Users\???\AppData\Local\Temp\VBB685.tmp'".
About a week of tearing my hair out followed. I'd just upgraded to windows 10, I'm still not sure if that's relevant.
The thing is, I added a property. Removing it fixed the bug. Adding ANY property broke it again. Eventually I broke compatibility, made two functions which were Public but could/should have been Private .. um, Private, and added my property again. Now it's all good.
I can only assume there's some sort of really small limit on the number of exposed properties of a VB6 OCX. If this is/was common knowledge, well then what the hell google :p
|
|
|
|
|
There is no limit on the number of properties. I would guess, however, that it had something to do with your compatibility setting in the project. I'm not going to try and guess what because it's been about 15 years since I last touched VB6. Yay me!
|
|
|
|
|
By adding a property you broke the "contract" between the OCX and it's clients. Forcing the break compatibility is the only way (AFAIK) to get around it without supplying another interface. You will probably also have to rebuild any project that uses the OCX
|
|
|
|
|
Hi,
I need the minimum margin in vba excel or word.
I know how to set it in vba and in dot net. But I can't find the minimum in vba.
I guess I will need some API but if I find something usefull I must know the hdc and that I also can't find that. in vb6 there was printer.hdc but not in vba.
Who can help me?
Jan
|
|
|
|
|
Minimum margins are dependent on the print device that you are sending the output to. I would guess you need to look at printer properties.
|
|
|
|
|
Hi,
I know but I have looked and can't find it.
Our old printers have lesser margings that the new. now we have AGAIN different margings so I want to use the printer minimum possible margin and >.5cm so when I can read them a simple if then, structure will help me. but now I can't read it.
remember it's in VBA 
Jan
|
|
|
|
|
Sorry, I am not a VBA expert, and this forum is mostly for VB/VB.NET questions.
|
|
|
|
|
I know but this the best forum I know
|
|
|
|
|
There are forums dedicated to VBA, you should try one. Just Google something like "VBA printer settings", and see what it gets you.
|
|
|
|
|
hello ...
can you help me please
how can change font size in richtextbox ,if selection some text in rtb have a more than one font name
if rtb.selection isnot nothing then
rtb.selectionfont=new font(rtb.selection.fontfamily,cint(combobox1.selecttext))
else
this statment can not programming
endif
|
|
|
|
|
|
Member 12436170 wrote: if selection some text in rtb have a more than one font name
You have the selection-start, and its length.
Select the first character, get the name of its font, and increase its size. Repeat for the next character.
Bonuspoints if you keep increasing the selection if the next character has the same font.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
Hi.
I got this error and can't seem to solve it. I've changed the code but it gives a error message that I have coded into the program. I've read most of the articles here about it but just can't figure it out. This is the line of code; msgBox(sendWeightRequest). I have changed it to this;
Private Sub btnGet_Click(sender As System.Object, e As System.EventArgs) Handles btnGet.Click
If sendWeightRequest() = "ERROR" Then
WriteLine("Cannot read weight...")
Else
MessageBox.Show(sendWeightRequest)
End If
End Sub
When I run the program it doesn't give the Modules error message but another ones. Can someone help please?
|
|
|
|
|
Where is the variable or method sendWeightRequest? In the first reference you are using the name as a method, and in the second as a property. So which is it?
|
|
|
|
|
Function sendWeightRequest()
If weightRequested = "ERROR" Then
Return ("CANNOT READ WEIGHT...")
Else
Return weightRequested
Try
scale_scannerPort.WriteLine("S334" & vbCr)
Catch ex As Exception
End Try
End If
End Function
Hope this answers your question. On my laptop I get an error at 'Catch ex ...'which reads: ' Unused local variable: 'ex'.', but on my DT I don't get that error and I'm using the same versions of VB on both machines.
|
|
|
|
|
Yes that answers your previous question, but you are still using the wrong syntax in your call to MessageBox.Show. As to the error above, you are attempting to catch an exception but you never use the ex variable. However, it does not really matter since you will never get to that Try/Catch block in the firstplace.
|
|
|
|
|
Which kind of Datatype do you get from SendWeightRequest ?
If it isn't a string you first have to convert it into String. Messagebox want to get a String as Message. So please try :
MessageBox.Show(sendWeightRequest.toString)
|
|
|
|
|
Hi.
I've tried it but it gives the same error message.
|
|
|
|
|
OK ... once again :
Which kind of Datatype do you get from SendWeightRequest(-Function) ?
|
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
