|
Thank you Gerry. I did both. No Difference. I appreciate your response. Any followup and I'll be looking. I'm a few days into this problem and I have gone nowhere. Rare for me and a total waste of my time. Appreciate your advice. Pat
|
|
|
|
|
Maybe check your path name again (your post has a "blank\" in the report's file name).
The "embedded resource name" depends on the namespace; it's not the same as a report's "file name / path".
|
|
|
|
|
Thanks Gerry. I removed the space. No difference. I put a in complete long hand path id. No Difference. No Errors. Datagrid is fully populated. I tried alternating between dataset and dataTable. Nothing. No errors. Just sits there blank. I almost feel angry that there is no easy way to take the data that is just sitting there in the grid and moving it into the report. This is do-able with Excel. But I have chosen not to do that in this case. I did not want to use Crystal Reports (never liked them), and now I am not sure if that will work either, but I certainly need a solution. I regularly use Code Project (since Y2K days), but this may be the first time in over 10 years that I cannot neither get nor figure out a solution. I greatly appreciate your time and expertise. I'll keep looking. Thank You. Pat
|
|
|
|
|
I'm retrieving data from using an SQLiteDataAdapater. Because one of the fields is a date, and WPF date fields won't except null values, I'm trapping the error and continuing processing. If the search entry contains a date all of the data is returned. If the search entry does not have a date (null), I'm only getting the first three fields of data.
104, 14, 0, 2014-01-15, 1, MB3,...
103, 12, 0, (null), , , ,...
Database call:
string sql = @"SELECT * FROM " + table + " WHERE " + table + "ID = " + id;
SQLiteCommand com = new SQLiteCommand(sql, conn);
dataTable = new DataTable(table);
sqliteDataAdapter = new SQLiteDataAdapter(sql, conn);
sqliteDataAdapter.FillError += new FillErrorEventHandler(FillError);
sqliteDataAdapter.Fill(dataTable);
FillError:
protected static void FillError(object sender, FillErrorEventArgs args)
{
DataRow theRow;
switch (args.DataTable.ToString())
{
case "Camera":
theRow = args.DataTable.Rows.Add(new object[] { args.Values[0], args.Values[1], args.Values[2], null, args.Values[4], args.Values[5], args.Values[6], args.Values[7] });
args.Continue = true;
return;
case "Equipment":
theRow = args.DataTable.Rows.Add(new object[] { args.Values[0], args.Values[1], args.Values[2], null, args.Values[4], args.Values[5], args.Values[6] });
args.Continue = true;
return;
case "Lens":
theRow = args.DataTable.Rows.Add(new object[] { args.Values[0], args.Values[1], args.Values[2], null, args.Values[4], args.Values[5], args.Values[6], args.Values[7], args.Values[8], args.Values[9], args.Values[10], args.Values[11] });
args.Continue = true;
return;
case "Software":
theRow = args.DataTable.Rows.Add(new object[] { args.Values[0], args.Values[1], args.Values[2], null, args.Values[4], args.Values[5], args.Values[6], args.Values[7] });
args.Continue = true;
return;
}
}
What am I doing wrong?
|
|
|
|
|
Robert Kamarowski wrote: What am I doing wrong?
Well, the most obvious thing is that you're writing code which is vulnerable to SQL Injection[^].
The ID should be passed as a parameter. Table and column names can't be passed as parameters, so you should verify that the name is one of the expected values, and cannot be modified by the user. Alternatively, since you only seem to have four tables, use a specific query for each table.
DataTables can accept null values in columns of any type. You shouldn't get an error when you try to load a null date into a DataTable, so I'm not sure that your FillError handler is actually doing anything.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
The FillError handler is definitely working. I've walked through the code and it works. The error is happening during the Fill() method.
I don't think Injection is the problem here. The code works fine, except for when there is a date. If I run the search against SQLiteManager there are no errors. This is a self-contained application and does not go over the internet.
VS 2015
|
|
|
|
|
Robert Kamarowski wrote: I don't think Injection is the problem here
He's not saying that it is: he's giving you a serious warning that your code is wide open to accidental or deliberate damage (or deletion) of your database, and that it needs to be fixed throughout the whole of your application as a matter of extreme priority. It doesn't matter if the app is internet or local to "just your PC" - SQL injection is a real risk. Google "Bobby Tables" one day.
Your truncated data is exactly what you should get: the fill error terminates the fill operation.
I would change the DB design to not use null dates, but use the minimum sensible value instead.
Failing that, I'd use a query that didn't return null values, replacing them at the SQL end with a "sensible" default.
Once I'd fixed my code to avoid SQL Injection, of course.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
Robert Kamarowski wrote: This is a self-contained application and does not go over the internet.
That's nice. Most damage to databases occurs from inside the company, not outside, for a multitude of reasons. Don't get into the habit of writing bad code because you think "nothing's going to happen". You don't know the future of your code or application and you could end up putting this code into an environment where the risks are increased.
|
|
|
|
|
Robert Kamarowski wrote: The error is happening during the Fill() method.
OK, what's the error?
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Error:
String was not recognized as a valid DateTime
|
|
|
|
|
That doesn't sound like a SQL error. It sounds more like an error from your C# code, trying to convert an invalid string value to a DateTime value.
Having said that, I don't know what SQLite will do if you pass a null or empty string to the datetime function, or if you pass in a string that's not in the correct format.
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
You are storing your dates in the DB as strings as well? 
That's something else you need to change. And it's going to take longer because you have existing data in there that isn't a valid datetime value.
So create a new table using DATETIME values this time, and a program to transfer each row one-by-one after they have been converted, and log the rows that fail so you can manually work out which ones you need to fix. Fix 'em, and then delete the old table, and rename the new. Then change your app to insert DateTime values directly via parameterised queries.
Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...
|
|
|
|
|
The dates are stored as DATE type.
|
|
|
|
|
The date are of Date type, and NULL is allowed. However, from a previous application/language, many of the Date fields are set to an empty string, and not null. This application is under development, so I have options  Is there a way to identify an empty string during the Fill() method? I haven't found anything in my online searches, so I'm hoping someone has a trick up their sleeve...
|
|
|
|
|
Is there a DATE type in SQLite now? 
SQLite does not have a storage class set aside for storing dates and/or times. Instead, the built-in Date And Time Functions of SQLite are capable of storing dates and times as TEXT, REAL, or INTEGER values.
And if you're not using SQLite, why are you using the SQLiteConnection, SQLiteCommand and SQLiteDataAdapter classes?
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Yes I'm using SQLite. SQLiteManager has a DATE type.
|
|
|
|
|
I'm trying to code this: (Sorry, formatting is all screwey)
public Task<Dictionary<int, string>> GetAllNamesAsync()
{
Dictionary<int, string> dict = new Dictionary<int, string>();
<pre>
Task<IList<InternalProviderViewDto>> task = Client.GetAsync(new InternalProviderSearch());
Task x = task.ContinueWith(t =>
{
IList<InternalProviderViewDto> results = t.Result;
foreach (var result in results)
{
dict.Add(result.Id, result.Name.ToString());
}
});
return //<=== WHAT GOES HERE???
}
I want to return the dictionary that I populated, but I'm not sure how to code this right.
Thanks
If it's not broken, fix it until it is
|
|
|
|
|
Try this:
public Task<Dictionary<int, string>> GetAllNamesAsync()
{
Task<IList<InternalProviderViewDto>> task = Client.GetAsync(new InternalProviderSearch());
return task.ContinueWith(t => t.Result.ToDictionary(i => i.Id, i => i.Name));
}
If you're using .NET 4.5, you could use async and await instead:
public async Task<Dictionary<int, string>> GetAllNamesAsync()
{
IList<InternalProviderViewDto> results = await Client.GetAsync(new InternalProviderSearch());
return results.ToDictionary(i => i.Id, i => i.Name));
}
"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer
|
|
|
|
|
Damn my slow sickly fingers today! You beat me by 3 minutes.
|
|
|
|
|
That did it. Thanks
If it's not broken, fix it until it is
|
|
|
|
|
Well, you're saying that GetAllNamesAsync() should be returning a Task, which returns a Dictionary<>. With the code, as written, there's nothing you can put in there to fix this. The whole method has to be rewritten a bit.
The second task you create, with ContinueWith doesn't specify a return type (void), but it looks like you're trying to return the Dictionary<> from that task, so it needs to be changed to specify that return type. I think you're looking for something more like this:
public Task<Dictionary<int, string>> GetAllNamesAsync()
{
Task<IList<InternalProviderViewDto>> task = Client.GetAsync(new InternalProviderSearch());
Task<Dictionary<int, string>> x = task.ContinueWith<IDictionary<int, string>>(t =>
{
IList<InternalProviderViewDto> results = t.Result;
Dictionary<int, string> dict = new Dictionary<int, string>();
foreach (var result in results)
{
dict.Add(result.Id, result.Name);
}
return dict;
});
return x;
}
|
|
|
|
|
I went with Richards answer as it's shorter, but your also works.
Thanks
If it's not broken, fix it until it is
|
|
|
|
|
His is definitely shorter and better. I just kept my example in the context of the code you already wrote.
|
|
|
|
|
Message Removed
modified 8-Dec-15 2:03am.
|
|
|
|
|
Message Removed
modified 8-Dec-15 2:03am.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
