C#

public static List<SocketStructure> GetHostAddressesList() {
  lock(m_locker) return m_HostAddress.ToList();
}

public static SocketStructure[] GetHostAddressesList() {
  lock(m_locker) 
  {
    List<SocketStructure>tmp = new   List<SocketStructure>tmp();
    for(int i = 0; i<m_HostAddress.Count(); i++)
    {
        SocketStructure s = new SocketStructure();
        s.IP = m_HostAddress[i].IP; //IP is string type -  but am I copying reference here again????
        s.port =  m_HostAddress[i].port; 
        tmp.Add(s);
    }
    return tmp.ToList();
  }
}

public static List<SocketStructure> GetHostAddressesList() {
  lock(m_locker) 
  {
    List<SocketStructure>tmp = new   List<SocketStructure>();
    for(int i = 0; i<m_HostAddress.Count(); i++)
    {
        SocketStructure s = new SocketStructure();
        s.IP = m_HostAddress[i].IP; 
        s.port =  m_HostAddress[i].port; 
        tmp.Add(s);
    }
    return tmp; // note: not needed to use .ToList() here
  }
}

Member 12061600 wrote:

PS. (Same applies for strings I guess as it does with ints, since string are immutable)

Member 12061600 wrote:

PPS Just started thinking indeed returning reference to object even if you have locks inside getters is rather tricky - because some other thread might change contents of the reference type, and if you are left with the reference which you retrieved above you will see different results depending how other thread modifies it

Member 12061600 wrote:

So when I am returning value types - it is fine?

Member 12061600 wrote:

But if I return reference type I better make a deep copy, that is better practice you say right?

struct socket {
  string ip;
  int port;
}

Member 12061600 wrote:

I will stick to my approach then ...