C / C++ / MFC

6-May-03 3:37

Hi all,

I'm trying to find and load a resource from another application. Here's the code I'm using:

HINSTANCE hToDLL;
HRSRC hsrc;
hsrc = FindResource(GetModuleHandle(app),icon,RT_ICON);

where app = "someapp.exe" and
icon = "IDI_ICON3"

This ALWAYS returns a NULL pointer, so it's always failing and the GetLastError always gives me a:

1813 The specified resource type cannot be found in the image file. ERROR_RESOURCE_TYPE_NOT_FOUND

Now I know the resource exists in the application I'm trying to get at, so what am I doing wrong?? Do I need to call LoadLibrary first? I don't think I should have to.

Any insights, help, suggestions, comments are greatly appreciated. Thanks!
Dan

David Crow6-May-03 4:06

6-May-03 4:06

The GetModuleHandle() function retrieves a module handle for the specified module if the file has been mapped into the address space of the calling process. Had you checked the return value of it, rather than immediately calling FindResource(), this might have been evident.

will13836-May-03 4:34

6-May-03 4:34

DavidCrow wrote:
The GetModuleHandle() function retrieves a module handle for the specified module if the file has been mapped into the address space of the calling process. Had you checked the return value of it, rather than immediately calling FindResource(), this might have been evident.

Gotcha,

I understand now, but then what do I need to do to map the file into the address space? Call LoadResource?

Thanks!

Dan

David Crow6-May-03 4:39

6-May-03 4:39

HMODULE hModule;
HRSRC hResource;

hModule = LoadLibrary(...);
if (NULL != hModule)
{
    hResource = FindResource(hModule, ...);
    if (NULL != hResource)
    {
        LoadResource(hResource, ...);
    }

    FreeLibrary(hModule);
}

will13836-May-03 4:44

6-May-03 4:44

Thanks,

I'll try that and report back

basementman6-May-03 4:50

basementman

6-May-03 4:50

Since the module is an EXE, you may want to use the LoadLibraryEx() function instead, passing LOAD_LIBRARY_AS_
DATAFILE for the Flags parameter. This will prevent any calls to unresolved externals (like DllMain) and prevent the loader from loading any dependent dlls that the EXE imports.

will13836-May-03 5:16

6-May-03 5:16

Ok,
I'm further in my understanding, but still no further in a solution. Here's what I have now:

HMODULE hModule;
HRSRC hResource;
sprintf(buff,"%s.exe",app);
hModule = LoadLibraryEx(buff,NULL,LOAD_LIBRARY_AS_DATAFILE);
if (NULL != hModule){
hResource = FindResource(hModule,"IDI_ICON3",RT_ICON);
if (NULL != hResource) {
IUXLogData("the resource exists\n",TRACE1);
//LoadResource(hResource, ...);
} else if ( NULL == hResource ) {
sprintf(buff,
"the %s app is not up to date with error %d\n",
app,
GetLastError());
IUXLogData(buff,IUX_ERROR);
}
FreeLibrary(hModule);
}

I'm still getting an 1814 error though. Still unsure why I am. Is the "IDI_ICON3" or the RT_ICON the wrong stuff? the ICON resource for my test is IDI_ICON3 and I'm sure its in the app I'm trying to open, so I'm confused as to why I'm seeing this.

Any suggestions, insight, comments are greatly appreciated

Thanks!

Dan

basementman6-May-03 5:24

basementman

6-May-03 5:24

You need to wrap the IDI_ICON3 with MakeIntResource as shown in the snippet below:

HRSRC hRscDLL = FindResource(NULL,MAKEINTRESOURCE(IDI_ICON3),RT_ICON);
if (hRscDLL)
{
DWORD dwIconSize = SizeofResource(NULL,hRscDLL);

HGLOBAL hMem = LoadResource(NULL,hRscDLL);
if (hMem)
{
LPVOID pIconBytes = LockResource(hMem);
if (pIconBytes)
{
.........

will13836-May-03 5:36

6-May-03 5:36

Still not having any luck Mad | :mad:

Now i have this:
hResource = FindResource(hModule,MAKEINTRESOURCE(IDI_ICON3),RT_ICON);

but yet it still comes back as NULL Confused | :confused:

Here is how it's defined in the .rc file for the app I'm loading:

// Icon with lowest ID value placed first to ensure application icon
// remains consistent on all systems.
IDI_ICON3 ICON DISCARDABLE "Eye.ico"

So what the heck am I doing wrong?

Any other ideas, suggestions, comments? You're helping alot so far.

thanks!

Dan

David Crow6-May-03 6:02

6-May-03 6:02

Does IDI_ICON3 equate to the same number in both applications?

will13836-May-03 6:47

6-May-03 6:47

DavidCrow wrote:
Does IDI_ICON3 equate to the same number in both applications?

Laugh | :laugh:

good question.

But yes they are the same number. I made sure they were.

The number is 104, and I made sure that the number is the same.

any other ideas Confused | :confused:

Thanks!

Dan

will13836-May-03 7:21

Problem regerding LineTo(..)

6-May-03 7:21

Woo Hoo!

I finally understand it!

Turns out that I need to be using the RT_GROUP_ICON because I'm not using hardware-dependent icons. Smile | :)

I was then able to try other resource types and successfully got the information I needed.

Thanks Guys! I really appreciate the help!

Dan

summo6-May-03 3:21

summo

6-May-03 3:21

I want to draw lines on a dialog in MFC(SDI) application.
Currently I am doing the same thing in OnDraw function of my CAppView by using the code.

pDC->MoveTo(x1,y1);
pDC->MoveTo(x1,y2);

Now I want to draw these lines on a dialog. Is it possible. Can I use the same functions. If yes, Then what would I use in place of pDC to call these functions.
If not refer me other ways of doing so.

Reply me soon

Re: Problem regerding LineTo(..)

JensB6-May-03 4:42

JensB

6-May-03 4:42

pDC->MoveTo(x,y)
That is the startpoint where you will start drawing your line. I don't see why you move 2 times to the same place.

I think you want something like this
pDC->MoveTo(startpointx, startpointy);
pDC->LineTo(endpointx, endpointy);

so you needed LineTo with a EndPoint of course

i hope this helps

Greetings

Jens

Re: Problem regerding LineTo(..)

John R. Shaw6-May-03 7:07

John R. Shaw

6-May-03 7:07

Do the same thing you did in OnDraw() only do it in the dialogs OnPaint().

Trust in the code Luke. Yea right!

CFile %&%

macmac386-May-03 2:50

6-May-03 2:50

Hello,

this:
CFileDialog dlg(FALSE);

CString fname = dlg.GetPathName();
const char* szBuffer = fname;

int i = sizeof(szBuffer);

CFile f;
if( f.Open ("F:\\test\\id.txt", CFile::modeWrite ) ){
try{

f.Write(szBuffer, i);
f.Close();
}

catch (CFileException *e){
AfxMessageBox ("Error!");
e->Delete();
}
}

}

...if you type in "rtf" it insert in my "id.txt" file:

F:\r¼ÖA Q a ¼ºÜþ4 ýýýý€*0 *0 ¬)0 Ì(0 ÍÍÍÍÍÍÍÍØ(0

why??

Thanks, Mark

Mike Zinni6-May-03 3:15

Mike Zinni

6-May-03 3:15

You might want to try:

CFileDialog dlg(FALSE);
CString fname = dlg.GetPathName(); 
const char* szBuffer = fname.GetBuffer(0);
int i = fname.GetLength();

CFile f;
// CFile::modeWrite is OK if you want to append
// data to the end of the file. If you're looking
// to create a new file and have it contain JUST this
// filename, you need to open the CFile with the 
// CFile::modeCreate flag.
if( f.Open ("F:\\test\\id.txt", CFile::modeWrite ) )
{
  try{
    f.Write(szBuffer, i);
    f.Close();
  } catch (CFileException *e)
  {
    AfxMessageBox ("Error!");
    e->Delete();
  }
}
// And remember to release your string pointer.
fname.ReleaseBuffer();

-Mike Zinni

"No sh*t it's tough. If it wasn't, everybody and their sister would be an engineer and then you wouldn't have a job."

macmac386-May-03 3:24

6-May-03 3:24

It works!!!!Thanx.

Thanks, Mark

macmac386-May-03 3:54

6-May-03 3:54

By the way, how can i change the code to read the file?

Thanks, Mark

Mike Zinni6-May-03 4:10

Mike Zinni

6-May-03 4:10

Try:

CFileDialog dlg(FALSE);
CString fname = dlg.GetPathName(); 
char* szBuffer = NULL;
int i = 0;

CFile f;
if( f.Open ("F:\\test\\id.txt", CFile::modeRead ) )
{
  try {
    // Get the size of the file.
    i = f.GetLength();
    // Create buffer to hold file data.
    szBuffer = new char[i];
    // Read in the file data
    if(szBuffer != NULL)
      f.Read(szBuffer, i);
    // Close the file.
    f.Close();
  } catch (CFileException *e)
  {
    AfxMessageBox ("Error!");
    e->Delete();
  } // end TRY-CATCH
} // end IF

// If szBuffer != NULL, it contains the file data.
// Do whatever you want to it, and then make sure you 
// clean up the dynamic memory you new'ed.
if(szBuffer != NULL)
  delete [] szBuffer;

-Mike Zinni

"No sh*t it's tough. If it wasn't, everybody and their sister would be an engineer and then you wouldn't have a job."

macmac386-May-03 4:45

6-May-03 4:45

I must cast the szBuffer to a CString type:

CString csPath = szBuffer;

is this allowed?

Thanks, Mark

David Crow6-May-03 4:49

6-May-03 4:49

Actually, this implicitly casts szBuffer to a LPCTSTR, which CString has an assignment operator for.

macmac387-May-03 3:56

7-May-03 3:56

Nice, but still generates test.pmjyyyxx as output????

Thanks, Mark

David Crow6-May-03 4:20