Re: help making class available to all - C# Discussion Boards

Pete O'Hanlon20-Mar-14 4:57

Pete O'Hanlon

20-Mar-14 4:57

If you want it to be available to all forms, and you are using windows forms, you could always change the constructor to accept a Form instead (and store this in a field of type Form obviously):

public class WC
{
  private Form _form;
  public WC(Form form)
  {
    _form = form;
  }
}

OriginalGriff20-Mar-14 5:56

OriginalGriff

20-Mar-14 5:56

Pete's right - but the other way to do it is to derive your new class from Form, and then derive your forms from your new class. That way, you don't need to construct an instance of your class separately, and the code you add is available to operate on the form immediately, without passing a form reference to it.

Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952)
Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)

BobJanova20-Mar-14 7:55

BobJanova

20-Mar-14 7:55

There is an implicit interface here: this code can never work in a form which doesn't have an OutputConsole and an ErrorConsole, as well as working with InvokeC (I don't know what that requires but presumably BeginInvoke).

So the most general you can get would be to make the thing passed to the constructor be an instance of that interface:

interface IMessageLogger {
 void LogToOutput(string message);
 void LogToError(string message);
 void InvokeAsync(Action<string> method, string method);
}

class WC { // this name is terrible, change it!
 private IMessageLogger logger;
 public WC(IMessageLogger logger) { this.logger = logger; }

 public void ConWrite(string text, int target = 0) {
  Console.WriteLine(text);
  switch(target) {
   case 1: logger.InvokeAsync(logger.LogToOutput, text); break;
   case 2: logger.InvokeAsync(logger.LogToError, text); break;
 }
}

There's a design decision here about whether that asynchroneity should be hidden inside the implementation of LogToOutput; I'd say it probably should, but I wanted to leave this code recognisably derived from yours.

Your MainWin would then need to implement IMessageLogger (writing items to the OutputConsole and ErrorConsole in the LogToOutput and LogToError methods). InvokeAsync would be a thin cover on BeginInvoke or Invoke:

public void InvokeAsync(Action<string> method, string text) {
 // IIRC you can't use a lambda here for some reason
 BeginInvoke(delegate() { method(text) }); 
}

how to use Response.Clear() in c#

Bosskardo21-Mar-14 1:44

Bosskardo

21-Mar-14 1:44

Good idea but I couldn't get interface to work.
Managed to solve it with events.

Message Removed

20-Mar-14 3:39

Marco Bertschi

20-Mar-14 3:39

Message Removed

modified 20-Mar-14 10:11am.

rincy sivan20-Mar-14 1:51

rincy sivan

20-Mar-14 1:51

Hi
how to use Response.Clear() in c#

Re: how to use Response.Clear() in c#

Rob Philpott20-Mar-14 3:02

Rob Philpott

20-Mar-14 3:02

Context?

Regards,
Rob Philpott.

c# code to copy paste whole pivot table in another sheet of excel

rajnknit0719-Mar-14 23:32

rajnknit07

19-Mar-14 23:32

Hi,
I have a pivot table in excel sheet 1. I need to write a C# code to copy and paste whole pivot table in sheet 2 of same excel file. While copying, I need to expand all columns data also.

Please help me in doing this.

Thanks

Re: c# code to copy paste whole pivot table in another sheet of excel

Eddy Vluggen20-Mar-14 10:27

[solved] Passage of events between WinForms

20-Mar-14 10:27

rajnknit07 wrote:
Please help me in doing this.

Help with what exactly?

As is, you only specified what the finished solution should do. Divide your problem in smaller things, like reading an Excel file using C#, writing a file, and then move on to modifying data.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Mario 5619-Mar-14 23:27

19-Mar-14 23:27

Hi all,
I would like to know what is the best way to manage the passage of events between WinForms.
I have to click on the MainForm 6 buttons with either the mouse or using 6 corresponding digital inputs.
Obviously with the mouse there are no problems, but to use the digital inputs as mouse-clicks, I have written a class that runs a background timer-thread that reads the digital inputs and uses delegates to notify the MainForm on the changes of the digital inputs (from 0 to 1) so that his handlers can perform the function:
key-x.PerformClick()
to call the method linked to the x button.

My problem is: how can I do it as fast, clean and safe using MainForm modal-forms childs ? And overall, what about with the children of the children that can be up to the 4-th level depth ? The 6 buttons have form by form always to perform different operations.
OK, I can use a chain of delegates among the various modal-form-childs but it is ugly and not so simple, fast and very safe to realize.

Any idea ?

modified 24-Mar-14 12:20pm.

Eddy Vluggen20-Mar-14 6:37

20-Mar-14 6:37

What do you mean with a "digital input"? I'd assume you'd loop through your forms, and hook up any buttons using reflection.

Am I right that you want to see an event raised in the mainform when one of the buttons on the child-forms is clicked?

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Mario 5620-Mar-14 7:33

20-Mar-14 7:33

Thank you for the answer Eddy, I have 6 on/off digital-inputs pins on an electronic interface connected to the pc that 'clicks' the 6 buttons on the frames as a mouse. Pin 1 for button 1, . . . pin 6 for button 6 just like a mouse. The mainform received the 6 inputs 'buttons' states from a communicationInterface timer-thread that reads the input pins and I need to send these input states also to the last open child-form that many times it can be a child of a child of a child of the mainform.

Eddy Vluggen20-Mar-14 10:35

20-Mar-14 10:35

Mario 56 wrote:
The mainform received the 6 inputs 'buttons' states from a communicationInterface timer-thread that reads the input pins and I need to send these input states also to the last open child-form that many times it can be a
child of a child of a child of the mainform.

So, there's never more than 6 buttons? Acting on one of the six buttons of the currently active form?

You don't need to send those states back and forth between the forms; put them in a separate class and share it between the forms.

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

Mario 5620-Mar-14 14:44

20-Mar-14 14:44

No Eddy, I cannot simply share the inputs using a separate class, WinForm threads can be awakened only using events or with a timer loop to read the digital inputs in every opened child form. I have solved the problem using delegate:

SQL

public delegate void Key1();
public Key1 extKey1Delegate;
public delegate void Key2();
public Key2 extKey2Delegate;
public delegate void Key3();
public Key3 extKey3Delegate;
public delegate void Key4();
public Key4 extKey4Delegate;
public delegate void Key5();
public Key5 extKey5Delegate;
public delegate void Key6();
public Key6 extKey6Delegate;

public mainForm
{

extKey1Delegate = new Key1(Key1Method);
extKey2Delegate = new Key2(Key2Method);
extKey3Delegate = new Key3(Key3Method);
extKey4Delegate = new Key4(Key4Method);
extKey5Delegate = new Key5(Key5Method);
extKey6Delegate = new Key6(Key6Method);

}

and in the commInterface class that read the digital inputs:

_interfaceInputStatus = modbus.ReadInputs(1);
if (_interfaceInputStatus[(int)keyButtons.KEY1]) { extFormControl.Invoke(extFormControl.extKey1Delegate); }
if (_interfaceInputStatus[(int)keyButtons.KEY2]) { extFormControl.Invoke(extFormControl.extKey2Delegate); }
if (_interfaceInputStatus[(int)keyButtons.KEY3]) { extFormControl.Invoke(extFormControl.extKey3Delegate); }
if (_interfaceInputStatus[(int)keyButtons.KEY4]) { extFormControl.Invoke(extFormControl.extKey4Delegate); }
if (_interfaceInputStatus[(int)keyButtons.KEY5]) { extFormControl.Invoke(extFormControl.extKey5Delegate); }
if (_interfaceInputStatus[(int)keyButtons.KEY6]) { extFormControl.Invoke(extFormControl.extKey6Delegate); }

and in the mainForm class using them with the code:

//-----------------------------------------
// input keys delegated method
//-----------------------------------------
private void key1_Click(object sender, EventArgs e)
{
      . . . .
}

. . . . .

private void key6_Click(object sender, EventArgs e)
{
      . . . .
}

void Key1Method()
{
    if (mainFlag) key1.PerformClick();   // if not child opened click the mainForm key
    else KeyCallback(1);                 // otherwise subscribe all the open childs
}
void Key2Method()
{
    if (mainFlag) key2.PerformClick();
    else KeyCallback(2);
}
void Key3Method()
{
    if (mainFlag) key3.PerformClick();
    else KeyCallback(3);
}
void Key4Method()
{
    if (mainFlag) key4.PerformClick();
    else KeyCallback(4);
}
void Key5Method()
{
    if (mainFlag) key5.PerformClick();
    else KeyCallback(5);
}
void Key6Method()
{
    if (mainFlag) key6.PerformClick();
    else KeyCallback(6);
}

and then every opened child subscribe the event to all its children. obviously exists a table where is specified which method of which class should serve the input event.

I would be glad if someone would tell me what is the method to know which is the form currently in use so maybe I can avoid to use the table. Every form is modal.

Thank you

Eddy Vluggen21-Mar-14 7:29

21-Mar-14 7:29

Mario 56 wrote:
I would be glad if someone would tell me what is the method to know which is the form currently in use

Form.ActiveForm[^]

"Gets the currently active form for this application."

Bastard Programmer from Hell Suspicious | :suss:

If you can't read my code, try converting it here[^]

BobJanova20-Mar-14 8:06

BobJanova

20-Mar-14 8:06

This sounds like a case when you really want a MVVM type separation of concerns. The model is whether the 6 items are 'on'; that can be affected by several things, not just the UI, so putting logic about them in the UI is wrong.

You don't actually need a VM if the model is simple enough to bind to the view, so I think what you need from a code perspective is: a model class which implements INotifyPropertyChanged so you can bind it:

class Input { // pick a more domain relevant name
 private bool on;
 public bool On {
  get { return on; }
  set { on = value; Notify("On"); }
 }

 // INPC implementation
 public event PropertyChangedEventHandler PropertyChanged;

 private void Notify(string property) {
  var handler = PropertyChanged;
  if(null != handler) handler(this, new PropertyChangedEventArgs(property));
 }
}

class DataModel {
 public IList<Input> Inputs { get; private set; }
 public DataModel() {
  Inputs = new List<Input>();
  for(int i = 0; i < 6; i++) Inputs.Add(new Input());
 }
}

Your UI should be given the data model and data bind to it; let's imagine check boxes for the sake of simplicity, but you can use anything that has a boolean property you can bind to, including custom controls:

class MainForm : Form {
 // ...
 public MainForm(DataModel dataModel) {
  InitializeComponent();

  for(int i = 0; i < 6; i++) {
   (CheckBox)(checkBoxGroup.Controls[i]).DataBindings.Add("Checked", dataModel.Inputs[i], "On");
  }
 }
}

If you have to poll the serial port to find out the real state of these things, then that's unfortunate but it's okay. Just set the On property of the Inputs in the data model (make sure it's the same instance!) and the UI should update.

Don't bind actions to the buttons being clicked. Instead, subscribe to the property notification changes from the inputs. (Or, probably better, have the data model do that and fire a custom event instead.)

Mario 5620-Mar-14 9:51

20-Mar-14 9:51

Thanks Bob, your implementation of the processing of the digital inputs is really very efficient using notify. The 6 digital inputs (on/off) can only be on one at a time and they have to be treated as real push-buttons, and in fact, they have to simply replace the 6 push-buttons in the various forms (main and nested child forms) that are clicked with the mouse and are used when the enclosure that contains the pc is closed and then the 'push-buttons' should be operated by the 6 digital inputs instead of the mouse or push-screen. My main problem is how to communicate efficiently the status of the digital input to the opened child forms that can have also many levels of nesting. As you know the thread of a form sleep since it doesn't receive a winform event pushed in its dispatcher pump so I need the best and simple way to concatenate the series of event and relative delegate from child forms to main, but overall from main to childs and from main to children of the childs. The thread that reads the digital inputs is one and this communicate the state of the inputs to the mainForm.

Re: Passage of events between WinForms [Solved]

BobJanova21-Mar-14 0:20

BobJanova

21-Mar-14 0:20

You can data bind an instance of this Input class to multiple forms. Data binding to something which implements INPC will result in that control being updated when the event's fired.

I think I might have not understood what the 'inputs' are though. I thought you were reading the state of pins on a serial cable or something similar where on and off were both relevant; it seems like you actually want to fire the same handlers when they go to 'on' as when buttons are clicked, and 'off' doesn't matter.

In that case, you should put your processing code in a single place (you can call that class App or StateManager or Processor or other similarly generic things), and have the event handlers on your many forms do nothing except call methods on this central class. This is a classic 3 tier architecture (separation of view, logic and data), except that your data model is probably quite minimal. You can then attach event handlers to whatever mechanism you use to notify changes to the state of the external inputs, which call the same methods. If you need a UI cue to be reflected back to forms, use data binding to classes in the data model which implement INPC.

Mario 5621-Mar-14 6:56