The Weird and The Wonderful

Rich.Edwards wrote:

This really pushes my buttons

Dim s As String
s = "" & rs!value

Dim i As Integer
Dim s As String
s = 123
s = 123 & ("" & val(s)) && ("" & i)

Rob Grainger wrote:

The code is liberally littered with them. I can almost forgive it on db
access:

VB

<SPAN class=code-keyword>Dim</SPAN> s <SPAN class=code-keyword>As</SPAN> <SPAN class=code-keyword>String</SPAN>
s = <SPAN class=code-string>"</SPAN><SPAN class=code-string>"</SPAN> & rs!value

Rob Grainger wrote:

I think the approach is "we're not sure when we need to cast, or how to do it,
so we'll cast everywhere just in case.

Rob Grainger wrote:

"Looks like some VB4 code" - apparently not, the company was born in 2003!

Quote William Edward Hickson[^]:

'Tis a lesson you should heed:
Try, try, try again.
If at first you don't succeed,
Try, try, try again.

• What is the point of using ref? objWord is not assigned any value. I guess, the author has never heard of reference types and value types, doesn't differentiate them and also is a former C++ developer.
• If an exception is generated, a variable, representing it, can NEVER be null. And the check
  C#

  ex != null

  just looks stupid.
• Also, it will sound very upsetting for the author, but if the exception mentioned above is ever generated, he is about to face an infinite recursion, hence he will also face the full power of the StackOverflowException.

int normalRetirementAge()
{
  if (isMale())
  {
    return 65;
  }
  else
  {
    return 60;
  }
}

int normalRetirementAge()
{
  if (isMale())
  {
    return 60;
  }
  else
  {
    return 60;
  }
}