C#

public void ServerSendMessage(string msg)
        {
            stream = client.GetStream(); //Gets The Stream of The Connection

            StreamWriter writer = new StreamWriter(stream);


            int length = data.Length; // Gets the length of the byte data

            /* send a command to prepare client to receive a message */
            writer.Write("MESSAGE "+length+"\n");

            stream.Write(msg); //Sends the real data

            stream.Write("\r\n");
        }

/* send a KEY ALG LEN \n
   KEY_IN_BASE64 ENCODING\r\n message*/

public void ServerSendKey(byte[] key, string alogrithm)
        {
            stream = client.GetStream(); //Gets The Stream of The Connection

            StreamWriter writer = new StreamWriter(stream);


            int length = key.Length; // Gets the length of the byte data

            /* send a command to prepare client to receive a message */
            writer.Write("KEY "+ALGORITHM+" "+length+"\n");

            writer.Write(Convert.ToBase64String(key)); //send base64 encoded key


            writer.Write("\r\n");
        }

public void ClientReceive()
        {

            stream = client.GetStream(); //Gets The Stream of The Connection
            StreamReader reader = new StreamReader(stream)
            string message = reader.ReadLine();
            while(reader.peek() > -1 || !message.Equals("END"))
            {
                 if(message.StartsWith("MESSAGE") {
                    ParseMsg(message,reader);
                 } else if(message.StartsWith("KEY") {
                    ParseKey(message,reader);
                 }
            }
            message = reader.ReadLine();
        }

        private void ParseMsg(string cmd,StreamReader r)
        {
              int length = Integer.ParseInt(cmd.SubString(8));

              char[] msg = new char[length];
              r.ReadBlock(msg,0,length);

              string message = new String(msg);
              //do something with your message...
        }

        private void ParseKey(string cmd,StreamReader r)
        {
              string alg = cmd.SubString(3,3);
              int length = Integer.ParseInt(cmd.SubString(9));

              byte[] key = Convert.FromBase64String(r.ReadLine());

              //do something with your key...
        }

NOTE: Not ready for Production Code... Run tests!

neodeaths wrote:

is there a best practice

Bastard Programmer from Hell
If you can't read my code, try converting it here[^]

Keith Barrow wrote:

public string RedemptionCode
{
   get
   {
      if(Code.HasValue)
         return BatchCode + RedemptionCode;
      return "";
   }
}

public string RedemptionCode
{
   get
   {
      return Code.HasValue ? BatchCode + Code : string.Empty;
   }
}

public void Claim(string batch, int code)
{
   if (Code.HasValue) throw new InvalidOperationException("Voucher has already been claimed.");
   
   Code = code;
   BatchCode = batch;
}

Keith Barrow wrote:

Where I'm working we have lots of code reviews and there is enough difference for the way I usually work and how they want things done

Keith Barrow wrote:

The reviewer thinks that there shouldn't be any processing in a property,

public static string MakeSomeValue(double value1, string value2){
return some work
}
public string MakeSomeValue(){
return MakeSomeValue(Value1, Value2);
}

Ennis Ray Lynch, Jr. wrote:

I disagree. Properties were created because the language designer didn't like
accessors and getters and wanted a cleaner method for acessing and getting
members. While it certainly adds the ability to add logic, that is a major faux
paus to do any more than is absolutely necessary at the bare minimum. Methods
are more appropriate when actually functionality is desired.

Ennis Ray Lynch, Jr. wrote:

Reference to accessors and setters