C / C++ / MFC

static DWORD CALLBACK readlisting(
         DWORD dwCookie,      // (in) pointer to CFile
         LPBYTE pbBuff,       // (in) pointer to the destination buffer
         LONG cb,             // (in) size in bytes of the destination buffer
        LONG FAR *pcb        // (out) number of bytes transfered
       )
 {
  UNREFERENCED_PARAMETER(cb);
          static BOOL flag = 0;
 //        LPCTSTR lpch;
		 int length;
        // CString buffer((LPCTSTR) lpch,135);
		 CString buffer; 
              //   char *holdptr;
                                 LPBYTE holdptr1;
                 int n;
                 CStdioFile* pFile = (CStdioFile*) dwCookie;

         switch (flag)
                 {
                 case 0:


                         flag = 1;


                                                do {
                                                     pFile->ReadString(buffer);
                                                    } while(buffer.Find((LPCTSTR)"CSECT") == -1);
                        length = buffer.GetLength();                                  
                        strcpy((char *) pbBuff,(char *)buffer.GetBuffer(length));
						holdptr1 = pbBuff + length;
						memcpy(holdptr1,"\r\n",2);
                          //     *pcb = 135;                // 87 btes transfer
							*pcb = length;
                        return 0;
                         break;
                 case 1:

                                                 while(TRUE)
                                                 {
                                                  pFile->ReadString(buffer);
												                                           length = buffer.GetLength();
                                                 if(buffer.Find((LPCTSTR)"END") > 0)
												 {
													                                        *pcb = 0;              // finish it up
                                                          return 0;          //
												 }
                  if(buffer.Find((LPCTSTR) "  ") < 2 || buffer.Find((LPCTSTR) "    ")    
                                                  ==7)          // no Location counter or opcode 
                                                 {
                                                  memset(pbBuff,0x20,135);
                                                  strcpy((char *)pbBuff,"  ");
                                                  holdptr1 =  pbBuff + 2;
                                                  memcpy(holdptr1,buffer.GetBuffer(length),length);
                                                  holdptr1 = holdptr1 + length;
                                                  memcpy(holdptr1,"\r\n",2);
                                                  *pcb = length + 2;
                                                         return 0;
                                                 }
                                                 else
                                                 {
												                                         n = buffer.Find((LPCTSTR) "    ");
                                                  memset(pbBuff,0x20,135);
                                                  strcpy((char *)pbBuff,"_ ");
                                                  holdptr1 =  pbBuff + 2;
                                                  memcpy(holdptr1,buffer.GetBuffer
                                                  (length),length);  // copy over location counter
                                                  holdptr1 = holdptr1 + length;
                                                   memcpy(holdptr1,"\r\n",2);
                                                   *pcb  = length + 2;
                                                   return 0;
                                                 }
                                                                                                 }
                 }
      return 0;
 }

memcpy(holdptr1,"\r\n",2);
//     *pcb = 135;                // 87 btes transfer
*pcb = length;  // should be length + 2

• You are mixing strcpy() and memcpy() calls. This will cause problems if you want to convert this to Unicode in the future.
• Similarly you are using a LPBYTE pointer instead of LPTSTR. Your code is manipulating characters so all pointers should be character types, not byte.
• In the second case clause, in both blocks you are prepending two characters to the buffer, but you are not adding two to the *pcb value to take account of this.
• In the same place, you are using memset() to initialise the buffer with 135 spaces. This serves no purpose, but to waste time and code.

char foo[10] = "string";
// or
char* foo = "string";

Coder Block wrote:

nop i need array of charecter pointer??

char* foo[10] =
{
    { "string1" },
    { "string2" },
    { "string3" },
// ...
    NULL // use to signify end of array if length is not known at compile time.
};

Coder Block wrote:

char* TempArray[10];