C#

devvvy wrote:

SCENARIO 2 - humble timing while loop: I'm not hearing any reason not to use it. As indicated

while(!exit)
{
    // Do your job
    Thread.Sleep(10000);
}

devvvy wrote:

This is an over discussed subject, gives people wrong impression this is actually complicated, that Thread.Sleep is really evil.

Pete O'Hanlon wrote:

then why not use a timer?

Pete O'Hanlon wrote:

it's so discussed is that it does have drawbacks, and it can be inherently risky. I

Pete O'Hanlon wrote:

don't use something because it saves you a few keystrokes, use the tool that is right and appropriate.

Pete O'Hanlon wrote:

Suppose that your application creates 10 threads and then puts them to sleep for 30 seconds, and each thread has opened up some resources that must be disposed of when the thread completes. Now, suppose that 2 seconds into this, your application wants to close - what do you think the effect will be?

<br />
try {<br />
   while(true) {<br />
       using(Stream...)<br />
       {<br />
            ... <br />
            Thread.Sleep(#1) <-- What would happen? indeterministic<br />
       } <-- Dispose here anyway as "using" translated to try-finally (But what if aborted during finally)<br />
<br />
       Thread.Sleep(#2) <-- fine already disposed<br />
    }<br />
catch(ThreadAbortEx)<br />
{<br />
<br />
}<br />
finally{<br />
<br />
}<br />

Simon_Whale wrote:

What would you recommend as a better method of doing the same as thread.sleep inside a thread?

devvvy wrote:

THUS FAR there isn't ONE SINGLE argument that justify against use of
Thread.Sleep against SCENARIO 2.

Pete O'Hanlon wrote:

Errm. Yes, we have posted arguments against, you're just choosing to ignore them.

devvvy wrote:

1. As I pointed out earlier, there's no need to know *exact* when the blocked thread wakes up again.

Pete O'Hanlon wrote:

There is if you're trying to shut down an application. I don't know how many times I can point out the same thing; perhaps with a simple example - you have a service with a thread that needs to clean up before the service can shut down - by having to wait for the thread to finish, you could trigger the "Service could not be stopped, blah blah blah" message.

<br />
static void Main(string[] args)<br />
        {<br />
            Thread t = new Thread(new ThreadStart(ThreadFunc));<br />
            t.Start();<br />
<br />
            Console.WriteLine("Hit any key to exit.");<br />
            Console.ReadLine();<br />
<br />
            Console.WriteLine("App exiting");<br />
            return;<br />
        }<br />
<br />
        static void ThreadFunc()<br />
        {<br />
            int i=0;<br />
            try<br />
            {<br />
                while (true)<br />
                {<br />
                    Console.WriteLine(i);<br />
                    Thread.Sleep(1000 * 10);<br />
                    i++;<br />
                }<br />
            }<br />
            finally<br />
            {<br />
                Console.WriteLine("Exiting while loop");<br />
            }<br />
            return;<br />

devvvy wrote:

THUS FAR there isn't ONE SINGLE argument that justify against use of Thread.Sleep against SCENARIO 2.

public class Utility
{
  private static readonly object SyncLock = new object();

  public void WaitForTime(int milliseconds)
  {
    lock (SyncLock)
    {
      Monitor.Wait(SyncLock, milliseconds);
    }
  }

  public WakeAllThreads()
  {
    lock (SyncLock)
    {
      Monitor.PulseAll(SyncLock);
    }
  }
}