The Weird and The Wonderful

public override void CreateEntity()
{
   try
   {
      // blah, blah, blah...
      
      base._database.ExecuteNonQuery(storedProcCommandWrapper);
      
      int parameterValue = (int) storedProcCommandWrapper.GetParameterValue("@RETURN_VALUE");
      if (parameterValue == 0)
      {
         throw new Exception("Create failed.");
      }

      // blah, blah...
   }
   catch (Exception exception)
   {
      exception.Message.ToString(); // Why?!
      throw new Exception("Exception occured", exception); 
      // OK, let's not bother checking the spelling of the message either!
   }
}

try
{
   customer.CreateEntity();
}
catch (Exception ex)
{
   MessageBox.Show(ex.Message);
}

Andrei Straut wrote:

Yes, I'm a devious SOB, but hey, if they don't care, why should I?

Naerling wrote:

Keep an active log inside your code

Naerling wrote:

I guess someday I'll laugh about it

AspDotNetDev wrote:

When the company collapses and you find a new job with reasonable code practices.

public class Naerling : Lazy<Person>{
    public void DoWork(){ throw new NotImplementedException(); }
}

CIDev wrote:

there are likely other bad practices

public class Naerling : Lazy<Person>{
    public void DoWork(){ throw new NotImplementedException(); }
}

if (Page.IsPostBack == false)
{
    int status = -1;
    if (_statusBy == Status.FirstStatus)
    {
        status = 0;
    }
    if (_statusBy == Status.SecondStatus)
    {
        status = 1;
    }
    if (_statusBy == Status.ThirdStatus)
    {
        status = 2;
    }
    litStatus.Text = status.ToString();
}
string strCmdMySqlCmd = "SELECT * FROM myTable WHERE mtStatus = " + litStatus.Text + " AND mtRecordNumber = " + Request.QueryString["PleaseInjectSomeSql"];
myDataSource.SelectCommand = strCmdMySqlCmd;

AspDotNetDev wrote:

That is far better than some of the garbage I have seen well-aged developers who have been with the company for years do

AspDotNetDev wrote:

Count yourself lucky to have such a bright apprentice.

jim lahey wrote:

despite his ability to understand and get on with things fairly autonomously he still does some slightly daft stuff

public class Naerling : Lazy<Person>{
    public void DoWork(){ throw new NotImplementedException(); }
}